lib: add navigator.language and navigator.languages #50303

Uzlopak · 2023-10-20T04:03:08Z

This adds navigator.language and navigator.languages based on the capabilities of ICU.

@anonrig

doc/api/globals.md

lib/internal/navigator.js

src/node_i18n.cc

test/parallel/test-navigator.js

doc/api/globals.md

GeoffreyBooth · 2023-10-26T17:27:39Z

Let’s please ping @nodejs/web-standards for all issues and PRs related to navigator.

panva

This doesn't seem entirely useful given it's based on the capabilities of ICU which for most is bundled.

Consider this a non-blocking -1 that you may dismiss given there's demand for this behaviour.

doc/api/globals.md

GeoffreyBooth · 2023-10-29T02:27:31Z

This doesn't seem entirely useful given it's based on the capabilities of ICU which for most is bundled.

Consider this a non-blocking -1 that you may dismiss given there’s demand for this behaviour.

@panva can you explain? What do you mean by “given it’s based on the capabilities of ICU which for most is bundled”?

The reason to add these properties, like most of the navigator properties, is to enable code that was written for browsers to run without erroring in Node. All of the navigator properties are duplicative of existing Node APIs that provide the same information; that’s irrelevant, because the point is to support code that isn’t written for Node.

Uzlopak · 2023-10-29T02:37:31Z

I thought about this PR and simplified it.

Can you set the default locale of icu in node? If yes, than this PR is still wrong, as it should use that value instead.
But if you cant set the default locale of icu, than this PR should be correct.

GeoffreyBooth · 2023-10-29T03:17:32Z

Can you set the default locale of icu in node? If yes, than this PR is still wrong, as it should use that value instead.

Yes, you can:

LC_ALL=en_US node --print 'new Date().toLocaleString()'
10/28/2023, 8:13:49 PM

LC_ALL=en_UK node --print 'new Date().toLocaleString()'
10/28/2023, 20:13:55

I don’t know if LC_ALL is the only way to set it, but it’s at least one way. You can use Intl.DateTimeFormat().resolvedOptions().locale to see what Node is using:

LC_ALL=en_US node --print 'Intl.DateTimeFormat().resolvedOptions().locale'
en-US

LC_ALL=en_UK node --print 'Intl.DateTimeFormat().resolvedOptions().locale'
en-UK

It was non-blocking in the first place. If the new approach just returns Intl.DateTimeFormat().resolvedOptions().locale it's fine.

Uzlopak · 2023-10-29T13:06:18Z

@GeoffreyBooth

Nice. LOL, you dont know how much i searched around to find this retrieval opportunity.

Falling back to 'en-US' if Intl does not exist. I guess. how can I configure make to build with full intl?

I oriented the functionality based on the behaviour of Chrome and Firefox. So if you use defineProperty to overwrite navigator.language, then languages wont be changed, like in the browser. Also the Array of navigator.languages is frozen, like it is in chrome and firefox.

Can someone please add the 'author-ready' label and remove the 'c++' and 'i18n-api' labels

GeoffreyBooth

Let's add a test that uses spawnPromisified to start a Node process with an LC_ALL of something non-default, and see that it carries through to this new property.

We should also mention in the docs that this environment variable is one way to set Node's default language.

GeoffreyBooth · 2023-10-29T14:15:35Z

how can I configure make to build with full intl?

See https://github.com/nodejs/node/blob/65087c04866dad805554102592754f1262bfb3b2/doc/api/intl.md

lib/internal/navigator.js

doc/api/globals.md

lib/internal/navigator.js

Uzlopak · 2023-10-30T00:36:42Z

@panva
@jasnell
@GeoffreyBooth
@anonrig

PTAL

And if somebody approves, please add then the author-ready label :)

doc/api/globals.md

nodejs-github-bot · 2023-11-04T13:28:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55442/

nodejs-github-bot · 2023-11-04T18:07:44Z

Landed in 77b0595

PR-URL: nodejs#50303 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

PR-URL: #50303 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

targos · 2023-11-13T07:24:52Z

This is semver-minor. Collaborators, please think about adding the label in future pull requests. It will make the work of releasers easier.

Notable changes: doc: * add MrJithil to collaborators (Jithil P Ponnan) #50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib: * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562 * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303 * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385 stream: * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097 * use Array for Readable buffer (Robert Nagy) #50341 * optimize creation (Robert Nagy) #50337 test_runner: * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443 PR-URL: #50681

PR-URL: #50303 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

Notable changes: doc: * add MrJithil to collaborators (Jithil P Ponnan) #50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740 fs: * add stacktrace to fs/promises (翠 / green) #49849 lib: * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562 * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303 * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385 stream: * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097 * use Array for Readable buffer (Robert Nagy) #50341 * optimize creation (Robert Nagy) #50337 test_runner: * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443 PR-URL: #50681

Notable changes: doc: * add MrJithil to collaborators (Jithil P Ponnan) nodejs#50666 * add Ethan-Arrowood as a collaborator (Ethan Arrowood) nodejs#50393 esm: * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) nodejs#48740 fs: * add stacktrace to fs/promises (翠 / green) nodejs#49849 lib: * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) nodejs#50562 * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) nodejs#50303 * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) nodejs#50385 stream: * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) nodejs#50097 * use Array for Readable buffer (Robert Nagy) nodejs#50341 * optimize creation (Robert Nagy) nodejs#50337 test_runner: * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) nodejs#50018 * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) nodejs#48638 test_runner, cli: * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) nodejs#50443 PR-URL: nodejs#50681

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. i18n-api Issues and PRs related to the i18n implementation. needs-ci PRs that need a full CI run. labels Oct 20, 2023

tniessen reviewed Oct 20, 2023

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

doc/api/globals.md Outdated Show resolved Hide resolved

anonrig reviewed Oct 20, 2023

View reviewed changes

GeoffreyBooth added the web-standards Issues and PRs related to Web APIs label Oct 26, 2023

panva previously requested changes Oct 26, 2023

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

Uzlopak force-pushed the navigatorLanguageS branch from f82d7a3 to 5bdd487 Compare October 29, 2023 02:22

Uzlopak force-pushed the navigatorLanguageS branch 2 times, most recently from 332aa0a to 74ac025 Compare October 29, 2023 02:35

Uzlopak force-pushed the navigatorLanguageS branch 3 times, most recently from ec11b6d to f0ab0c0 Compare October 29, 2023 13:01

GeoffreyBooth reviewed Oct 29, 2023

View reviewed changes

ljharb reviewed Oct 29, 2023

View reviewed changes

lib/internal/navigator.js Show resolved Hide resolved

jasnell reviewed Oct 29, 2023

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell reviewed Oct 29, 2023

View reviewed changes

lib/internal/navigator.js Show resolved Hide resolved

Uzlopak force-pushed the navigatorLanguageS branch 2 times, most recently from fed4162 to 701237a Compare October 30, 2023 00:35

GeoffreyBooth reviewed Oct 30, 2023

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

doc/api/globals.md Show resolved Hide resolved

doc/api/globals.md Outdated Show resolved Hide resolved

doc/api/globals.md Outdated Show resolved Hide resolved

Uzlopak closed this Oct 30, 2023

Uzlopak force-pushed the navigatorLanguageS branch from 701237a to 14af167 Compare October 30, 2023 08:00

GeoffreyBooth approved these changes Nov 4, 2023

View reviewed changes

GeoffreyBooth added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2023

Uzlopak requested review from panva, jasnell, ljharb, targos and tniessen November 4, 2023 16:46

GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 4, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 4, 2023

nodejs-github-bot merged commit 77b0595 into nodejs:main Nov 4, 2023
56 checks passed

github-actions bot mentioned this pull request Nov 5, 2023

CI Reliability 2023-11-05 nodejs/reliability#708

Open

13 tasks

Uzlopak deleted the navigatorLanguageS branch November 5, 2023 12:02

This was referenced Nov 6, 2023

CI Reliability 2023-11-06 nodejs/reliability#709

Open

CI Reliability 2023-11-07 nodejs/reliability#710

Open

CI Reliability 2023-11-08 nodejs/reliability#711

Open

anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023

lib: add navigator.language & navigator.languages

e0b1c61

PR-URL: nodejs#50303 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

targos pushed a commit that referenced this pull request Nov 11, 2023

lib: add navigator.language & navigator.languages

80f5bee

PR-URL: #50303 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

targos mentioned this pull request Nov 12, 2023

v21.2.0 release proposal #50681

Merged

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 13, 2023

targos pushed a commit that referenced this pull request Nov 14, 2023

lib: add navigator.language & navigator.languages

03c730b

PR-URL: #50303 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

richardlau added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Mar 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: add navigator.language and navigator.languages #50303

lib: add navigator.language and navigator.languages #50303

Uzlopak commented Oct 20, 2023 •

edited

Loading

GeoffreyBooth commented Oct 26, 2023

panva left a comment

GeoffreyBooth commented Oct 29, 2023 •

edited

Loading

Uzlopak commented Oct 29, 2023

GeoffreyBooth commented Oct 29, 2023

Uzlopak commented Oct 29, 2023

GeoffreyBooth left a comment

GeoffreyBooth commented Oct 29, 2023

Uzlopak commented Oct 30, 2023

nodejs-github-bot commented Nov 4, 2023

nodejs-github-bot commented Nov 4, 2023

targos commented Nov 13, 2023

lib: add navigator.language and navigator.languages #50303

lib: add navigator.language and navigator.languages #50303

Conversation

Uzlopak commented Oct 20, 2023 • edited Loading

GeoffreyBooth commented Oct 26, 2023

panva left a comment

Choose a reason for hiding this comment

GeoffreyBooth commented Oct 29, 2023 • edited Loading

Uzlopak commented Oct 29, 2023

GeoffreyBooth commented Oct 29, 2023

Uzlopak commented Oct 29, 2023

GeoffreyBooth left a comment

Choose a reason for hiding this comment

GeoffreyBooth commented Oct 29, 2023

Uzlopak commented Oct 30, 2023

nodejs-github-bot commented Nov 4, 2023

nodejs-github-bot commented Nov 4, 2023

targos commented Nov 13, 2023

Uzlopak commented Oct 20, 2023 •

edited

Loading

GeoffreyBooth commented Oct 29, 2023 •

edited

Loading