v16.20.0 proposal #47272
Merged
v16.20.0 proposal #47272
+49,462
−62,278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #46684 Refs: #46683 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
PR-URL: #45635 Backport-PR-URL: #45644 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #46037 Backport-PR-URL: #45644 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #46710 Backport-PR-URL: #45644 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
PR-URL: #46842 Backport-PR-URL: #45644 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Refs: #44000 - add infra to support externally shared js builtins in support of distos that want to externalize deps that include JS/WASM instead of native code - add support for externalizing - cjs_module_lexer/lexer - cjs_module_lexer/dist/lexer - undici/undici Signed-off-by: Michael Dawson <[email protected]> PR-URL: #44376 Backport-PR-URL: #45867 Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: #46677 Reviewed-By: Luke Karrys <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
PR-URL: #46498 Backport-PR-URL: #46768 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #46778 Backport-PR-URL: #46768 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #46804 Backport-PR-URL: #46768 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #44197 Backport-PR-URL: #46535 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Original commit message:
[base] Fix build with gcc-13
See https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes.
Also see Gentoo Linux bug report: https://bugs.gentoo.org/865981
Change-Id: I421f396b02ba37e12ee70048ee33e034f8113566
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3934140
Reviewed-by: Clemens Backes <[email protected]>
Reviewed-by: Simon Zünd <[email protected]>
Commit-Queue: Clemens Backes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#83587}
Refs: v8/v8@c2792e5
PR-URL: #44961
Fixes: #43642
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
`glob.glob` on Linux returns files in the order returned by the filesystem driver, and the output from this function is stuffed by the Electron build process straight into the `config.gypi` header, causing non-reproducible builds. See this log for an example of the nondeterminism: https://rb.zq1.de/compare.factory-20220901/diffs/nodejs-electron-compare.out PR-URL: #44496 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
PR-URL: #45015 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
require.resolve.paths should returns null with builtin module. when builtin module without `node:` schema, `paths` returns null. But, it don't return null when builtin module with `node:` schema. Fixes: #45001 PR-URL: #45147 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Because OpenSSL v1.x doesn't do that by itself (OpenSSL v3.x does.) Fixes: #45874 PR-URL: #46185 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Avoid an endless loop if no algorithm is available to seed the cryptographically secure pseudorandom number generator (CSPRNG). Co-authored-by: Anna Henningsen <[email protected]> PR-URL: #46237 Fixes: #46200 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Refs: https://c-ares.org/changelog.html#1_19_0 PR-URL: #46415 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Original commit message:
[intl] Revert date formatting behavior change from ICU 72
Replace U+202F with U+0020 after formatting date. This lets websites
continue to work without any changes.
This matches Firefox behavior, according to
https://bugzilla.mozilla.org/show_bug.cgi?id=1806042#c17.
Bug: chromium:1414292, chromium:1401829, chromium:1392814
Change-Id: I7c2b58414d0890f8705e737f903403dc54e5fe57
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4237675
Commit-Queue: Adam Klein <[email protected]>
Reviewed-by: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#85757}
Refs: v8/v8@90be99f
PR-URL: #46646
Refs: #46123
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #46711 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
This reverts commit dee882e. Moved the test that demonstrated what this commit was fixing to the `known_issues` folder. Fixes: #46234 PR-URL: #46721 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Fixes: #43446 PR-URL: #46781 Reviewed-By: theanarkh <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Review requested:
|
Notable changes:
- deps:
- update undici to 5.20.0 (Node.js GitHub Bot)
#46711
- update c-ares to 1.19.0 (Michaël Zasso)
#46415
- upgrade npm to 8.19.4 (npm team)
#46677
- update corepack to 0.17.0 (Node.js GitHub Bot)
#46842
- (SEMVER-MINOR) src: add support for externally shared js builtins
(Michael Dawson) [#44376]
PR-URL: #47272
nodejs-github-bot
added
build
BethGriggs
force-pushed
the
v16.20.0-proposal
branch
from
bf91ceb
to
6fd13be
Compare
This comment was marked as outdated.
This comment was marked as outdated.
VoltrexKeyva
added
release
targos
approved these changes
Mar 28, 2023
This comment was marked as outdated.
This comment was marked as outdated.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/50643/ ✅ |
|
Maybe we should include #47256 |
We'd either need to manually patch the timezone db for ICU 71.1 or update Node.js 16 to ICU 72.1 (which I'm a little hesitant about because we had issues raised about ICU 72.1 around the change to Unicode spaces -- although I think there was a V8 patch to revert (which we'd also then need to avoid breakage)). |
Even more reason not to rush, 2023b is now invalidated due to Lebanon withdrawing the change it was created to address, and users are recommended to either stick with 2023a (which we never landed in Node.js) or wait for 2023c. Refs: https://mm.icann.org/pipermail/tz/2023-March/032829.html |
|
Release build on 6fd13be: https://ci-release.nodejs.org/job/iojs+release/9239 |
I've just noticed that the aforementioned V8 patch is included in this proposal:
For the timezone updates though we'd still either need a PR explicitly for v16.x-staging against ICU 71.1 or another PR to main either downgrading to tz 2023a, or waiting and then updating to 2023c (unicode-org/icu-data#36) and landing ICU 72.1 and the tz update together. I don't think we should delay this release for either of those options. If anyone reads this and needs updated timezone information, a workaround is to locally download the updated |
richardlau
approved these changes
Mar 29, 2023
BethGriggs
added a commit
that referenced
this pull request
Mar 29, 2023
Notable changes:
- deps:
- update undici to 5.20.0 (Node.js GitHub Bot)
#46711
- update c-ares to 1.19.0 (Michaël Zasso)
#46415
- upgrade npm to 8.19.4 (npm team)
#46677
- update corepack to 0.17.0 (Node.js GitHub Bot)
#46842
- (SEMVER-MINOR) src: add support for externally shared js builtins
(Michael Dawson) [#44376]
PR-URL: #47272
BethGriggs
added a commit
to BethGriggs/nodejs.org
that referenced
this pull request
Mar 29, 2023
BethGriggs
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Mar 29, 2023
This was referenced Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023-03-29, Version 16.20.0 'Gallium' (LTS), @BethGriggs
Notable Changes
Commits
de6dd67790] - crypto: avoid hang when no algorithm available (Richard Lau) #462374617512788] - crypto: ensure auth tag set for chacha20-poly1305 (Ben Noordhuis) #4618524972164fc] - deps: update undici to 5.20.0 (Node.js GitHub Bot) #4671185f88c6a8d] - deps: V8: cherry-pick 90be99fab31c (Michaël Zasso) #46646b4ebe6d47b] - deps: update c-ares to 1.19.0 (Michaël Zasso) #4641556cbc7fdda] - deps: V8: cherry-pick c2792e58035f (Jiawen Geng) #449617af9bdb31e] - deps: upgrade npm to 8.19.4 (npm team) #46677962a7471b5] - deps: update corepack to 0.17.0 (Node.js GitHub Bot) #46842748bc96e35] - deps: update corepack to 0.16.0 (Node.js GitHub Bot) #46710a467782499] - deps: update corepack to 0.15.3 (Node.js GitHub Bot) #460371913b6763d] - deps: update corepack to 0.15.2 (Node.js GitHub Bot) #45635809371a15f] - module: require.resolve.paths returns null with node schema (MURAKAMI Masahiko) #45147086bb2f8d4] - Revert "src: let http2 streams end after session close" (Rich Trott) #467216a01d39120] - (SEMVER-MINOR) src: add support for externally shared js builtins (Michael Dawson) #44376d081032a60] - test: fix test-net-connect-reset-until-connected (Vita Batrla) #46781efe1be47ec] - test: skip test depending onoverlapped-checkerwhen not available (Antoine du Hamel) #45015fc47d58abe] - test: remove cjs loader from stack traces (Geoffrey Booth) #44197cf76d0790d] - test: fix WPT title when no META title is present (Filip Skokan) #468040d1485b924] - test: fix default WPT titles (Filip Skokan) #46778088e9cde3d] - test: add WPTRunner support for variants and generating WPT reports (Filip Skokan) #46498908c4dff44] - test: mark test-crypto-key-objects flaky on Linux (Richard Lau) #46684768e56227e] - tools: makeutils.SearchFilesdeterministic (Bruno Pitrus) #44496