[v16.x backport] test: remove cjs loader from stack traces #46535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
GeoffreyBooth
added a commit
to GeoffreyBooth/node
that referenced
this pull request
Feb 7, 2023
PR-URL: nodejs#44197 Backport-PR-URL: nodejs#46535 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
GeoffreyBooth
force-pushed
the
backport-fix-message-tests
branch
from
51436d0
to
255d0f5
Compare
GeoffreyBooth
changed the title
PR-URL: nodejs#44197 Backport-PR-URL: nodejs#46535 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
GeoffreyBooth
force-pushed
the
backport-fix-message-tests
branch
from
255d0f5
to
200f270
Compare
GeoffreyBooth
added
author ready
BethGriggs
reviewed
Mar 23, 2023
There was a problem hiding this comment.
The diff LGTM, but would appreciate a second review (perhaps @targos?) before landing
targos
approved these changes
Mar 27, 2023
BethGriggs
pushed a commit
that referenced
this pull request
Mar 27, 2023
PR-URL: #44197 Backport-PR-URL: #46535 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
Landed in fc47d58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #44197
Reviewed-By: Moshe Atlow [email protected]
Reviewed-By: Michaël Zasso [email protected]