Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19.7.0 proposal #46725

Merged
merged 114 commits into from
Feb 21, 2023
Merged

v19.7.0 proposal #46725

merged 114 commits into from
Feb 21, 2023

Commits on Feb 18, 2023

  1. test_runner: add initial code coverage support

    This commit adds code coverage functionality to the node:test
    module. When node:test is used in conjunction with the new
    --test-coverage CLI flag, a coverage report is created when
    the test runner finishes. The coverage summary is forwarded to
    any test runner reporters so that the display can be customized
    as desired. This new functionality is compatible with the
    existing NODE_V8_COVERAGE environment variable as well.
    
    There are still several limitations, which will be addressed in
    subsequent pull requests:
    
    - Coverage is only reported for a single process. It is possible
      to merge coverage reports together. Once this is done, the
      --test flag will be supported as well.
    - Source maps are not currently supported.
    - Excluding specific files or directories from the coverage
      report is not currently supported. Node core modules and
      node_modules/ are excluded though.
    
    PR-URL: #46017
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    cjihrig authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    6119289 View commit details
    Browse the repository at this point in the history
  2. doc,lib,src,test: rename --test-coverage

    Add experimental to the name as requested during review.
    
    PR-URL: #46017
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    cjihrig authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    9b23309 View commit details
    Browse the repository at this point in the history
  3. meta: move one or more collaborators to emeritus

    PR-URL: #46411
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    bb14a2b View commit details
    Browse the repository at this point in the history
  4. deps: update c-ares to 1.19.0

    Refs: https://c-ares.org/changelog.html#1_19_0
    PR-URL: #46415
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    targos authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    7e7e2d0 View commit details
    Browse the repository at this point in the history
  5. test: add trailing commas in test/internet

    PR-URL: #46407
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    a66e7ca View commit details
    Browse the repository at this point in the history
  6. test: add trailing commas in test/known_issues

    PR-URL: #46408
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    c7f29b2 View commit details
    Browse the repository at this point in the history
  7. doc: update threat model based on discussions

    Signed-off-by: Michael Dawson <[email protected]>
    
    PR-URL: #46373
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    mhdawson authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    33a98c4 View commit details
    Browse the repository at this point in the history
  8. async_hooks: remove experimental onPropagate option

    The `onPropagate` option for `AsyncLocalStorage` is problematic for a
    couple of reasons:
    
    1. It is not expected to be forwards compatible in any way with the
       upcoming TC-39 `AsyncContext` proposal.
    2. It introduces a non-trivial O(n) cost invoking a JavaScript callback
       for *every* AsyncResource that is created, including every Promise.
    
    While it is still experimental, I recommend removing it while we can
    revisit the fundamental use cases in light of the coming `AsyncContext`
    proposal.
    
    Refs: #46374
    PR-URL: #46386
    Reviewed-By: Stephen Belanger <[email protected]>
    Reviewed-By: Vladimir de Turckheim <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Gerhard Stöbich <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    jasnell authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    05ad792 View commit details
    Browse the repository at this point in the history
  9. benchmark: add trailing commas in benchmark/fs

    PR-URL: #46426
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: LiviaMedeiros <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    b364b9b View commit details
    Browse the repository at this point in the history
  10. test: make more crypto tests work with BoringSSL

    PR-URL: #46429
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    codebytere authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    d556ccd View commit details
    Browse the repository at this point in the history
  11. benchmark: add trailing commas in benchmark/async_hooks

    PR-URL: #46424
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    2c8c9f9 View commit details
    Browse the repository at this point in the history
  12. test_runner: top-level diagnostics not ommited when running with --test

    PR-URL: #46441
    Fixes: #45910
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    pulkit-30 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    b31aabb View commit details
    Browse the repository at this point in the history
  13. doc: add note about major release rotation

    Signed-off-by: RafaelGSS <[email protected]>
    PR-URL: #46436
    Fixes: nodejs/Release#765
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Ruy Adorno <[email protected]>
    RafaelGSS authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    905a675 View commit details
    Browse the repository at this point in the history
  14. stream: dont access Object.prototype.type during TransformStream init

    Fixes: #46355
    PR-URL: #46389
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    debadree25 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    b844a09 View commit details
    Browse the repository at this point in the history
  15. doc: fix -C flag usage

    ref
    40eb3b79f1
    
    PR-URL: #46388
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Harshitha K P <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    sxzz authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    31d3e3c View commit details
    Browse the repository at this point in the history
  16. stream: add suport for abort signal in finished() for webstreams

    Refs: #46205
    PR-URL: #46403
    Refs: #37354
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    debadree25 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    4cf4b41 View commit details
    Browse the repository at this point in the history
  17. stream: add pipeline() for webstreams

    Refs: #39316
    PR-URL: #46307
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    debadree25 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    c206853 View commit details
    Browse the repository at this point in the history
  18. test_runner: fix missing test diagnostics

    PR-URL: #46450
    Fixes: #45911
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    MoLow authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    c526f9f View commit details
    Browse the repository at this point in the history
  19. tools: update ESLint custom rules to not use the deprecated format

    Refs: https://eslint.org/docs/latest/extend/custom-rules-deprecated
    PR-URL: #46460
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    51c6c61 View commit details
    Browse the repository at this point in the history
  20. benchmark: add trailing commas in benchmark/util

    PR-URL: #46438
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    8b88d60 View commit details
    Browse the repository at this point in the history
  21. benchmark: add trailing commas in benchmark/net

    PR-URL: #46439
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    7760d40 View commit details
    Browse the repository at this point in the history
  22. benchmark: add trailing commas in benchmark/module

    PR-URL: #46461
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    897e3c2 View commit details
    Browse the repository at this point in the history
  23. doc: add deokjinkim to collaborators

    Fixes: #46329
    PR-URL: #46444
    Reviewed-By: Qingyu Deng <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Zeyu "Alex" Yang <[email protected]>
    Reviewed-By: Vladimir de Turckheim <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: theanarkh <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    deokjinkim authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    0c2c322 View commit details
    Browse the repository at this point in the history
  24. doc: fix wrong location of requestTimeout's default value

    Refs: https://nodejs.org/dist/latest-v19.x/docs/api/http.html#serverrequesttimeout
    PR-URL: #46423
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: theanarkh <[email protected]>
    Reviewed-By: Zeyu "Alex" Yang <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Harshitha K P <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    deokjinkim authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    aef57cd View commit details
    Browse the repository at this point in the history
  25. src: allow embedder control of code generation policy

    PR-URL: #46368
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    codebytere authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    e77d538 View commit details
    Browse the repository at this point in the history
  26. src: back snapshot I/O with a std::vector sink

    PR-URL: #46463
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    joyeecheung authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    6cf860d View commit details
    Browse the repository at this point in the history
  27. test: add trailing commas in test/js-native-api

    PR-URL: #46385
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    faba8d4 View commit details
    Browse the repository at this point in the history
  28. src: add GetCurrentCipherName/Version to crypto_common

    In preparation for use by the QUIC implementation.
    
    PR-URL: #45912
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    jasnell authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    a8a2d0e View commit details
    Browse the repository at this point in the history
  29. src: add KeyObjectHandle::HasInstance

    In preparation for use by the QUIC implementation.
    
    PR-URL: #45912
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    jasnell authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    efc59d0 View commit details
    Browse the repository at this point in the history
  30. src: add additional utilities to crypto::SecureContext

    In preparation for use by the QUIC implementation.
    
    PR-URL: #45912
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    jasnell authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    95065c3 View commit details
    Browse the repository at this point in the history
  31. src: add snapshot support for embedder API

    Add experimental support for loading snapshots in the embedder API
    by adding a public opaque wrapper for our `SnapshotData` struct and
    allowing embedders to pass it to the relevant setup functions.
    Where applicable, use these helpers to deduplicate existing code
    in Node.js’s startup path.
    
    This has shown a 40 % startup performance increase for a real-world
    application, even with the somewhat limited current support for
    built-in modules.
    
    The documentation includes a note about no guarantees for API or
    ABI stability for this feature while it is experimental.
    
    PR-URL: #45888
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    addaleax authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    6801d37 View commit details
    Browse the repository at this point in the history
  32. src: make build_snapshot a per-Isolate option, rather than a global one

    PR-URL: #45888
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    addaleax authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    658d2f4 View commit details
    Browse the repository at this point in the history
  33. src: allow snapshotting from the embedder API

    PR-URL: #45888
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    addaleax authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    683a1f8 View commit details
    Browse the repository at this point in the history
  34. async_hooks: add async local storage propagation benchmarks

    Add micro-benchmarks to verify the performance degradation related to
    the number of active `AsyncLocalStorage`s.
    
    With these benchmarks, trying to improve the async context propagation
    to be an O(1) operation, which is an operation more frequent compared
    to `asyncLocalStorage.run` and `asyncLocalStorage.getStore`.
    
    PR-URL: #46414
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Gerhard Stöbich <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    legendecas authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    731a7ae View commit details
    Browse the repository at this point in the history
  35. vm: properly support symbols on globals

    A regression has been introduced in node 18.2.0,
    it makes the following snippet fails while it used to work in the past:
    
    ```
    const assert = require('assert');
    const vm = require('vm');
    const global = vm.runInContext('this', vm.createContext());
    const totoSymbol = Symbol.for('toto');
    Object.defineProperty(global, totoSymbol, {
      enumerable: true,
      writable: true,
      value: 4,
      configurable: true,
    });
    assert(Object.getOwnPropertySymbols(global).includes(totoSymbol));
    ```
    
    Regression introduced by: #42963.
    So I basically attempted to start understanding what it changed to make
    it fix the initial issue while not breaking the symbol related one.
    
    Fixes: #45983
    PR-URL: #46458
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    dubzzz authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    17b3ee3 View commit details
    Browse the repository at this point in the history
  36. benchmark: add trailing commas in benchmark/buffers

    PR-URL: #46473
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    7f8b292 View commit details
    Browse the repository at this point in the history
  37. benchmark: add trailing commas in benchmark/misc

    PR-URL: #46474
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    6c69ad6 View commit details
    Browse the repository at this point in the history
  38. stream: allow transfer of readable byte streams

    Updates the `ReadableStream` constructor to mark byte streams as
    transferable. When transferred, byte streams become regular streams.
    
    Refs: #39062
    Refs: https://streams.spec.whatwg.org/#rs-transfer
    PR-URL: #45955
    Reviewed-By: Daeyeon Jeong <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    mrbbot authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    6bf7388 View commit details
    Browse the repository at this point in the history
  39. timers: cleanup no-longer relevant TODOs in timers/promises

    PR-URL: #46499
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    jasnell authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    6f24f06 View commit details
    Browse the repository at this point in the history
  40. benchmark: add trailing commas in benchmark/process

    PR-URL: #46481
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    9d9b3f8 View commit details
    Browse the repository at this point in the history
  41. url: remove unused setURLConstructor function

    PR-URL: #46485
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Zeyu "Alex" Yang <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    anonrig authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    d6fbebd View commit details
    Browse the repository at this point in the history
  42. url: remove unused URL::toObject

    PR-URL: #46486
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Zeyu "Alex" Yang <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    anonrig authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    9a604d6 View commit details
    Browse the repository at this point in the history
  43. url: remove unused URL::ToFilePath()

    PR-URL: #46487
    Reviewed-By: Zeyu "Alex" Yang <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    anonrig authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    129c9e7 View commit details
    Browse the repository at this point in the history
  44. doc: enrich test command with executable

    PR-URL: #44347
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    tony-go authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    a7beac0 View commit details
    Browse the repository at this point in the history
  45. doc: update test concurrency description / default values

    PR-URL: #46457
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Jacob Smith <[email protected]>
    richiemccoll authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    375bb22 View commit details
    Browse the repository at this point in the history
  46. src: replace icu with simdutf for char counts

    PR-URL: #46472
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    anonrig authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    00b81c7 View commit details
    Browse the repository at this point in the history
  47. src: use simdutf utf8 to utf16 instead of icu

    PR-URL: #46471
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    anonrig authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    f35f6d2 View commit details
    Browse the repository at this point in the history
  48. src: use string_view instead of std::string&

    PR-URL: #46471
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    anonrig authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    60c2a86 View commit details
    Browse the repository at this point in the history
  49. src: remove unused includes from main thread

    PR-URL: #46471
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    anonrig authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    f72f643 View commit details
    Browse the repository at this point in the history
  50. src: check return value of ftell()

    If ftell() returns -1L, abort instead of passing static_cast<size_t>(-1)
    to the vector allocator and fread().
    
    Refs: #46463
    PR-URL: #46495
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    tniessen authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    1a808a4 View commit details
    Browse the repository at this point in the history
  51. src: avoid leaking snapshot fp on error

    Call fclose() on the snapshot file regardless of whether reading the
    snapshot data succeeded.
    
    PR-URL: #46497
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    tniessen authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    3c5db8f View commit details
    Browse the repository at this point in the history
  52. meta: update AUTHORS

    PR-URL: #46504
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    nodejs-github-bot authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    17b82c8 View commit details
    Browse the repository at this point in the history
  53. src: make edge names in BaseObjects more descriptive in heap snapshots

    Previously these were named "wrapper" and "wrapped", which can be
    somewhat difficult to understand. This patch renames them to
    "javascript_to_native" and "native_to_javascript".
    
    PR-URL: #46492
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    joyeecheung authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    c3325bf View commit details
    Browse the repository at this point in the history
  54. test: fix tap parser fails if a test logs a number

    PR-URL: #46056
    Fixes: #46048
    Reviewed-By: Moshe Atlow <[email protected]>
    pulkit-30 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    89aa161 View commit details
    Browse the repository at this point in the history
  55. deps: add ada as a dependency

    PR-URL: #46410
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    anonrig authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    7d6c27e View commit details
    Browse the repository at this point in the history
  56. url: replace url-parser with ada

    PR-URL: #46410
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    anonrig authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    a51fe3c View commit details
    Browse the repository at this point in the history
  57. src: allow blobs in addition to FILE*s in embedder snapshot API

    This is a shared follow-up to 06bb6b4 and a466fea
    now that both have been merged.
    
    PR-URL: #46491
    Refs: #45888
    Refs: #46463
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    addaleax authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    c34bac2 View commit details
    Browse the repository at this point in the history
  58. tools: update lint-md-dependencies to [email protected] [email protected]

    PR-URL: #46503
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    nodejs-github-bot authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    148c5d9 View commit details
    Browse the repository at this point in the history
  59. test: enable api-invalid-label.any.js in encoding WPTs

    PR-URL: #46506
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    panva authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    641e177 View commit details
    Browse the repository at this point in the history
  60. lib: add aborted() utility function

    Fixes: #37220
    Refs: #36607
    PR-URL: #46494
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    debadree25 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    8590eb4 View commit details
    Browse the repository at this point in the history
  61. meta: move one or more collaborators to emeritus

    PR-URL: #46513
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    nodejs-github-bot authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    cb9b9ad View commit details
    Browse the repository at this point in the history
  62. http: use v8::Array::New() with a prebuilt vector

    Avoid using v8::Array::Set() which results in JS execution and is
    thus slow. Prebuild the vector in C++ land and build the
    JS array directly with that vector whereever possible.
    
    PR-URL: #46447
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Gerhard Stöbich <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    joyeecheung authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    d8c527f View commit details
    Browse the repository at this point in the history
  63. stream: refactor to use validateAbortSignal

    PR-URL: #46520
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    f91260b View commit details
    Browse the repository at this point in the history
  64. lib: tighten AbortSignal.prototype.throwIfAborted implementation

    PR-URL: #46521
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    35570e9 View commit details
    Browse the repository at this point in the history
  65. lib: predeclare Event.isTrusted prop descriptor

    It improves Event creation performance.
    
    PR-URL: #46527
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rafael Gonzaga <[email protected]>
    santigimeno authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    da9ebaf View commit details
    Browse the repository at this point in the history
  66. src: add fflush() to SnapshotData::ToFile()

    Refs: #46491 (comment)
    PR-URL: #46531
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    addaleax authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    31fb2e2 View commit details
    Browse the repository at this point in the history
  67. benchmark: add trailing commas in benchmark/http2

    PR-URL: #46552
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Akhil Marsonya <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    7524871 View commit details
    Browse the repository at this point in the history
  68. benchmark: add trailing commas in benchmark/url

    PR-URL: #46551
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Akhil Marsonya <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    638d9b8 View commit details
    Browse the repository at this point in the history
  69. benchmark: add trailing commas in benchmark/crypto

    PR-URL: #46553
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Akhil Marsonya <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    ff95eb7 View commit details
    Browse the repository at this point in the history
  70. doc: fix test runner examples

    PR-URL: #46565
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    richiemccoll authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    c771d66 View commit details
    Browse the repository at this point in the history
  71. deps: copy postject-api.h and LICENSE to the deps folder

    Since `postject-api.h` gets compiled into Node.js, it makes more sense
    to put it in the `deps` directory instead of `test/fixtures`.
    
    Refs: #45038 (comment)
    Signed-off-by: Darshan Sen <[email protected]>
    PR-URL: #46582
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    RaisinTen authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    c0983cf View commit details
    Browse the repository at this point in the history
  72. benchmark: add trailing commas in benchmark/http

    PR-URL: #46609
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    aduh95 authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    4b89ec4 View commit details
    Browse the repository at this point in the history
  73. tools: update doc to [email protected] [email protected]

    PR-URL: #46622
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    nodejs-github-bot authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    8ee9e48 View commit details
    Browse the repository at this point in the history
  74. tools: update lint-md-dependencies to [email protected] [email protected]

    PR-URL: #46623
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    nodejs-github-bot authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    f87216b View commit details
    Browse the repository at this point in the history
  75. tools: update eslint to 8.34.0

    PR-URL: #46625
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    nodejs-github-bot authored and MylesBorins committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    803f00a View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. test: add trailing commas in test/pummel

    PR-URL: #46610
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Juan José Arboleda <[email protected]>
    aduh95 authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    217f2f6 View commit details
    Browse the repository at this point in the history
  2. http: add note about clientError event

    PR-URL: #46584
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    ShogunPanda authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    7f2cdd3 View commit details
    Browse the repository at this point in the history
  3. doc: remove unused functions from example of streamConsumers.text

    json, blob, and buffer are imported, but these functions are not
    used for example of `streamConsumers.text`.
    
    PR-URL: #46581
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    deokjinkim authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    ffdd64d View commit details
    Browse the repository at this point in the history
  4. meta: update AUTHORS

    PR-URL: #46624
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Qingyu Deng <[email protected]>
    nodejs-github-bot authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    5d1a729 View commit details
    Browse the repository at this point in the history
  5. benchmark: add trailing commas in benchmark/path

    PR-URL: #46628
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    aduh95 authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    6b21170 View commit details
    Browse the repository at this point in the history
  6. lib: enforce use of trailing commas for functions

    PR-URL: #46629
    Reviewed-By: Jacob Smith <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    aduh95 authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    aae0020 View commit details
    Browse the repository at this point in the history
  7. doc: add response.strictContentLength to documentation

    PR-URL: #46627
    Refs: #44378
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Harshitha K P <[email protected]>
    marco-ippolito authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    a0a6ee0 View commit details
    Browse the repository at this point in the history
  8. lib: enforce use of trailing commas in more files

    Some part of the codebase already use trailing commas, this commit is
    adding a lint rule to ensure it stays this way.
    This commit also adds the rule for a few files that were missing only
    one or two trailing commas.
    
    PR-URL: #46655
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    aduh95 authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    8b46c76 View commit details
    Browse the repository at this point in the history
  9. lib: delete module findPath unused params

    PR-URL: #45371
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Kohei Ueno <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    sinkhaha authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    a740908 View commit details
    Browse the repository at this point in the history
  10. stream: add abort signal for ReadableStream and WritableStream

    Refs: #39316
    PR-URL: #46273
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    debadree25 authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    633d3f2 View commit details
    Browse the repository at this point in the history
  11. test_runner: allow nesting test within describe

    PR-URL: #46544
    Fixes: #46478
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    MoLow authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    5b74811 View commit details
    Browse the repository at this point in the history
  12. test,crypto: update WebCryptoAPI WPT

    PR-URL: #46575
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    panva authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    0f75633 View commit details
    Browse the repository at this point in the history
  13. test: add WPTRunner support for variants and generating WPT reports

    PR-URL: #46498
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    panva authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    e60d3f2 View commit details
    Browse the repository at this point in the history
  14. tools: add a daily wpt.fyi synchronized report upload

    PR-URL: #46498
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    panva authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    f62b58a View commit details
    Browse the repository at this point in the history
  15. tools: fix update-ada script

    PR-URL: #46550
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gerhard Stöbich <[email protected]>
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    anonrig authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    87df34a View commit details
    Browse the repository at this point in the history
  16. deps: update ada to v1.0.1

    Co-authored-by: Daniel Lemire <[email protected]>
    PR-URL: #46550
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Gerhard Stöbich <[email protected]>
    Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
    2 people authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    20cb13b View commit details
    Browse the repository at this point in the history
  17. src: remove icu usage from node_string.cc

    PR-URL: #46548
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    anonrig authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    bdba600 View commit details
    Browse the repository at this point in the history
  18. crypto: don't assume FIPS is disabled by default

    For binaries that use --shared-openssl FIPs may be enabled
    by default by the system. Allow --force-fips and --enable-fips
    to be specified in these cases.
    
    Signed-off-by: Michael Dawson <[email protected]>
    
    PR-URL: #46532
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    mhdawson authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    b4deb2f View commit details
    Browse the repository at this point in the history
  19. tools: fix bug in prefer-primordials lint rule

    PR-URL: #46659
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    aduh95 authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    1cd22e7 View commit details
    Browse the repository at this point in the history
  20. src: allow optional Isolate termination in node::Stop()

    PR-URL: #46583
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    codebytere authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    f390841 View commit details
    Browse the repository at this point in the history
  21. test: cover publicExponent validation in OpenSSL

    Add a test case for public exponents that are invalid according to some
    internal OpenSSL validation logic, but which are accepted by node's own
    validation logic.
    
    PR-URL: #46632
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Anto Aravinth <[email protected]>
    tniessen authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    c4ca98e View commit details
    Browse the repository at this point in the history
  22. doc: move bcoe to emeriti

    So long and thanks for all the bike sheds 🚲🏚️
    
    Fixes #46682
    
    PR-URL: #46703
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    bcoe authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    6a8b04d View commit details
    Browse the repository at this point in the history
  23. test: fix assertions in test-snapshot-dns-lookup*

    Due to the unfortunate nature of JavaScript, the extraneous arguments
    are silently ignored. In this case, the assertion trivially passes
    regardless of the given regular expressions.
    
    Refs: #44633
    PR-URL: #46618
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Harshitha K P <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    tniessen authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    2239e24 View commit details
    Browse the repository at this point in the history
  24. src: add initial support for single executable applications

    Compile a JavaScript file into a single executable application:
    
    ```console
    $ echo 'console.log(`Hello, ${process.argv[2]}!`);' > hello.js
    
    $ cp $(command -v node) hello
    
    $ npx postject hello NODE_JS_CODE hello.js \
        --sentinel-fuse NODE_JS_FUSE_fce680ab2cc467b6e072b8b5df1996b2
    
    $ npx postject hello NODE_JS_CODE hello.js \
        --sentinel-fuse NODE_JS_FUSE_fce680ab2cc467b6e072b8b5df1996b2 \
        --macho-segment-name NODE_JS
    
    $ ./hello world
    Hello, world!
    ```
    
    Signed-off-by: Darshan Sen <[email protected]>
    PR-URL: #45038
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    RaisinTen authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    164bfe8 View commit details
    Browse the repository at this point in the history
  25. lib: do not crash using workers with disabled shared array buffers

    This allows the repl to function normally while using the
    `--no-harmony-sharedarraybuffer` V8 flag.
    It also fixes using workers while using the
    `--no-harmony-atomics` V8 flag.
    
    Fixes: #39717
    
    Signed-off-by: Ruben Bridgewater <[email protected]>
    
    Co-authored-by: Shelley Vohr <[email protected]>
    PR-URL: #41023
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    2 people authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    4aebee6 View commit details
    Browse the repository at this point in the history
  26. doc: add debadree25 to collaborators

    Fixes: #46526
    PR-URL: #46716
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    Reviewed-By: Kohei Ueno <[email protected]>
    debadree25 authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    a79a8bf View commit details
    Browse the repository at this point in the history
  27. deps: update undici to 5.20.0

    PR-URL: #46711
    Reviewed-By: Filip Skokan <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    nodejs-github-bot authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    2ed3875 View commit details
    Browse the repository at this point in the history
  28. deps: update corepack to 0.16.0

    PR-URL: #46710
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
    nodejs-github-bot authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    6c99703 View commit details
    Browse the repository at this point in the history
  29. esm: misc test refactors

    - add test specific to the event loop
    - move parallel tests into es-module folder
    - refactor fixture to add braces for if blocks
    - use 'os' instead of 'fs' as placeholder
    - spelling
    
    PR-URL: #46631
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    GeoffreyBooth authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    f192b83 View commit details
    Browse the repository at this point in the history
  30. test: fix test-net-autoselectfamily for kernel without IPv6 support

    PR-URL: #45856
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Paolo Insogna <[email protected]>
    LiviaMedeiros authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    6ad01fd View commit details
    Browse the repository at this point in the history
  31. stream: add trailing commas in stream source files

    PR-URL: #46686
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    aduh95 authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    6b64a94 View commit details
    Browse the repository at this point in the history
  32. stream: add trailing commas in webstream source files

    PR-URL: #46685
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    aduh95 authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    7756438 View commit details
    Browse the repository at this point in the history
  33. lib: add trailing commas in internal/process

    PR-URL: #46687
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    aduh95 authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    fa600fe View commit details
    Browse the repository at this point in the history
  34. test_runner: parse non-ascii character correctly

    PR-URL: #45736
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    mertcanaltin authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    ddf5002 View commit details
    Browse the repository at this point in the history
  35. build: do not disable inspector when intl is disabled

    PR-URL: #37954
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Trott authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    c781a48 View commit details
    Browse the repository at this point in the history
  36. build: add GitHub Action for coverage with --without-intl

    There are parts of the code base that require a build without intl to be
    covered. So add a coverage job to build --without-intl.
    
    PR-URL: #37954
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Trott authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    e15ddba View commit details
    Browse the repository at this point in the history
  37. process: print versions by sort

    Co-authored-by: James M Snell <[email protected]>
    Co-authored-by: Anna Henningsen <[email protected]>
    PR-URL: #46428
    Fixes: #45630
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    3 people authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    152a3c7 View commit details
    Browse the repository at this point in the history
  38. deps: upgrade npm to 9.5.0

    PR-URL: #46673
    Reviewed-By: Luke Karrys <[email protected]>
    Reviewed-By: Moshe Atlow <[email protected]>
    Reviewed-By: Ruy Adorno <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Yagiz Nizipli <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    npm-cli-bot authored and MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    60a6126 View commit details
    Browse the repository at this point in the history
  39. 2023-02-21, Version 19.7.0 (Current)

    Notable changes:
    
    deps:
      * upgrade npm to 9.5.0 (npm team) #46673
      * add ada as a dependency (Yagiz Nizipli) #46410
    doc:
      * add debadree25 to collaborators (Debadree Chatterjee) #46716
      * add deokjinkim to collaborators (Deokjin Kim) #46444
    doc,lib,src,test:
      * rename --test-coverage (Colin Ihrig) #46017
    lib:
      * (SEMVER-MINOR) add aborted() utility function (Debadree Chatterjee) #46494
    src:
      * (SEMVER-MINOR) add initial support for single executable applications (Darshan Sen) #45038
      * (SEMVER-MINOR) allow optional Isolate termination in node::Stop() (Shelley Vohr) #46583
      * (SEMVER-MINOR) allow blobs in addition to `FILE*`s in embedder snapshot API (Anna Henningsen) #46491
      * (SEMVER-MINOR) allow snapshotting from the embedder API (Anna Henningsen) #45888
      * (SEMVER-MINOR) make build_snapshot a per-Isolate option, rather than a global one (Anna Henningsen) #45888
      * (SEMVER-MINOR) add snapshot support for embedder API (Anna Henningsen) #45888
      * (SEMVER-MINOR) allow embedder control of code generation policy (Shelley Vohr) #46368
    stream:
      * (SEMVER-MINOR) add abort signal for ReadableStream and WritableStream (Debadree Chatterjee) #46273
    test_runner:
      * add initial code coverage support (Colin Ihrig) #46017
    url:
      * replace url-parser with ada (Yagiz Nizipli) #46410
    
    PR-URL: #46725
    MylesBorins committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    00a428e View commit details
    Browse the repository at this point in the history