Add python-gflags module for closure linter #464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 16, 2015 14:49
closure_linter needs the gflags module.
closure_linter needs the gflags module.
bnoordhuis
pushed a commit
that referenced
this pull request
Jan 16, 2015
closure_linter needs the gflags module. PR-URL: #464 Reviewed-By: Ben Noordhuis <[email protected]>
bnoordhuis
pushed a commit
that referenced
this pull request
Jan 16, 2015
PR-URL: #464 Reviewed-By: Ben Noordhuis <[email protected]>
bnoordhuis
pushed a commit
that referenced
this pull request
Jan 16, 2015
closure_linter needs the gflags module. PR-URL: #464 Reviewed-By: Ben Noordhuis <[email protected]>
|
Thanks Shigeki, landed in commits 6242229...3fde649. I dropped some files from the first commit (gflags tests, egg-info directory, a setuptools zip.) Thanks again! |
|
No problems for dropping them. Thanks for your quick review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closure_linter needs the gflags module.
I checked this on my Ubuntu and Windows8.1.
Fix #449