Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update closure_linter to 2.3.17 #449

Closed
wants to merge 2 commits into from
Closed

tools: update closure_linter to 2.3.17 #449

wants to merge 2 commits into from

Conversation

yosuke-furukawa
Copy link
Member

io.js has new ES6 syntaxes like template literals.
However current closure linter can't check these ES6 syntax.

So I would like to update closure_linter to 2.3.17 (latest).
And I have already fixed some js files using make jslintfix.

@bnoordhuis
Copy link
Member

Thanks Yosuke, landed in commits 4d8a9b1 and 85aa36d.

@bnoordhuis bnoordhuis closed this Jan 15, 2015
bnoordhuis pushed a commit that referenced this pull request Jan 15, 2015
bnoordhuis pushed a commit that referenced this pull request Jan 15, 2015
PR-URL: #449
Reviewed-By: Ben Noordhuis <[email protected]>
@bnoordhuis
Copy link
Member

Sorry, make that 946eabd and fd30eb2. Had to amend authorship.

@shigeki
Copy link
Contributor

shigeki commented Jan 16, 2015

Updating the closure linter was reverted before in 2d0011f because it needs gflags module. We need to take care of it.

~/github/io.js$ make jslint
PYTHONPATH=tools/closure_linter/ /usr/bin/python tools/closure_linter/closure_linter/gjslint.py --unix_mode --strict --nojsdoc -r lib/ -r src/ --exclude_files lib/punycode.js
Traceback (most recent call last):
  File "tools/closure_linter/closure_linter/gjslint.py", line 46, in <module>
    import gflags as flags
ImportError: No module named gflags
make: *** [jslint] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants