Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19.5.0 proposal #46286

Merged
merged 107 commits into from
Jan 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
107 commits
Select commit Hold shift + click to select a range
679aae2
deps: upgrade npm to 9.3.0
npm-cli-bot Jan 17, 2023
6cd7057
deps: upgrade npm to 9.3.1
npm-cli-bot Jan 18, 2023
ed69a3a
tools: add `prefer-proto` rule
ljharb Jan 10, 2023
069a30b
http: join authorization headers
marco-ippolito Jan 3, 2023
0985ef8
tools: add `ArrayPrototypeConcat` to the list of primordials to avoid
aduh95 Dec 17, 2022
a266dac
deps: update corepack to 0.15.3
nodejs-github-bot Jan 2, 2023
38dd506
dgram: sync the old handle state to new handle
theanarkh Jan 3, 2023
a936eae
src: speed up process.getActiveResourcesInfo()
RaisinTen Jan 3, 2023
961710b
crypto: add KeyObject Symbol.toStringTag
panva Jan 3, 2023
e90a3a6
tools: fix lint rule recommendation
cjihrig Jan 1, 2023
8684dae
lib: fix incorrect use of console intrinsic
cjihrig Jan 1, 2023
3dcdab3
events: check signal before listener
deokjinkim Jan 4, 2023
bd98e5b
node-api: disambiguate napi_add_finalizer
legendecas Nov 10, 2022
8a8b186
test,esm: validate more edge cases for dynamic imports
aduh95 Jan 4, 2023
1996e61
doc: describe argument of `Symbol.for`
deokjinkim Jan 4, 2023
1b557bb
meta: update comment in `CODEOWNERS` to better reflect current policy
aduh95 Jan 6, 2023
2e8750a
tools: make update-eslint.sh work with npm@9
lpinca Jan 4, 2023
750fcf8
tools: move update-eslint.sh to dep_updaters/
lpinca Jan 4, 2023
e1fd2f2
doc: include updating release optional step
RafaelGSS Jan 6, 2023
fafae59
doc: mention how to run ncu-ci citgm
RafaelGSS Jan 6, 2023
a42fc51
doc: add personal pronouns option
panva Jan 6, 2023
ca8ff08
src: keep PipeWrap::Open function consistent with TCPWrap
theanarkh Jan 6, 2023
82023f2
doc: update output of example in inspector
deokjinkim Jan 6, 2023
76408bc
doc: fix `event.cancelBubble` documentation
deokjinkim Jan 7, 2023
7718e82
doc: abort controller emits error in child process
debadree25 Jan 7, 2023
b002330
doc,crypto: fix WebCryptoAPI import keyData and export return
panva Jan 7, 2023
f4559a1
src: fix typo in node_snapshotable.cc
kwarabei Jan 7, 2023
5304c89
events: change status of `event.srcElement` to legacy
deokjinkim Jan 7, 2023
1146f02
crypto: return correct bit length in KeyObject's asymmetricKeyDetails
panva Jan 7, 2023
54896ab
module: fix unintended mutation
aduh95 Jan 7, 2023
e222a2f
doc: fix spelling in SECURITY.md
vchan-in Jan 7, 2023
def3694
assert: remove `assert.snapshot`
MoLow Jan 7, 2023
2e22b29
doc: fix ERR_TLS_RENEGOTIATION_DISABLED text
tniessen Jan 7, 2023
5261560
meta: update AUTHORS
nodejs-github-bot Jan 8, 2023
2e826ad
doc: fix (EC)DHE remark in TLS docs
tniessen Jan 8, 2023
69aafc3
deps: update simdutf to 2.1.0
nodejs-github-bot Jan 8, 2023
0f60bc9
test: add test to once() in event lib
jdiaz-dev Jan 9, 2023
e8eaa49
src: use constant strings for memory info names
legendecas Jan 9, 2023
ac90e41
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Jan 10, 2023
28af831
src: use simdutf for converting externalized builtins to UTF-16
addaleax Jan 10, 2023
0c4df83
deps: add simdutf version to metadata
roth-mike Jan 10, 2023
686fe58
doc: remove outdated sections from `maintaining-v8`
aduh95 Jan 10, 2023
c68a043
tools: update eslint to 8.31.0
nodejs-github-bot Jan 10, 2023
f309e2a
test: update Web Events WPT
deokjinkim Jan 10, 2023
f050889
perf_hooks: fix checking range of `options.figures` in createHistogram
deokjinkim Jan 10, 2023
c77b0da
test: fix flaky test-runner-exit-code.js
cjihrig Jan 10, 2023
eef7489
doc: duplex and readable from uncaught execption warning
marco-ippolito Jan 11, 2023
ad7846f
events: change status of `event.cancelBubble` to legacy
deokjinkim Jan 11, 2023
4955624
deps: add /deps/**/.github/ to .gitignore
lpinca Jan 11, 2023
538c53f
doc: add PerformanceObserver.supportedEntryTypes to doc
theanarkh Jan 11, 2023
6e2f722
test: use `os.availableParallelism()`
deokjinkim Dec 29, 2022
e1c56ec
benchmark,tools: use os.availableParallelism()
deokjinkim Jan 2, 2023
fa3e0c8
esm: mark `importAssertions` as required
aduh95 Jan 12, 2023
2eb87f2
lib: reuse invalid state errors on webstreams
RafaelGSS Jan 13, 2023
7dc9a53
src: remove unnecessary semicolons
codebytere Jan 13, 2023
4c88721
doc: make options of readableStream.pipeTo as optional
deokjinkim Jan 13, 2023
1b45713
doc: https update default request timeout
marco-ippolito Jan 13, 2023
c150b31
tools: update create-or-update-pull-request-action
targos Jan 13, 2023
e85f766
src: remove return after abort
codebytere Jan 13, 2023
6e7f9fb
http: refactor to use min of validateNumber for maxTotalSockets
deokjinkim Jan 13, 2023
6c8a81d
vm: refactor to use validate function
deokjinkim Jan 14, 2023
f18ab94
doc: use "file system" instead of "filesystem"
Trott Jan 14, 2023
1aa4534
tools: add automation for updating postject dependency
RaisinTen Jan 14, 2023
1cfa2e6
lib: refactor to use validate function
deokjinkim Jan 14, 2023
d3d62ed
src: distinguish env stopping flags
legendecas Jan 14, 2023
dc0cdaa
crypto: ensure auth tag set for chacha20-poly1305
bnoordhuis Jan 14, 2023
6e355ef
doc: update http.setMaxIdleHTTPParsers arguments
debadree25 Jan 14, 2023
4ff2822
deps: bump googletest to 2023.01.13
gengjiawen Jan 15, 2023
f4465e6
tools: fix macro name in update-undici
almeidx Jan 15, 2023
a4b0c91
tools: update lint-md-dependencies
nodejs-github-bot Jan 15, 2023
d044ed1
meta: update AUTHORS
nodejs-github-bot Jan 15, 2023
1015a60
doc: add Node-API media link
KevinEady Jan 15, 2023
4d73ea7
lib: use kEmptyObject and update JSDoc in webstreams
deokjinkim Jan 15, 2023
9d55a1f
src: hide kMaxDigestMultiplier outside HKDF impl
tniessen Jan 16, 2023
5cf5956
src,lib: the handle keeps loop alive in cluster rr mode
theanarkh Jan 16, 2023
2d32835
doc: update to match changed `--dns-result-order` default
tikotzky Jan 16, 2023
370f621
build: add extra semi check
gengjiawen Jan 13, 2023
3f9fb37
deps: cherrypick simdutf patch
gengjiawen Jan 16, 2023
ae5141c
http: writeHead if statusmessage is undefined dont override headers
marco-ippolito Jan 17, 2023
36ae3cc
src: replace unreachable code with static_assert
tniessen Jan 17, 2023
907d67d
http: refactor to use `validateHeaderName`
deokjinkim Jan 17, 2023
90924ce
doc: add text around collaborative expectations
mhdawson Jan 6, 2023
78be87b
crypto: add cipher update/final methods encoding validation
vitpavlenko Jan 17, 2023
5c35029
doc: add note to tls docs about secureContext availability
tgerk Jan 18, 2023
4f491d3
test: add fix so that test exits if port 42 is unprivileged
7suyash7 Jan 18, 2023
e5f53b5
stream: implement finished() for ReadableStream and WritableStream
debadree25 Jan 18, 2023
8b22310
crypto: add CryptoKey Symbol.toStringTag
panva Jan 18, 2023
58b836f
doc: update events API example to have runnable code
deokjinkim Jan 18, 2023
bbf9da8
test: improve test coverage for WHATWG `TextDecoder`
juanarbol Jan 18, 2023
e2c47cd
src: make BuiltinLoader threadsafe and non-global
addaleax Jan 18, 2023
26cde8e
deps: update simdutf to 3.1.0
nodejs-github-bot Jan 18, 2023
e482d5e
src: fix endianness of simdutf
anonrig Jan 18, 2023
4ac5c71
test: refactor to avoid mutation of global by a loader
targos Jan 19, 2023
5bdfaae
events: change status of `event.returnvalue` to legacy
deokjinkim Jan 19, 2023
f85a8e4
events: add `initEvent` to Event
deokjinkim Jan 19, 2023
9cfdac6
deps: V8: cherry-pick e39af94dd18e
luyahan Jan 19, 2023
4c1c20f
trace_events: refactor to use `validateStringArray`
deokjinkim Jan 19, 2023
1869559
stream: fix pipeline calling end on destination more than once
debadree25 Jan 19, 2023
e36af49
doc: fix mismatched arguments of `NodeEventTarget`
deokjinkim Jan 19, 2023
c09b203
test: update postject to 1.0.0-alpha.4
nodejs-github-bot Jan 14, 2023
255f177
test: enable more case of bad buffer in `fs.write`
deokjinkim Jan 19, 2023
4d37439
test_runner: update comment to comply with eslint no-fallthrough rule
aduh95 Jan 19, 2023
653b108
tools: update eslint to 8.32.0
nodejs-github-bot Jan 18, 2023
476c6f8
crypto: avoid hang when no algorithm available
richardlau Jan 19, 2023
2f23f17
test: reduce `fs-write-optional-params` flakiness
LiviaMedeiros Jan 17, 2023
68cde4c
lib: add webstreams to Duplex.from()
debadree25 Jan 19, 2023
07c9241
2023-01-24, Version 19.5.0 (Current)
RafaelGSS Jan 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ module.exports = {
// Custom rules from eslint-plugin-node-core
'node-core/no-unescaped-regexp-dot': 'error',
'node-core/no-duplicate-requires': 'error',
'node-core/prefer-proto': 'error',
},
globals: {
ByteLengthQueuingStrategy: 'readable',
Expand Down
11 changes: 7 additions & 4 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
# Node.js Project Codeowners

# 1. Codeowners must always be teams, never individuals
# 2. Each codeowner team should contain at least one TSC member
# 3. PRs touching any code with a codeowner must be signed off by at least one
# person on the code owner team.
# This file does not define any requirements for landing PRs.
# Its purpose is to allow automation of courtesy pings to the
# relevant team(s) when any of the paths listed here are modified.
# Criteria for landing PRs are defined in
# https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#code-reviews.
#
# Codeowners must always be teams, never individuals.

# tsc

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/authors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
fetch-depth: '0' # This is required to actually get all the authors
persist-credentials: false
- run: tools/update-authors.mjs # Run the AUTHORS tool
- uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
- uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
# Creates a PR or update the Action's existing PR, or
# no-op if the base branch is already up-to-date.
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/find-inactive-collaborators.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
run: tools/find-inactive-collaborators.mjs

- name: Open pull request
uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
# Creates a PR or update the Action's existing PR, or
# no-op if the base branch is already up-to-date.
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/find-inactive-tsc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
run: tools/find-inactive-tsc.mjs >> $GITHUB_ENV

- name: Open pull request
uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
# Creates a PR or update the Action's existing PR, or
# no-op if the base branch is already up-to-date.
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/license-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
with:
persist-credentials: false
- run: ./tools/license-builder.sh # Run the license builder tool
- uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
- uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
# Creates a PR or update the Action's existing PR, or
# no-op if the base branch is already up-to-date.
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/timezone-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
run: echo "${{ env.new_version }}" > test/fixtures/tz-version.txt

- name: Open Pull Request
uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee # Create a PR or update the Action's existing PR
uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5 # Create a PR or update the Action's existing PR
env:
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
with:
Expand Down
17 changes: 13 additions & 4 deletions .github/workflows/tools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,11 @@ jobs:
subsystem: tools
label: tools
run: |
cd tools
NEW_VERSION=$(npm view eslint dist-tags.latest)
CURRENT_VERSION=$(node -p "require('./node_modules/eslint/package.json').version")
CURRENT_VERSION=$(node -p "require('./tools/node_modules/eslint/package.json').version")
if [ "$NEW_VERSION" != "$CURRENT_VERSION" ]; then
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
./update-eslint.sh
./tools/dep_updaters/update-eslint.sh
fi
- id: corepack
subsystem: deps
Expand Down Expand Up @@ -78,6 +77,16 @@ jobs:
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
./tools/update-undici.sh
fi
- id: postject
subsystem: deps
label: dependencies
run: |
NEW_VERSION=$(npm view postject dist-tags.latest)
CURRENT_VERSION=$(node -p "require('./test/fixtures/postject-copy/node_modules/postject/package.json').version")
if [ "$NEW_VERSION" != "$CURRENT_VERSION" ]; then
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
./tools/dep_updaters/update-postject.sh
fi
- id: base64
subsystem: deps
label: dependencies
Expand Down Expand Up @@ -142,7 +151,7 @@ jobs:
- run: ${{ matrix.run }}
env:
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
- uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
- uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
# Creates a PR or update the Action's existing PR, or
# no-op if the base branch is already up-to-date.
env:
Expand Down
5 changes: 3 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,11 @@ tools/*/*.i.tmp
/deps/npm/node_modules/.bin/
# Respect V8's .gitignore
!deps/v8/**
# Ignore the libuv book and GitHub templates
/deps/uv/.github/
# Ignore the libuv book
/deps/uv/docs/code/
/deps/uv/docs/src/guide/
# Ignore .github directories
/deps/**/.github/
# Ignore dependencies fetched by tools/v8/fetch_deps.py
/deps/.cipd

Expand Down
1 change: 1 addition & 0 deletions .mailmap
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ David Mark Clements <[email protected]> <[email protected]>
David Siegel <[email protected]> <[email protected]>
DC <[email protected]>
Deepjyoti Mondal <[email protected]>
Deokjin Kim <[email protected]> <[email protected]>
dnlup <[email protected]> <[email protected]>
Domenic Denicola <[email protected]>
Domenic Denicola <[email protected]> <[email protected]>
Expand Down
4 changes: 4 additions & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -3591,5 +3591,9 @@ A. Wilcox <[email protected]>
Daniel Lemire <[email protected]>
Eric Mutta <[email protected]>
Vadim <[email protected]>
Aaron Friel <[email protected]>
Vaishno Chaitanya <[email protected]>
Jonathan Diaz <[email protected]>
Mike Roth <[email protected]>

# Generated by tools/update-authors.mjs
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V19.md#19.4.0">19.4.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V19.md#19.5.0">19.5.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V19.md#19.4.0">19.4.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V19.md#19.3.0">19.3.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V19.md#19.2.0">19.2.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V19.md#19.1.0">19.1.0</a><br/>
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -1550,7 +1550,7 @@ CONFLICT_RE=^>>>>>>> [[:xdigit:]]+|^<<<<<<< [[:alpha:]]+

# Related CI job: node-test-linter
lint-ci: lint-js-ci lint-cpp lint-py lint-md lint-addon-docs lint-yaml-build lint-yaml
@if ! ( grep -IEqrs "$(CONFLICT_RE)" --exclude="error-message.js" benchmark deps doc lib src test tools ) \
@if ! ( grep -IEqrs "$(CONFLICT_RE)" --exclude="error-message.js" --exclude="merge-conflict.json" benchmark deps doc lib src test tools ) \
&& ! ( $(FIND) . -maxdepth 1 -type f | xargs grep -IEqs "$(CONFLICT_RE)" ); then \
exit 0 ; \
else \
Expand Down
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ For information on using Node.js, see the [Node.js website][].
The Node.js project uses an [open governance model](./GOVERNANCE.md). The
[OpenJS Foundation][] provides support for the project.

Contributors are expected to act in a collaborative manner to move
the project forward. We encourage the constructive exchange of contrary
opinions and compromise. The [TSC](./GOVERNANCE.md#technical-steering-committee)
reserves the right to limit or block contributors who repeatedly act in ways
that discourage, exhaust, or otherwise negatively affect other participants.

**This project has a [Code of Conduct][].**

## Table of contents
Expand Down Expand Up @@ -399,7 +405,7 @@ For information about the governance of the Node.js project, see
* [oyyd](https://github.com/oyyd) -
**Ouyang Yadong** <<[email protected]>> (he/him)
* [panva](https://github.com/panva) -
**Filip Skokan** <<[email protected]>>
**Filip Skokan** <<[email protected]>> (he/him)
* [puzpuzpuz](https://github.com/puzpuzpuz) -
**Andrey Pechkurov** <<[email protected]>> (he/him)
* [Qard](https://github.com/Qard) -
Expand Down
4 changes: 2 additions & 2 deletions SECURITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ We often choose to work to improve our APIs based on those reports and issue
fixes either in regular or security releases depending on how much of a risk to
the community they pose.

### Examples of vulneratibities
### Examples of vulnerabilities

#### Improper Certificate Validation (CWE-295)

Expand Down Expand Up @@ -156,7 +156,7 @@ the community they pose.
and modification of that configuration can affect the confidentiality of
data protected using the Node.js APIs this is considered a vulnerability.

### Examples of non-vulneratibities
### Examples of non-vulnerabilities

#### Malicious Third-Party Modules (CWE-1357)

Expand Down
2 changes: 1 addition & 1 deletion benchmark/_http-benchmarkers.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class WrkBenchmarker {
const args = [
'-d', duration,
'-c', options.connections,
'-t', Math.min(options.connections, require('os').cpus().length || 8),
'-t', Math.min(options.connections, require('os').availableParallelism() || 8),
`${scheme}://127.0.0.1:${options.port}${options.path}`,
];
for (const field in options.headers) {
Expand Down
4 changes: 2 additions & 2 deletions benchmark/es/map-bench.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ function runObject(n) {
}

function runNullProtoObject(n) {
const m = Object.create(null);
const m = { __proto__: null };
bench.start();
for (let i = 0; i < n; i++) {
m[`i${i}`] = i;
Expand All @@ -51,7 +51,7 @@ function runNullProtoLiteralObject(n) {
}

function StorageObject() {}
StorageObject.prototype = Object.create(null);
StorageObject.prototype = { __proto__: null };

function runStorageObject(n) {
const m = new StorageObject();
Expand Down
45 changes: 45 additions & 0 deletions benchmark/process/getActiveResourcesInfo.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
'use strict';

const { createBenchmark } = require('../common.js');

const { connect, createServer } = require('net');
const { open } = require('fs');

const bench = createBenchmark(main, {
handlesCount: [1e4],
requestsCount: [1e4],
timeoutsCount: [1e4],
immediatesCount: [1e4],
n: [1e5],
});

function main({ handlesCount, requestsCount, timeoutsCount, immediatesCount, n }) {
const server = createServer().listen();
const clients = [];
for (let i = 0; i < handlesCount; i++) {
clients.push(connect({ port: server.address().port }));
}

for (let i = 0; i < requestsCount; i++) {
open(__filename, 'r', () => {});
}

for (let i = 0; i < timeoutsCount; ++i) {
setTimeout(() => {}, 1);
}

for (let i = 0; i < immediatesCount; ++i) {
setImmediate(() => {});
}

bench.start();
for (let i = 0; i < n; ++i) {
process.getActiveResourcesInfo();
}
bench.end(n);

for (const client of clients) {
client.destroy();
}
server.close();
}
6 changes: 1 addition & 5 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -2024,11 +2024,7 @@ def make_bin_override():
for builtin in shareable_builtins:
builtin_id = 'node_shared_builtin_' + builtin.replace('/', '_') + '_path'
if getattr(options, builtin_id):
if options.with_intl == 'none':
option_name = '--shared-builtin-' + builtin + '-path'
error(option_name + ' is incompatible with --with-intl=none' )
else:
output['defines'] += [builtin_id.upper() + '=' + getattr(options, builtin_id)]
output['defines'] += [builtin_id.upper() + '=' + getattr(options, builtin_id)]
else:
output['variables']['node_builtin_shareable_builtins'] += [shareable_builtins[builtin]]

Expand Down
Loading