v19.5.0 proposal

.eslintrc.js

@@ -314,6 +314,7 @@ module.exports = {
     // Custom rules from eslint-plugin-node-core
     'node-core/no-unescaped-regexp-dot': 'error',
     'node-core/no-duplicate-requires': 'error',
+    'node-core/prefer-proto': 'error',
   },
   globals: {
     ByteLengthQueuingStrategy: 'readable',

.github/CODEOWNERS

@@ -1,9 +1,12 @@
 # Node.js Project Codeowners
 
-# 1. Codeowners must always be teams, never individuals
-# 2. Each codeowner team should contain at least one TSC member
-# 3. PRs touching any code with a codeowner must be signed off by at least one
-#    person on the code owner team.
+# This file does not define any requirements for landing PRs.
+# Its purpose is to allow automation of courtesy pings to the
+# relevant team(s) when any of the paths listed here are modified.
+# Criteria for landing PRs are defined in
+# https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#code-reviews.
+#
+# Codeowners must always be teams, never individuals.
 
 # tsc
 

.github/workflows/authors.yml

@@ -19,7 +19,7 @@ jobs:
           fetch-depth: '0'  # This is required to actually get all the authors
           persist-credentials: false
       - run: tools/update-authors.mjs  # Run the AUTHORS tool
-      - uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
+      - uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         env:

.github/workflows/find-inactive-collaborators.yml

@@ -33,7 +33,7 @@ jobs:
         run: tools/find-inactive-collaborators.mjs
 
       - name: Open pull request
-        uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
+        uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         env:

.github/workflows/find-inactive-tsc.yml

@@ -42,7 +42,7 @@ jobs:
         run: tools/find-inactive-tsc.mjs >> $GITHUB_ENV
 
       - name: Open pull request
-        uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
+        uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         env:

.github/workflows/license-builder.yml

@@ -21,7 +21,7 @@ jobs:
         with:
           persist-credentials: false
       - run: ./tools/license-builder.sh  # Run the license builder tool
-      - uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
+      - uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         env:

.github/workflows/timezone-update.yml

@@ -40,7 +40,7 @@ jobs:
         run: echo "${{ env.new_version }}" > test/fixtures/tz-version.txt
 
       - name: Open Pull Request
-        uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee  # Create a PR or update the Action's existing PR
+        uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5  # Create a PR or update the Action's existing PR
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:

.github/workflows/tools.yml

@@ -21,12 +21,11 @@ jobs:
             subsystem: tools
             label: tools
             run: |
-              cd tools
               NEW_VERSION=$(npm view eslint dist-tags.latest)
-              CURRENT_VERSION=$(node -p "require('./node_modules/eslint/package.json').version")
+              CURRENT_VERSION=$(node -p "require('./tools/node_modules/eslint/package.json').version")
               if [ "$NEW_VERSION" != "$CURRENT_VERSION" ]; then
                 echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
-                ./update-eslint.sh
+                ./tools/dep_updaters/update-eslint.sh
               fi
           - id: corepack
             subsystem: deps
@@ -78,6 +77,16 @@ jobs:
                 echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
                 ./tools/update-undici.sh
               fi
+          - id: postject
+            subsystem: deps
+            label: dependencies
+            run: |
+              NEW_VERSION=$(npm view postject dist-tags.latest)
+              CURRENT_VERSION=$(node -p "require('./test/fixtures/postject-copy/node_modules/postject/package.json').version")
+              if [ "$NEW_VERSION" != "$CURRENT_VERSION" ]; then
+                echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
+                ./tools/dep_updaters/update-postject.sh
+              fi
           - id: base64
             subsystem: deps
             label: dependencies
@@ -142,7 +151,7 @@ jobs:
       - run: ${{ matrix.run }}
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
-      - uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
+      - uses: gr2m/create-or-update-pull-request-action@77596e3166f328b24613f7082ab30bf2d93079d5
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         env:

.gitignore

@@ -136,10 +136,11 @@ tools/*/*.i.tmp
 /deps/npm/node_modules/.bin/
 # Respect V8's .gitignore
 !deps/v8/**
-# Ignore the libuv book and GitHub templates
-/deps/uv/.github/
+# Ignore the libuv book
 /deps/uv/docs/code/
 /deps/uv/docs/src/guide/
+# Ignore .github directories
+/deps/**/.github/
 # Ignore dependencies fetched by tools/v8/fetch_deps.py
 /deps/.cipd
 

.mailmap

@@ -141,6 +141,7 @@ David Mark Clements <[email protected]> <[email protected]>
 David Siegel <[email protected]> <[email protected]>
 DC <[email protected]>
 Deepjyoti Mondal <[email protected]>
+Deokjin Kim <[email protected]> <[email protected]>
 dnlup <[email protected]> <[email protected]>
 Domenic Denicola <[email protected]>
 Domenic Denicola <[email protected]> <[email protected]>

AUTHORS

@@ -3591,5 +3591,9 @@ A. Wilcox <[email protected]>
 Daniel Lemire <[email protected]>
 Eric Mutta <[email protected]>
 Vadim <[email protected]>
+Aaron Friel <[email protected]>
+Vaishno Chaitanya <[email protected]>
+Jonathan Diaz <[email protected]>
+Mike Roth <[email protected]>
 
 # Generated by tools/update-authors.mjs

CHANGELOG.md

@@ -35,7 +35,8 @@ release.
 </tr>
 <tr>
   <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V19.md#19.4.0">19.4.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V19.md#19.5.0">19.5.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V19.md#19.4.0">19.4.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V19.md#19.3.0">19.3.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V19.md#19.2.0">19.2.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V19.md#19.1.0">19.1.0</a><br/>

Makefile

@@ -1550,7 +1550,7 @@ CONFLICT_RE=^>>>>>>> [[:xdigit:]]+|^<<<<<<< [[:alpha:]]+
 
 # Related CI job: node-test-linter
 lint-ci: lint-js-ci lint-cpp lint-py lint-md lint-addon-docs lint-yaml-build lint-yaml
-	@if ! ( grep -IEqrs "$(CONFLICT_RE)" --exclude="error-message.js" benchmark deps doc lib src test tools ) \
+	@if ! ( grep -IEqrs "$(CONFLICT_RE)" --exclude="error-message.js" --exclude="merge-conflict.json" benchmark deps doc lib src test tools ) \
 		&& ! ( $(FIND) . -maxdepth 1 -type f | xargs grep -IEqs "$(CONFLICT_RE)" ); then \
 		exit 0 ; \
 	else \

README.md

@@ -7,6 +7,12 @@ For information on using Node.js, see the [Node.js website][].
 The Node.js project uses an [open governance model](./GOVERNANCE.md). The
 [OpenJS Foundation][] provides support for the project.
 
+Contributors are expected to act in a collaborative manner to move
+the project forward. We encourage the constructive exchange of contrary
+opinions and compromise. The [TSC](./GOVERNANCE.md#technical-steering-committee)
+reserves the right to limit or block contributors who repeatedly act in ways
+that discourage, exhaust, or otherwise negatively affect other participants.
+
 **This project has a [Code of Conduct][].**
 
 ## Table of contents
@@ -399,7 +405,7 @@ For information about the governance of the Node.js project, see
 * [oyyd](https://github.com/oyyd) -
   **Ouyang Yadong** <<[email protected]>> (he/him)
 * [panva](https://github.com/panva) -
-  **Filip Skokan** <<[email protected]>>
+  **Filip Skokan** <<[email protected]>> (he/him)
 * [puzpuzpuz](https://github.com/puzpuzpuz) -
   **Andrey Pechkurov** <<[email protected]>> (he/him)
 * [Qard](https://github.com/Qard) -

SECURITY.md

@@ -128,7 +128,7 @@ We often choose to work to improve our APIs based on those reports and issue
 fixes either in regular or security releases depending on how much of a risk to
 the community they pose.
 
-### Examples of vulneratibities
+### Examples of vulnerabilities
 
 #### Improper Certificate Validation (CWE-295)
 
@@ -156,7 +156,7 @@ the community they pose.
   and modification of that configuration can affect the confidentiality of
   data protected using the Node.js APIs this is considered a vulnerability.
 
-### Examples of non-vulneratibities
+### Examples of non-vulnerabilities
 
 #### Malicious Third-Party Modules (CWE-1357)
 

benchmark/_http-benchmarkers.js

@@ -65,7 +65,7 @@ class WrkBenchmarker {
     const args = [
       '-d', duration,
       '-c', options.connections,
-      '-t', Math.min(options.connections, require('os').cpus().length || 8),
+      '-t', Math.min(options.connections, require('os').availableParallelism() || 8),
       `${scheme}://127.0.0.1:${options.port}${options.path}`,
     ];
     for (const field in options.headers) {

benchmark/es/map-bench.js

@@ -25,7 +25,7 @@ function runObject(n) {
 }
 
 function runNullProtoObject(n) {
-  const m = Object.create(null);
+  const m = { __proto__: null };
   bench.start();
   for (let i = 0; i < n; i++) {
     m[`i${i}`] = i;
@@ -51,7 +51,7 @@ function runNullProtoLiteralObject(n) {
 }
 
 function StorageObject() {}
-StorageObject.prototype = Object.create(null);
+StorageObject.prototype = { __proto__: null };
 
 function runStorageObject(n) {
   const m = new StorageObject();

benchmark/process/getActiveResourcesInfo.js

@@ -0,0 +1,45 @@
+'use strict';
+
+const { createBenchmark } = require('../common.js');
+
+const { connect, createServer } = require('net');
+const { open } = require('fs');
+
+const bench = createBenchmark(main, {
+  handlesCount: [1e4],
+  requestsCount: [1e4],
+  timeoutsCount: [1e4],
+  immediatesCount: [1e4],
+  n: [1e5],
+});
+
+function main({ handlesCount, requestsCount, timeoutsCount, immediatesCount, n }) {
+  const server = createServer().listen();
+  const clients = [];
+  for (let i = 0; i < handlesCount; i++) {
+    clients.push(connect({ port: server.address().port }));
+  }
+
+  for (let i = 0; i < requestsCount; i++) {
+    open(__filename, 'r', () => {});
+  }
+
+  for (let i = 0; i < timeoutsCount; ++i) {
+    setTimeout(() => {}, 1);
+  }
+
+  for (let i = 0; i < immediatesCount; ++i) {
+    setImmediate(() => {});
+  }
+
+  bench.start();
+  for (let i = 0; i < n; ++i) {
+    process.getActiveResourcesInfo();
+  }
+  bench.end(n);
+
+  for (const client of clients) {
+    client.destroy();
+  }
+  server.close();
+}

configure.py

@@ -2024,11 +2024,7 @@ def make_bin_override():
 for builtin in shareable_builtins:
   builtin_id = 'node_shared_builtin_' + builtin.replace('/', '_') + '_path'
   if getattr(options, builtin_id):
-    if options.with_intl == 'none':
-      option_name = '--shared-builtin-' + builtin + '-path'
-      error(option_name + ' is incompatible with --with-intl=none' )
-    else:
-      output['defines'] += [builtin_id.upper() + '=' + getattr(options, builtin_id)]
+    output['defines'] += [builtin_id.upper() + '=' + getattr(options, builtin_id)]
   else:
     output['variables']['node_builtin_shareable_builtins'] += [shareable_builtins[builtin]]