Commits on Dec 31, 2015

1. test: remove time check …

   test-child-process-fork-net2.js checks that things happen within
   certain time constraints, thus doubling as a benchmark test in addition
   to a functionality test.
   
   This change removes the time check, as it was causing the test to fail
   on SmartOS and Windows (and possibly elsewhere) when the tests were
   run in parallel on CI. There is no guarantee that other tests won't
   consume enough resources to slow this test down, so don't check the time
   constraints (beyond the generous timeout that the test is given by
   test.py in the first place, of course).
   
   If we want to do benchmark/performance tests, we should keep them
   separate from pure functionality tests. The time check may have been a
   remnant of the distant past when Node.js was much slower. It predates
   io.js
   
   Ref: nodejs#4476

   

   Trott committed Dec 31, 2015
   Configuration menu

   • View commit details
   • Copy full SHA for 65f8ef9
   • Browse repository at this point

   Copy the full SHA

   65f8ef9 View commit details

   Browse the repository at this point in the history