Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16.x backport] lib: use null-prototype objects for property descriptors #43804

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 12, 2022

Refs: #42921

PR-URL: #43270
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Chengzhong Wu [email protected]
Reviewed-By: Minwoo Jung [email protected]

Refs: nodejs#42921

PR-URL: nodejs#43270
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/http
  • @nodejs/modules
  • @nodejs/net
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Jul 12, 2022
@nodejs-github-bot
Copy link
Collaborator

targos pushed a commit that referenced this pull request Jul 18, 2022
Refs: #42921
PR-URL: #43270
Backport-PR-URL: #43804
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@targos
Copy link
Member

targos commented Jul 18, 2022

Thanks. Landed in 4dc6fea

@targos targos closed this Jul 18, 2022
targos pushed a commit that referenced this pull request Jul 31, 2022
Refs: #42921
PR-URL: #43270
Backport-PR-URL: #43804
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#42921
PR-URL: nodejs/node#43270
Backport-PR-URL: nodejs/node#43804
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants