Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add section regarding property definition in primordials.md #42921

Merged
merged 1 commit into from
May 2, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 29, 2022

No description provided.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 29, 2022

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 29, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2022
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably justify why it matters for ObjectDefineProperty, but not for every other use case of object literals within node.

@aduh95
Copy link
Contributor Author

aduh95 commented May 1, 2022

This should probably justify why it matters for ObjectDefineProperty, but not for every other use case of object literals within node.

I've tried to come up with examples that demonstrate that, I'm open to suggestions if you see possible improvements.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2022
@nodejs-github-bot nodejs-github-bot merged commit 52ba02e into nodejs:master May 2, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 52ba02e

@aduh95 aduh95 deleted the primordials-defineProperty branch May 2, 2022 17:47
RafaelGSS pushed a commit that referenced this pull request May 10, 2022
@RafaelGSS RafaelGSS mentioned this pull request May 10, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
aduh95 added a commit to aduh95/node that referenced this pull request May 31, 2022
nodejs-github-bot pushed a commit that referenced this pull request Jun 3, 2022
Refs: #42921

PR-URL: #43270
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
italojs pushed a commit to italojs/node that referenced this pull request Jun 6, 2022
Refs: nodejs#42921

PR-URL: nodejs#43270
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
Refs: #42921

PR-URL: #43270
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
Refs: #42921

PR-URL: #43270
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
targos pushed a commit that referenced this pull request Jul 12, 2022
targos pushed a commit that referenced this pull request Jul 18, 2022
Refs: #42921
PR-URL: #43270
Backport-PR-URL: #43804
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
targos pushed a commit that referenced this pull request Jul 31, 2022
Refs: #42921
PR-URL: #43270
Backport-PR-URL: #43804
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: nodejs/node#42921
PR-URL: nodejs/node#43270
Backport-PR-URL: nodejs/node#43804
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
Refs: nodejs/node#42921

PR-URL: nodejs/node#43270
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants