Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix benchmark compare output #43722

Closed
wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

The patch #43601 makes benchmark/compare.js not work as expected as it outputs malformed CSV data.

Expected outputs:

$ node benchmark/compare.js --new ./node --old ./node --filter ok assert
"binary","filename","configuration","rate","time"
"old","assert/ok.js","n=100000",38415366.14645858,0.002603125
"new","assert/ok.js","n=100000",36958903.17802217,0.002705708

Outputs with the main branch:

$ node benchmark/compare.js --new ./node --old ./node --filter ok assert
"binary","filename","configuration","rate","time"
assert/ok.js n=100000: 40,438,760.551989086
assert/ok.js n=100000: 40,999,014.79367451
assert/ok.js n=100000: 36,593,175.372792974
assert/ok.js n=100000: 37,697,312.44550382

This patch moves the forced exit introduced in 684e107 to Benchmark.report which is only used in benchmarking processes.

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Jul 7, 2022
@legendecas legendecas marked this pull request as ready for review July 7, 2022 18:07
@mscdex
Copy link
Contributor

mscdex commented Jul 7, 2022

How does this compare to #43635 ?

@legendecas
Copy link
Member Author

@mscdex they are similar fixes. thank you for pointing that out. closing as duplicated with #43635.

@legendecas legendecas closed this Jul 8, 2022
@legendecas legendecas deleted the fix-benchmark-compare branch July 8, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants