Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix fork detection #43601

Closed

Conversation

ShogunPanda
Copy link
Contributor

Fixes #43598

@ShogunPanda ShogunPanda requested a review from mscdex June 28, 2022 13:30
@ShogunPanda ShogunPanda added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 28, 2022
@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Jun 28, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @ShogunPanda. Please 👍 to approve.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShogunPanda
Copy link
Contributor Author

Landed in d636fee

ShogunPanda added a commit that referenced this pull request Jun 29, 2022
PR-URL: #43601
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@ShogunPanda ShogunPanda deleted the fix-benchmark-fork-detection branch June 29, 2022 06:36
mabaasit pushed a commit to mabaasit/node that referenced this pull request Jul 6, 2022
PR-URL: nodejs#43601
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@legendecas
Copy link
Member

legendecas commented Jul 7, 2022

This patch makes benchmark/compare.js not work as expected as it outputs malformed csv data.

Expected examples:

$ node benchmark/compare.js --new ./node --old ./node --filter ok assert
"binary","filename","configuration","rate","time"
"old","assert/ok.js","n=100000",38415366.14645858,0.002603125
"new","assert/ok.js","n=100000",36958903.17802217,0.002705708

Outputs with this patch:

$ node benchmark/compare.js --new ./node --old ./node --filter ok assert
"binary","filename","configuration","rate","time"
assert/ok.js n=100000: 40,438,760.551989086
assert/ok.js n=100000: 40,999,014.79367451
assert/ok.js n=100000: 36,593,175.372792974
assert/ok.js n=100000: 37,697,312.44550382

targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43601
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43601
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43601
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43601
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

benchmark: truncated results after 684e1079653f
5 participants