src: fix memory leaks and refactor ByteSource #43202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
tniessen
force-pushed
the
src-memory-leaks-and-refactor-bytesource
branch
5 times, most recently
from
45a1378
to
2b6e52e
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced May 28, 2022
|
This has been open for more than a week with no comments... ping @nodejs/crypto. |
|
Do we have a team to ping for C++ reviews? |
I don't think we do. I suggested this in #43286 (comment) (but I guess a fast-tracked PR wasn't a good place to mention it). Edit: opened nodejs/TSC#1237. Second edit: created |
|
This has been open for more than two weeks with no comments... ping @nodejs/cpp-reviewers @nodejs/crypto. |
addaleax
approved these changes
Jun 10, 2022
panva
added
the
author ready
RaisinTen
approved these changes
Jun 10, 2022
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/43202 ✔ Done loading data for nodejs/node/pull/43202 ----------------------------------- PR info ------------------------------------ Title src: fix memory leaks and refactor ByteSource (#43202) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:src-memory-leaks-and-refactor-bytesource -> nodejs:master Labels crypto, c++, lib / src, author ready, needs-ci Commits 1 - src: fix memory leaks and refactor ByteSource Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/43202 Reviewed-By: Anna Henningsen Reviewed-By: Darshan Sen Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43202 Reviewed-By: Anna Henningsen Reviewed-By: Darshan Sen Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 24 May 2022 23:01:55 GMT ✔ Approvals: 3 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/43202#pullrequestreview-1002220635 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43202#pullrequestreview-1002898142 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/43202#pullrequestreview-1003512265 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-06-12T05:35:56Z: https://ci.nodejs.org/job/node-test-pull-request/44453/ - Querying data for job/node-test-pull-request/44453/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2483034882 |
nodejs-github-bot
added
the
commit-queue-failed
|
Landed in 167ea80 |
italojs
pushed a commit
to italojs/node
that referenced
this pull request
Jun 12, 2022
Add ByteSource::Builder to replace the common MallocOpenSSL() + ByteSource::Allocated() pattern. Remove ByteSource::reset() that is unused. Remove ByteSource::Resize() to make ByteSource truly immutable (until moved away). Instead, ByteSource::Builder::release() takes an optional size argument that truncates the resulting ByteSource. Fix occurrences of MallocOpenSSL() that do not always free the allocated memory by using the new ByteSource::Builder class instead. Remove ByteSource::get() and replace uses with ByteSource::data(). Remove ReallocOpenSSL() because it likely only saves us a few bytes whenever we use it. PR-URL: nodejs#43202 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
Add ByteSource::Builder to replace the common MallocOpenSSL() + ByteSource::Allocated() pattern. Remove ByteSource::reset() that is unused. Remove ByteSource::Resize() to make ByteSource truly immutable (until moved away). Instead, ByteSource::Builder::release() takes an optional size argument that truncates the resulting ByteSource. Fix occurrences of MallocOpenSSL() that do not always free the allocated memory by using the new ByteSource::Builder class instead. Remove ByteSource::get() and replace uses with ByteSource::data(). Remove ReallocOpenSSL() because it likely only saves us a few bytes whenever we use it. PR-URL: #43202 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
15 tasks
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
Add ByteSource::Builder to replace the common MallocOpenSSL() + ByteSource::Allocated() pattern. Remove ByteSource::reset() that is unused. Remove ByteSource::Resize() to make ByteSource truly immutable (until moved away). Instead, ByteSource::Builder::release() takes an optional size argument that truncates the resulting ByteSource. Fix occurrences of MallocOpenSSL() that do not always free the allocated memory by using the new ByteSource::Builder class instead. Remove ByteSource::get() and replace uses with ByteSource::data(). Remove ReallocOpenSSL() because it likely only saves us a few bytes whenever we use it. PR-URL: #43202 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>
16 tasks
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Jun 18, 2022
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Jun 18, 2022
Avoid manual calls to MallocOpenSSL in ArrayBufferOrViewContents and use the new ByteSource::Builder instead. Refs: nodejs#43202
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 25, 2022
Avoid manual calls to MallocOpenSSL in ArrayBufferOrViewContents and use the new ByteSource::Builder instead. Refs: #43202 PR-URL: #43477 Reviewed-By: Darshan Sen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Avoid manual calls to MallocOpenSSL in ArrayBufferOrViewContents and use the new ByteSource::Builder instead. Refs: #43202 PR-URL: #43477 Reviewed-By: Darshan Sen <[email protected]>
|
This would need a backport to land on v16.x because |
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Jul 26, 2022
ByteSource::Allocated accepts a void pointer now, so we do not need to cast the argument to a char pointer. Refs: nodejs#43202
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 27, 2022
ByteSource::Allocated accepts a void pointer now, so we do not need to cast the argument to a char pointer. Refs: #43202 PR-URL: #44001 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Feng Yu <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2022
ByteSource::Allocated accepts a void pointer now, so we do not need to cast the argument to a char pointer. Refs: #43202 PR-URL: #44001 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Feng Yu <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Aug 23, 2022
ByteSource::Allocated accepts a void pointer now, so we do not need to cast the argument to a char pointer. Refs: #43202 PR-URL: #44001 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Feng Yu <[email protected]>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
ByteSource::Allocated accepts a void pointer now, so we do not need to cast the argument to a char pointer. Refs: nodejs#43202 PR-URL: nodejs#44001 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Feng Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ByteSource::Builderto replace the commonMallocOpenSSL()+ByteSource::Allocated()pattern.Remove
ByteSource::reset()that is unused.Remove
ByteSource::Resize()to makeByteSourcetruly immutable (until moved away). Instead,ByteSource::Builder::release()takes an optional size argument that truncates the resultingByteSource.Fix occurrences of
MallocOpenSSL()that do not always free the allocated memory by using the newByteSource::Builderclass instead.Remove
ByteSource::get()and replace uses withByteSource::data().Remove
ReallocOpenSSL()because it likely only saves us a few bytes whenever we use it.This does save a few dozen lines of code, too. (Much of the diff is just to make the linter happy, which apparently requires changed lines to be formatted, and that increases the diff by about 50 % in this case.)