-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GitHub team for reviewing src (C++) changes #1237
Comments
+1
https://github.com/nodejs/node/issues/new |
This has been open for more than a week with a few +1s and no objections, so I created the team as proposed. @nodejs/cpp-reviewers You have been added to this team because at least one of the following is true, based on the commit history from the last 365 days:
Please feel free to remove yourself from the team if you do not wish to be pinged for reviews. Everyone else, please feel free to add yourself to the team if you do wish to be pinged for reviews. |
Refs: nodejs/node#43286 (comment)
Refs: nodejs/node#43202 (comment)
We currently don't have a team that we can ping for C++ changes that don't require familiarity with a particular subsystem. Subsystem teams such as
@nodejs/crypto
have very few active members who frequently review C++ changes, so pinging these teams is not always helpful.I'm proposing to create a new team under
@nodejs/core
, maybe@nodejs/cpp-reviewers
, to address this.To not start with an empty team, I'd like to add a small subset of active collaborators based on some git statistics, e.g., number of authored/reviewed commits that change
src/*
within the last year or so.(I was going to create this in the core repo but I don't know how to bypass the templates there.)
The text was updated successfully, but these errors were encountered: