Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: improve reliability of find_python.cmd script #42810

Merged
merged 1 commit into from
Apr 23, 2022

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Apr 21, 2022

The path of the Python executable might contain white spaces. Handle
this when the check-python function is called.

Fixes: #42801

@nodejs-github-bot nodejs-github-bot added install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Apr 21, 2022
@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 21, 2022
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: nodejs#42801
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 23, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 23, 2022
@nodejs-github-bot nodejs-github-bot merged commit e2ff1c3 into nodejs:master Apr 23, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in e2ff1c3

@lpinca lpinca deleted the handle/paths-with-spaces branch April 23, 2022 19:47
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: nodejs#42801

PR-URL: nodejs#42810
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2022
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: #42801

PR-URL: #42810
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request May 2, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: #42801

PR-URL: #42810
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: #42801

PR-URL: #42810
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: #42801

PR-URL: #42810
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: #42801

PR-URL: #42810
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
The path of the Python executable might contain white spaces. Handle
this when the `check-python` function is called.

Fixes: nodejs/node#42801

PR-URL: nodejs/node#42810
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.\vcbuild on Windows is not aware of default python installation in "c:\program files\..."
4 participants