-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.\vcbuild on Windows is not aware of default python installation in "c:\program files\..." #42801
Comments
VoltrexKeyva
added
windows
Issues and PRs related to the Windows platform.
build
Issues and PRs related to build files or the CI.
labels
Apr 21, 2022
lpinca
added a commit
to lpinca/node
that referenced
this issue
Apr 21, 2022
The path of Python executable might contain white spaces. Handle this when the `check-python` function is called. Fixes: nodejs#42801
lpinca
added a commit
to lpinca/node
that referenced
this issue
Apr 21, 2022
The path of the Python executable might contain white spaces. Handle this when the `check-python` function is called. Fixes: nodejs#42801
i kinda doubt since it seems like more of escaping isuse but a valid issue anyway |
nodejs-github-bot
pushed a commit
that referenced
this issue
Apr 23, 2022
The path of the Python executable might contain white spaces. Handle this when the `check-python` function is called. Fixes: #42801 PR-URL: #42810 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this issue
Apr 25, 2022
The path of the Python executable might contain white spaces. Handle this when the `check-python` function is called. Fixes: nodejs#42801 PR-URL: nodejs#42810 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this issue
Apr 28, 2022
The path of the Python executable might contain white spaces. Handle this when the `check-python` function is called. Fixes: #42801 PR-URL: #42810 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
juanarbol
pushed a commit
that referenced
this issue
May 31, 2022
The path of the Python executable might contain white spaces. Handle this when the `check-python` function is called. Fixes: #42801 PR-URL: #42810 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this issue
Jun 27, 2022
The path of the Python executable might contain white spaces. Handle this when the `check-python` function is called. Fixes: #42801 PR-URL: #42810 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this issue
Jul 12, 2022
The path of the Python executable might contain white spaces. Handle this when the `check-python` function is called. Fixes: #42801 PR-URL: #42810 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this issue
Jul 31, 2022
The path of the Python executable might contain white spaces. Handle this when the `check-python` function is called. Fixes: #42801 PR-URL: #42810 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this issue
Oct 10, 2022
The path of the Python executable might contain white spaces. Handle this when the `check-python` function is called. Fixes: nodejs/node#42801 PR-URL: nodejs/node#42810 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
18.0.0
Platform
Microsoft Windows NT 10.0.19044.0 x64
Subsystem
No response
What steps will reproduce the bug?
Install python 3.10 from python.org with default settings - will install to
c:\program files\python10
Run
.\vcbuild
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior?
No response
What do you see instead?
.\vcbuild
will find this installation at first, but fails after that:Additional information
Yes, there are ways around this. Yes, it could be documented in building.md.
Best way would be to make
find_python.cmd
aware of spaces in python's installation path.The text was updated successfully, but these errors were encountered: