tools: update babel-eslint-parser to 7.16.0 #40720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like some files have to be fixed. |
tniessen
approved these changes
Nov 4, 2021
|
s/will be flagged when we flagged when we/will be flagged when we/ |
targos
approved these changes
Nov 4, 2021
lpinca
approved these changes
Nov 4, 2021
Trott
added
author ready
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/40720 ✔ Done loading data for nodejs/node/pull/40720 ----------------------------------- PR info ------------------------------------ Title tools: update babel-eslint-parser to 7.16.0 (#40720) Author Rich Trott (@Trott) Branch Trott:bep-7.16 -> nodejs:master Labels tools, author ready Commits 2 - test: add semicolons for linter update - tools: update babel-eslint-parser to 7.16.0 Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40720 Reviewed-By: Tobias Nießen Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40720 Reviewed-By: Tobias Nießen Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 04 Nov 2021 05:41:28 GMT ✔ Approvals: 3 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40720#pullrequestreview-797837612 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40720#pullrequestreview-797840350 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40720#pullrequestreview-798182790 ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1429133588 |
github-actions
bot
added
the
commit-queue-failed
github-actions
bot
removed
the
request-ci
46 tasks
46 tasks
Trott
removed
the
commit-queue
Add missing semicolons that will be flagged when we update @babel/eslint-parser to 7.16.0. PR-URL: nodejs#40720 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#40720 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 04451d8...9ef0ae2 |
This was referenced Nov 9, 2021
targos
pushed a commit
that referenced
this pull request
Nov 21, 2021
Add missing semicolons that will be flagged when we update @babel/eslint-parser to 7.16.0. PR-URL: #40720 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 21, 2021
PR-URL: #40720 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
@Trott do you mind backporting this to 16.x? When I tried to land in 16.x-staging, there was a test that didn't pass. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 30, 2022
Add missing semicolons that will be flagged when we update @babel/eslint-parser to 7.16.0. PR-URL: nodejs#40720 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 30, 2022
PR-URL: nodejs#40720 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams Backported in #41770 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 31, 2022
Add missing semicolons that will be flagged when we update @babel/eslint-parser to 7.16.0. PR-URL: nodejs#40720 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#40720 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Add missing semicolons that will be flagged when we update @babel/eslint-parser to 7.16.0. PR-URL: #40720 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Backport-PR-URL: #41770 Reviewed-By: Danielle Adams <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #40720 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Backport-PR-URL: #41770 Reviewed-By: Danielle Adams <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.