test: guard large string decoder allocation #36795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
added
fast-track
github-actions
bot
removed
the
request-ci
|
👍 to fast-track and make ARM CI green. |
gireeshpunathil
approved these changes
Jan 5, 2021
PoojaDurgad
approved these changes
Jan 5, 2021
aduh95
approved these changes
Jan 5, 2021
Use common.enoughTestMem to avoid "Array buffer allocation failed" error on low memory devices. Fixes: nodejs#36792 PR-URL: nodejs#36795 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
|
Landed in e5b8c61 |
|
@targos thanks! |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Use common.enoughTestMem to avoid "Array buffer allocation failed" error on low memory devices. Fixes: #36792 PR-URL: #36795 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
targos
added a commit
that referenced
this pull request
May 25, 2021
Use common.enoughTestMem to avoid "Array buffer allocation failed" error on low memory devices. Fixes: #36792 PR-URL: #36795 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos
added a commit
that referenced
this pull request
Jun 5, 2021
Use common.enoughTestMem to avoid "Array buffer allocation failed" error on low memory devices. Fixes: #36792 PR-URL: #36795 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos
added a commit
that referenced
this pull request
Jun 11, 2021
Use common.enoughTestMem to avoid "Array buffer allocation failed" error on low memory devices. Fixes: #36792 PR-URL: #36795 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.
Fixes: #36792