Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-string-decoder failing regularly on arm #36792

Closed
mhdawson opened this issue Jan 5, 2021 · 6 comments · Fixed by #36795
Closed

test-string-decoder failing regularly on arm #36792

mhdawson opened this issue Jan 5, 2021 · 6 comments · Fixed by #36795
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@mhdawson
Copy link
Member

mhdawson commented Jan 5, 2021

  • Version: master
  • Platform: arm
  • Subsystem:

What steps will reproduce the bug?

Run CI on PR

How often does it reproduce? Is there a required condition?

From runs today looks like most failed with that error

What is the expected behavior?

tests pass

What do you see instead?

node:assert:577
      throw err;
      ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ Comparison {}
- Comparison {
-   code: 'ERR_STRING_TOO_LONG'
- }
    at Object.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-string-decoder.js:204:8)
    at Module._compile (node:internal/modules/cjs/loader:1108:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10)
    at Module.load (node:internal/modules/cjs/loader:973:32)
    at Function.Module._load (node:internal/modules/cjs/loader:813:14)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
    at node:internal/main/run_main_module:17:47 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: RangeError: Array buffer allocation failed
      at new ArrayBuffer (<anonymous>)
      at new Uint8Array (<anonymous>)
      at new FastBuffer (node:internal/buffer:957:5)
      at Function.alloc (node:buffer:362:10)
      at assert.throws.code (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-string-decoder.js:205:42)
      at getActual (node:assert:700:5)
      at Function.throws (node:assert:840:24)
      at Object.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-string-decoder.js:204:8)
      at Module._compile (node:internal/modules/cjs/loader:1108:14)
      at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10),
  expected: { code: 'ERR_STRING_TOO_LONG' },
  operator: 'throws'
}

Additional information

@mhdawson
Copy link
Member Author

mhdawson commented Jan 5, 2021

Most recent change to the test: #36661

@mhdawson mhdawson closed this as completed Jan 5, 2021
@mhdawson mhdawson reopened this Jan 5, 2021
@mhdawson
Copy link
Member Author

mhdawson commented Jan 5, 2021

Looks like arm was not in the CI when #36661 was landed.

@mhdawson
Copy link
Member Author

mhdawson commented Jan 5, 2021

Well past my end of day but was sticking around to try and get #36478 landed before there were conflicts.

@targos unless you have an easy fix for the new test I suggest we revert #36661 so that we can get the CI passing in on ARM again.

@mhdawson
Copy link
Member Author

mhdawson commented Jan 5, 2021

A better option might be to just disable the test for ARM. I've not looked too closely at the test yet but I'm guessing it may just be using too much memory for the PIs'. If that makes sense I'm happy to open a PR to skip for ARM unless somebody else beats me to it.

@PoojaDurgad
Copy link
Contributor

PoojaDurgad commented Jan 5, 2021

@targos targos added arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jan 5, 2021
@targos targos self-assigned this Jan 5, 2021
@targos
Copy link
Member

targos commented Jan 5, 2021

fix in #36795

@aduh95 aduh95 closed this as completed in e5b8c61 Jan 5, 2021
danielleadams pushed a commit that referenced this issue Jan 12, 2021
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos added a commit that referenced this issue May 25, 2021
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos added a commit that referenced this issue Jun 5, 2021
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos added a commit that referenced this issue Jun 11, 2021
Use common.enoughTestMem to avoid "Array buffer allocation failed"
error on low memory devices.

Fixes: #36792

PR-URL: #36795
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos removed their assignment Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants