-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-string-decoder failing regularly on arm #36792
Comments
Most recent change to the test: #36661 |
Looks like arm was not in the CI when #36661 was landed. |
A better option might be to just disable the test for ARM. I've not looked too closely at the test yet but I'm guessing it may just be using too much memory for the PIs'. If that makes sense I'm happy to open a PR to skip for ARM unless somebody else beats me to it. |
similar failure reported here as well: https://ci.nodejs.org/job/node-test-binary-arm-12+/8818/RUN_SUBSET=0,label=pi3-docker/console |
fix in #36795 |
Use common.enoughTestMem to avoid "Array buffer allocation failed" error on low memory devices. Fixes: #36792 PR-URL: #36795 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Use common.enoughTestMem to avoid "Array buffer allocation failed" error on low memory devices. Fixes: #36792 PR-URL: #36795 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Use common.enoughTestMem to avoid "Array buffer allocation failed" error on low memory devices. Fixes: #36792 PR-URL: #36795 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Use common.enoughTestMem to avoid "Array buffer allocation failed" error on low memory devices. Fixes: #36792 PR-URL: #36795 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
What steps will reproduce the bug?
Run CI on PR
How often does it reproduce? Is there a required condition?
From runs today looks like most failed with that error
What is the expected behavior?
tests pass
What do you see instead?
Additional information
The text was updated successfully, but these errors were encountered: