doc: fix added: info for stream._construct()
#36067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
`readable._construct()` and `writable._construct()` were added to Node.js v15.0.0 via fb8cc72. Fixes: nodejs#36058
lpinca
force-pushed
the
fix/added-version-for-construct
branch
from
9da8acf to
fa94436
Compare
lpinca
changed the title
added: info for stream._construct()added: info for stream._construct()
aduh95
approved these changes
Nov 10, 2020
|
fast-track? |
ronag
approved these changes
Nov 10, 2020
benjamingr
approved these changes
Nov 10, 2020
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 60a97c0...0dee498 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 10, 2020
`readable._construct()` and `writable._construct()` were added to Node.js v15.0.0 via fb8cc72. Fixes: #36058 PR-URL: #36067 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
|
If the methods do not exist in v14.x, the doc is wrong on that branch: https://github.com/nodejs/node/blob/v14.x/doc/api/stream.md#readable_constructcallback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readable._construct()andwritable._construct()were added toNode.js v15.0.0 via fb8cc72.
Fixes: #36058
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes