-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streams: readable stream does not get _construct called #36058
Comments
The feature is not available on Node.js 14.x. I think the |
`readable._construct()` and `writable._construct()` were added to Node.js v15.0.0 via fb8cc72. Fixes: nodejs#36058
If the feature is not available on v14.x, this is still an issue because the documentation has it on that branch: |
Can't #36067 simply be backported to v14? Or do you want to keep this open until that happens?
|
That PR just changes the version number. I think we should entirely remove that feature from the documentation in v14 |
Ah yes you are right, it makes sense. |
The feature was added in Node.js v15.0.0. Fixes: nodejs#36058
What steps will reproduce the bug?
If I run the above with v14.15.0 nothing gets printed but on v15.0.1 I get "_construct called".
How often does it reproduce?
Always
What is the expected behavior?
_construct
should be calledWhat do you see instead?
_construct
is not calledAdditional information
According to the docs this was added on v14.13.1
The text was updated successfully, but these errors were encountered: