Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: remove isPromise utility function #35925

Closed
wants to merge 2 commits into from
Closed

stream: remove isPromise utility function #35925

wants to merge 2 commits into from

Commits on Nov 2, 2020

  1. stream: remove isPromise utility function 

    The function was not checking if the parameter was actually a Promise
instance, but if it has a `then` method. Removing the utility function
in favor of a clearer `typeof` check, handling the case when the
thenable throws if then method is accessed more than once.
    @aduh95
    aduh95 committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    f18db47 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. fixup! stream: remove isPromise utility function

    @aduh95
    aduh95 committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    b8d1c8c View commit details
    Browse the repository at this point in the history