deps: upgrade npm to 7.0.0-rc.3 #35474

MylesBorins · 2020-10-02T23:17:09Z

release notes: https://github.com/npm/cli/releases/tag/v7.0.0-rc.3
corresponding v7 CHANGELOG.md

nodejs-github-bot · 2020-10-03T02:14:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33339/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2489/
CITGM master: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2490/
CITGM-nobuild on v14.x with npm 7.x: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/967/
CITGM-nobuild on v14.x with npm 6.x: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/968/

MylesBorins · 2020-10-03T02:16:28Z

Bumped to rc.2. @Trott I could not get the status flaky fail to work the way you described. I've updated the regex in the test to work for an rc, meaning that when we update to a non RC we will need to fix the test again. Hopefully that is a satisfactory middle ground.

deps/npm/bin/npx

nodejs-github-bot · 2020-10-05T04:28:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33395/

MylesBorins · 2020-10-05T04:44:19Z

@nodejs/node-gyp it looks like there is a failure on all platforms for test.addons/dlopen-ping-pong/test which I think is related to the node-gyp update in npm 7. Doing some local digging it would appear that this may be related to gyp, specifically the .so file ending up in a different directy than expected on linux (you will notice OSX is passing). Any idea what's up?

cclauss · 2020-10-05T04:53:40Z

What is the actual path and what is the expected path?
https://github.com/nodejs/node/blob/master/test/addons/dlopen-ping-pong/test.js#L17

rvagg · 2020-10-05T05:00:55Z

node-gyp 5.1.0 (current npm version):

build/
build/binding.target.mk
build/ping.target.mk
build/config.gypi
build/binding.Makefile
build/Release
build/Release/.deps
build/Release/.deps/Release
build/Release/.deps/Release/ping.so.d
build/Release/.deps/Release/obj.target
build/Release/.deps/Release/obj.target/binding
build/Release/.deps/Release/obj.target/binding/binding.o.d
build/Release/.deps/Release/obj.target/ping.so.d
build/Release/.deps/Release/obj.target/binding.node.d
build/Release/.deps/Release/obj.target/ping
build/Release/.deps/Release/obj.target/ping/ping.o.d
build/Release/.deps/Release/binding.node.d
build/Release/ping.so
build/Release/obj.target
build/Release/obj.target/binding
build/Release/obj.target/binding/binding.o
build/Release/obj.target/ping.so
build/Release/obj.target/binding.node
build/Release/obj.target/ping
build/Release/obj.target/ping/ping.o
build/Release/binding.node
build/Makefile

current node-gyp master:

build/
build/binding.target.mk
build/ping.target.mk
build/config.gypi
build/binding.Makefile
build/Release
build/Release/.deps
build/Release/.deps/Release
build/Release/.deps/Release/lib.target
build/Release/.deps/Release/lib.target/ping.so.d
build/Release/.deps/Release/obj.target
build/Release/.deps/Release/obj.target/binding
build/Release/.deps/Release/obj.target/binding/binding.o.d
build/Release/.deps/Release/obj.target/ping.so.d
build/Release/.deps/Release/obj.target/binding.node.d
build/Release/.deps/Release/obj.target/ping
build/Release/.deps/Release/obj.target/ping/ping.o.d
build/Release/.deps/Release/binding.node.d
build/Release/lib.target
build/Release/lib.target/ping.so
build/Release/obj.target
build/Release/obj.target/binding
build/Release/obj.target/binding/binding.o
build/Release/obj.target/ping.so
build/Release/obj.target/binding.node
build/Release/obj.target/ping
build/Release/obj.target/ping/ping.o
build/Release/binding.node
build/Makefile

Note the difference in location of ping.so. The test is expecting it to be in build/${common.buildType}/ping.so (edited).

binding.gyp is @ https://github.com/nodejs/node/blob/master/test/addons/dlopen-ping-pong/binding.gyp

@nodejs/gyp would you folks mind having a look at this? It looks like type': 'shared_library', is changing the target location to lib.target, is this expected behaviour and therefore we need to warn users about the new location, or do we have a legit bug (looks like it to me).

targos · 2020-10-05T06:44:15Z

It's nodejs/node-gyp#1975 (review)

targos · 2020-10-05T11:58:48Z

About nodejs/node-gyp#1975 (review):
Back in 2012, node-gyp made a local patch to gyp, changing where shared libraries would be written.
When I reunited the gyp code between node-gyp and Node.js last year, this change was reverted as we didn't find why it was done in the first place, and keeping it was breaking the Node.js builds.

MylesBorins · 2020-10-05T13:14:14Z

@rvagg @targos what's the next step here? Do we need to fix something upstream in gyp-next? Node-gyp? Change the test?

Is there something we can float here while that is happening to get the tests passing?

MylesBorins · 2020-10-05T15:05:59Z

@nodejs/platform-windows

I landed a patch to fix the vscode builds, but windows still seems to be failing. I don't have a windows box I can use locally... can anyone help?

richardlau · 2020-10-05T17:56:02Z

@nodejs/platform-windows

I landed a patch to fix the vscode builds, but windows still seems to be failing. I don't have a windows box I can use locally... can anyone help?

@MylesBorins Untested, but there's a reference at

node/tools/msvs/msi/product.wxs

Line 93 in cb8898c

that would need to be removed.

nodejs-github-bot · 2020-10-05T18:50:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33405/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2494/
CITGM master: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2490/

MylesBorins · 2020-10-05T18:52:14Z

test/addons/dlopen-ping-pong/test.js

+let pingSOPath = `${path.dirname(bindingPath)}/lib.target/ping.so`;
+
+if (common.isOSX) {
+  pingSOPath = `${path.dirname(bindingPath)}/ping.so`;
+}
+
+console.log('module.exports.load:', pingSOPath);
+module.exports.load(pingSOPath);
+


@nodejs/build @nodejs/node-gyp this should fix this test based on the changed behavior of gyp. Specifically that non OSX platforms output the ping.so to the lib/target directory. 🤞 this fixes CI.

I think there should be a longer conversation if we want this behavior to land in gyp, but we can perhaps push this out in Node.js 15 and get ecosystem feedback and iterate if neccessary.

Please let me know if you have any concerns

MylesBorins · 2020-10-05T20:06:41Z

Looks like we have a green CI!

Kicking off a test build which can be found at https://nodejs.org/download/test/v15.0.0-test20201005a7f6681ae6/

Want to make sure the installers for OSX + Windows are doing what is expected. Will update with link when available.

pkg: https://nodejs.org/download/test/v15.0.0-test20201005a7f6681ae6/node-v15.0.0-test20201005a7f6681ae6.pkg
msi: https://nodejs.org/download/test/v15.0.0-test20201005a7f6681ae6/node-v15.0.0-test20201005a7f6681ae6-x64.msi

deps/npm/CONTRIBUTING.md

bcoe

LGTM, with one question about the modification in Makefile.

bcoe · 2020-10-06T21:40:22Z

Makefile

@@ -1384,7 +1384,7 @@ CONFLICT_RE=^>>>>>>> [0-9A-Fa-f]+|^<<<<<<< [A-Za-z]+

 # Related CI job: node-test-linter
 lint-ci: lint-js-ci lint-cpp lint-py lint-md lint-addon-docs
-	@if ! ( grep -IEqrs "$(CONFLICT_RE)" benchmark deps doc lib src test tools ) \
+	@if ! ( grep -IEqrs "$(CONFLICT_RE)" --exclude="error-message.js" benchmark deps doc lib src test tools ) \


curious why we needed to add this exclude?

there is now a test in the deps/npm file that includes conflict markers for a test. The naive linter we have can't distinguish... so I used a hammer

test/parallel/test-macos-signed-deps.js

nodejs-github-bot · 2020-10-06T23:01:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33441/

Trott

Rubber stamp LGTM

nodejs-github-bot · 2020-10-07T04:08:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33447/

mcollina

rubber stamp lgtm

It would be ideal to add this to Node.js v15.

PR-URL: #35474 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Ben Coe <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

MylesBorins · 2020-10-07T14:00:37Z

Landed in 1469984...c87641a

Notable changes: Deprecations and Removals: - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **timers**: introduce timers/promises (James M Snell) (#33950) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) npm 7 (#35631): Node.js 15 comes with a new major release of npm, npm 7. npm 7 comes with many new features - including npm workspaces and a new package-lock.json format. npm 7 also includes yarn.lock file support. One of the big changes in npm 7 is that peer dependencies are now installed by default. Throw On Unhandled Rejections (#33021): As of Node.js 15, the default mode for `unhandledRejection` is changed to `throw` (from `warn`). In `throw` mode, if an `unhandledRejection` hook is not set, the `unhandledRejection` is raised as an uncaught exception. Users that have an `unhandledRejection` hook should see no change in behavior, and it’s still possible to switch modes using the `--unhandled-rejections=mode` process flag. QUIC (#32379): Node.js 15 comes with experimental support QUIC, which can be enabled by compiling Node.js with the `--experimental-quic` configuration flag. The Node.js QUIC implementation is exposed by the core `net` module. V8 8.6 (#35415): The V8 JavaScript engine has been updated to V8 8.6 (V8 8.4 is the latest available in Node.js 14). Along with performance tweaks and improvements the V8 update also brings the following language features: * `Promise.any()` (from V8 8.5) * `AggregateError` (from V8 8.5) * `String.prototype.replaceAll()` (from V8 8.5) * Logical assignment operators `&&=`, `||=`, and `??=` (from V8 8.5) Other Notable Changes: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **dns**: add dns/promises alias (shisama) (#32953) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **stream**: construct (Robert Nagy) (#29656) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) Semver-Major Commits: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **build**: reset embedder string to "-node.0" (Michaël Zasso) (#35415) - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **crypto**: refactoring internals, add WebCrypto (James M Snell) (#35093) - **crypto**: move node\_crypto files to src/crypto (James M Snell) (#35093) - **deps**: V8: cherry-pick d76abfed3512 (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 717543bbf0ef (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 6be2f6e26e8d (Michaël Zasso) (#35415) - **deps**: fix V8 build issue with inline methods (Jiawen Geng) (#35415) - **deps**: fix platform-embedded-file-writer-win for ARM64 (Michaël Zasso) (#35415) - **deps**: update V8 postmortem metadata script (Colin Ihrig) (#35415) - **deps**: update V8 to 8.6.395 (Michaël Zasso) (#35415) - **deps**: upgrade npm to 7.0.0 (Myles Borins) (#35631) - **deps**: update npm to 7.0.0-rc.3 (Myles Borins) (#35474) - **deps**: V8: cherry-pick 0d6debcc5f08 (Gus Caplan) (#33600) - **dns**: add dns/promises alias (shisama) (#32953) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **doc**: update support macos version for 15.x (Ash Cripps) (#35022) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http**: fixed socket.setEncoding fatal error (iskore) (#33405) - **http**: emit 'error' on aborted server request (Robert Nagy) (#33172) - **http**: cleanup end argument handling (Robert Nagy) (#31818) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **http2**: add `invalidheaders` test (Pranshu Srivastava) (#33161) - **http2**: refactor state code validation for the http2Stream class (rickyes) (#33535) - **http2**: header field valid checks (Pranshu Srivastava) (#33193) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: remove ERR\_INVALID\_OPT\_VALUE and ERR\_INVALID\_OPT\_VALUE\_ENCODING (Denys Otrishko) (#34682) - **lib**: handle one of args case in ERR\_MISSING\_ARGS (Denys Otrishko) (#34022) - **lib**: remove NodeError from the prototype of errors with code (Michaël Zasso) (#33857) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: check args in net.connect() and socket.connect() calls (Denys Otrishko) (#34022) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **process**: update v8 fast api calls usage (Maya Lekova) (#35415) - **process**: change default --unhandled-rejections=throw (Dan Fabulich) (#33021) - **process**: use v8 fast api calls for hrtime (Gus Caplan) (#33600) - **process**: delay throwing an error using `throwDeprecation` (Ruben Bridgewater) (#32312) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: implement NodePlatform::PostJob (Clemens Backes) (#35415) - **src**: update NODE\_MODULE\_VERSION to 88 (Michaël Zasso) (#35415) - **src**: error reporting on CPUUsage (Yash Ladha) (#34762) - **src**: use node:moduleName as builtin module filename (Michaël Zasso) (#35498) - **src**: enable wasm trap handler on windows (Gus Caplan) (#35033) - **src**: update NODE\_MODULE\_VERSION to 86 (Michaël Zasso) (#33579) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **src**: remove \_third\_party\_main support (Anna Henningsen) (#33971) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **src**: remove unused CancelPendingDelayedTasks (Anna Henningsen) (#32859) - **stream**: try to wait for flush to complete before 'finish' (Robert Nagy) (#34314) - **stream**: cleanup and fix Readable.wrap (Robert Nagy) (#34204) - **stream**: add promises version to utility functions (rickyes) (#33991) - **stream**: fix writable.end callback behavior (Robert Nagy) (#34101) - **stream**: construct (Robert Nagy) (#29656) - **stream**: write should throw on unknown encoding (Robert Nagy) (#33075) - **stream**: fix \_final and 'prefinish' timing (Robert Nagy) (#32780) - **stream**: simplify Transform stream implementation (Robert Nagy) (#32763) - **stream**: use callback to properly propagate error (Robert Nagy) (#29179) - **test**: update tests after increasing typed array size to 4GB (Kim-Anh Tran) (#35415) - **test**: fix tests for npm 7.0.0 (Myles Borins) (#35631) - **test**: fix test suite to work with npm 7 (Myles Borins) (#35474) - **test**: update WPT harness and tests (Michaël Zasso) (#33770) - **timers**: introduce timers/promises (James M Snell) (#33950) - **tools**: disable x86 safe exception handlers in V8 (Michaël Zasso) (#35415) - **tools**: update V8 gypfiles for 8.6 (Ujjwal Sharma) (#35415) - **tools**: update V8 gypfiles for 8.5 (Ujjwal Sharma) (#35415) - **url**: file URL path normalization (Daijiro Wachi) (#35477) - **url**: verify domain is not empty after "ToASCII" (Michaël Zasso) (#33770) - **url**: remove U+0000 case in the fragment state (Michaël Zasso) (#33770) - **url**: remove gopher from special schemes (Michaël Zasso) (#33325) - **url**: forbid lt and gt in url host code point (Yash Ladha) (#33328) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) - **win, child_process**: sanitize env variables (Bartosz Sosnowski) (#35210) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) - **worker**: set trackUnmanagedFds to true by default (Anna Henningsen) (#34394) - **worker**: rename error code to be more accurate (Anna Henningsen) (#33872) PR-URL: #35014

PR-URL: nodejs#35474 Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Ben Coe <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Oct 2, 2020

MylesBorins mentioned this pull request Oct 2, 2020

deps: upgrade npm to 7.0.0-rc.0 #35447

Closed

MylesBorins added semver-major PRs that contain breaking changes and should be released in the next major version. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Oct 2, 2020

This comment has been minimized.

Sign in to view

ruyadorno approved these changes Oct 2, 2020

View reviewed changes

MylesBorins force-pushed the npm-7.0.0-rc.1 branch from d34b92e to ae27b6b Compare October 3, 2020 02:12

MylesBorins changed the title ~~deps: upgrade npm to 7.0.0-rc.1~~ deps: upgrade npm to 7.0.0-rc.2 Oct 3, 2020

richardlau reviewed Oct 3, 2020

View reviewed changes

deps/npm/bin/npx Show resolved Hide resolved

nodejs deleted a comment from nodejs-github-bot Oct 5, 2020

MylesBorins force-pushed the npm-7.0.0-rc.1 branch from d567b48 to d198c66 Compare October 5, 2020 04:24

nodejs deleted a comment from nodejs-github-bot Oct 5, 2020

MylesBorins force-pushed the npm-7.0.0-rc.1 branch from d198c66 to 0672bc3 Compare October 5, 2020 18:22

MylesBorins commented Oct 5, 2020

View reviewed changes

MylesBorins force-pushed the npm-7.0.0-rc.1 branch from a7f6681 to f1ef463 Compare October 5, 2020 21:18

GeoffreyBooth reviewed Oct 6, 2020

View reviewed changes

deps/npm/CONTRIBUTING.md Show resolved Hide resolved

deps/npm/CONTRIBUTING.md Show resolved Hide resolved

bcoe approved these changes Oct 6, 2020

View reviewed changes

GeoffreyBooth reviewed Oct 6, 2020

View reviewed changes

test/parallel/test-macos-signed-deps.js Outdated Show resolved Hide resolved

GeoffreyBooth approved these changes Oct 6, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

MylesBorins added 2 commits October 6, 2020 19:00

deps: update npm to 7.0.0-rc.3

7d8e395

test: fix test suite to work with npm 7

73150f9

MylesBorins force-pushed the npm-7.0.0-rc.1 branch from dd8f88e to 73150f9 Compare October 6, 2020 23:00

rvagg mentioned this pull request Oct 6, 2020

shared_library builds have moved location nodejs/node-gyp#2233

Open

Trott approved these changes Oct 7, 2020

View reviewed changes

codebytere approved these changes Oct 7, 2020

View reviewed changes

guybedford approved these changes Oct 7, 2020

View reviewed changes

mcollina approved these changes Oct 7, 2020

View reviewed changes

MylesBorins closed this Oct 7, 2020

arcanis mentioned this pull request Oct 7, 2020

deps: Experiments with Corepack #35398

Closed

6 tasks

MylesBorins added dont-land-on-v10.x labels Oct 13, 2020

BethGriggs mentioned this pull request Oct 14, 2020

2020-10-20, Version 15.0.0 (Current) #35014

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: upgrade npm to 7.0.0-rc.3 #35474

deps: upgrade npm to 7.0.0-rc.3 #35474

MylesBorins commented Oct 2, 2020 •

edited

Loading

This comment has been minimized.

nodejs-github-bot commented Oct 3, 2020 •

edited by MylesBorins

Loading

MylesBorins commented Oct 3, 2020

nodejs-github-bot commented Oct 5, 2020

MylesBorins commented Oct 5, 2020

cclauss commented Oct 5, 2020

rvagg commented Oct 5, 2020 •

edited

Loading

targos commented Oct 5, 2020

targos commented Oct 5, 2020

MylesBorins commented Oct 5, 2020

MylesBorins commented Oct 5, 2020

richardlau commented Oct 5, 2020

nodejs-github-bot commented Oct 5, 2020 •

edited by MylesBorins

Loading

MylesBorins Oct 5, 2020

MylesBorins commented Oct 5, 2020 •

edited

Loading

bcoe left a comment

bcoe Oct 6, 2020

MylesBorins Oct 6, 2020

This comment has been minimized.

nodejs-github-bot commented Oct 6, 2020

Trott left a comment

nodejs-github-bot commented Oct 7, 2020

mcollina left a comment

MylesBorins commented Oct 7, 2020

deps: upgrade npm to 7.0.0-rc.3 #35474

deps: upgrade npm to 7.0.0-rc.3 #35474

Conversation

MylesBorins commented Oct 2, 2020 • edited Loading

This comment has been minimized.

nodejs-github-bot commented Oct 3, 2020 • edited by MylesBorins Loading

MylesBorins commented Oct 3, 2020

nodejs-github-bot commented Oct 5, 2020

MylesBorins commented Oct 5, 2020

cclauss commented Oct 5, 2020

rvagg commented Oct 5, 2020 • edited Loading

targos commented Oct 5, 2020

targos commented Oct 5, 2020

MylesBorins commented Oct 5, 2020

MylesBorins commented Oct 5, 2020

richardlau commented Oct 5, 2020

nodejs-github-bot commented Oct 5, 2020 • edited by MylesBorins Loading

MylesBorins Oct 5, 2020

Choose a reason for hiding this comment

MylesBorins commented Oct 5, 2020 • edited Loading

bcoe left a comment

Choose a reason for hiding this comment

bcoe Oct 6, 2020

Choose a reason for hiding this comment

MylesBorins Oct 6, 2020

Choose a reason for hiding this comment

This comment has been minimized.

nodejs-github-bot commented Oct 6, 2020

Trott left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Oct 7, 2020

mcollina left a comment

Choose a reason for hiding this comment

MylesBorins commented Oct 7, 2020

MylesBorins commented Oct 2, 2020 •

edited

Loading

nodejs-github-bot commented Oct 3, 2020 •

edited by MylesBorins

Loading

rvagg commented Oct 5, 2020 •

edited

Loading

nodejs-github-bot commented Oct 5, 2020 •

edited by MylesBorins

Loading

MylesBorins commented Oct 5, 2020 •

edited

Loading