-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v14.13.0 proposal #35419
v14.13.0 proposal #35419
Commits on Sep 24, 2020
-
doc: put release script specifics in details
Listing all the steps can be confusing an make it seem like the releaser is meant to run each of these steps manually. In fact I personally did that my first release. Let's put those steps in a details block to make it more obvious that it is informational and not steps to follow PR-URL: #35260 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c09f3dc - Browse repository at this point
Copy the full SHA c09f3dcView commit details -
doc: update crypto.createSecretKey accepted types
PR-URL: #35246 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2a4ae09 - Browse repository at this point
Copy the full SHA 2a4ae09View commit details -
module: fix crash on multiline named cjs imports
The node process crashes when trying to parse a multiline import statement for named exports of a CommonJS module: TypeError: Cannot read property '0' of null at ModuleJob._instantiate (internal/modules/esm/module_job.js:112:77) at async ModuleJob.run (internal/modules/esm/module_job.js:137:5) at async Loader.import (internal/modules/esm/loader.js:165:24) at async rejects.name (file:///***/node/test/es-module/test-esm-cjs-named-error.mjs:56:3) at async waitForActual (assert.js:721:5) at async rejects (assert.js:830:25), The reason is that the regexp that is currently used to decorate the original error fails for multi line import statements. Unfortunately the undecorated error stack only contains the single line which causes the import to fail: file:///***/node/test/fixtures/es-modules/package-cjs-named-error/multi-line.mjs:2 comeOn, ^^^^^^ SyntaxError: The requested module './fail.cjs' does not provide an export named 'comeOn' at ModuleJob._instantiate (internal/modules/esm/module_job.js:98:21) at async ModuleJob.run (internal/modules/esm/module_job.js:141:5) at async Loader.import (internal/modules/esm/loader.js:165:24) at async rejects.name (file:///***/node/test/es-module/test-esm-cjs-named-error.mjs:56:3) at async waitForActual (assert.js:721:5) at async rejects (assert.js:830:25) Hence, for multiline import statements we cannot create an equivalent piece of code that uses default import followed by an object destructuring assignment. In any case the node process should definitely not crash. So until we have a more sophisticated way of extracting the entire problematic multiline import statement, show the code example only for single-line imports where the current regexp approach works well. Refs: #35259 PR-URL: #35275 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 68ea7f5 - Browse repository at this point
Copy the full SHA 68ea7f5View commit details -
tools,doc: upgrade dependencies
PR-URL: #35244 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9d91842 - Browse repository at this point
Copy the full SHA 9d91842View commit details -
tools,doc: enforce alphabetical order for md refs
PR-URL: #35244 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c5d27e1 - Browse repository at this point
Copy the full SHA c5d27e1View commit details -
+ description of `socket.readyState` Note: YAML tag found in commit e697cfb Co-authored-by: Michael Auderer <[email protected]> PR-URL: #35262 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ec6b78a - Browse repository at this point
Copy the full SHA ec6b78aView commit details -
doc: fix heading space bug in assert.md
Fixing a heading rendering bug PR-URL: #35310 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0c4540b - Browse repository at this point
Copy the full SHA 0c4540bView commit details -
tools: ignore build folder when checking links
We checkout build as a subdirectory as part of CI and if you run `make test` instead of `make test-ci` you get loads of errors about markdown link breaks. Ignore this directory as we don't need to examine another repo PR-URL: #35315 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7f35573 - Browse repository at this point
Copy the full SHA 7f35573View commit details -
doc: revise dependency redirection text in policy.md
PR-URL: #35276 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1893449 - Browse repository at this point
Copy the full SHA 1893449View commit details -
doc: replace "this guide" link text with guide title
PR-URL: #35283 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b4514d4 - Browse repository at this point
Copy the full SHA b4514d4View commit details -
doc: change type of child_process.signalCode to string
During testing, and interfacing with child_processes, I found that the child_process.signalCode property to be the string representation of the signal, not number. PR-URL: #35223 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b9d767c - Browse repository at this point
Copy the full SHA b9d767cView commit details -
doc: move package config docs to separate page
This part of the docs aims to contain documentation regarding package configuration that covers both ESM and CJS realms. * Move Enabling section * Update Enabling section * Remove -u flag * Package scopes do not carry through `node_modules` folders Refs: nodejs/modules#539 Co-authored-by: Geoffrey Booth <[email protected]>> Co-authored-by: Guy Bedford <[email protected]> PR-URL: #34748 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ef0d2ef - Browse repository at this point
Copy the full SHA ef0d2efView commit details -
meta: update module pages in CODEOWNERS
PR-URL: #34932 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ab7d0e9 - Browse repository at this point
Copy the full SHA ab7d0e9View commit details -
doc: document support for package.json fields
Fixes: #33143 PR-URL: #34970 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1d1ce1f - Browse repository at this point
Copy the full SHA 1d1ce1fView commit details -
module: exports pattern support
PR-URL: #34718 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5057318 - Browse repository at this point
Copy the full SHA 5057318View commit details -
doc: edit subpath export patterns introduction
* Use parallel construction in the two sentences * Backticks around _package.json_ to match rest of file * Add comma for readability * Own the recommendation ("we recommend") PR-URL: #35254 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d7282c0 - Browse repository at this point
Copy the full SHA d7282c0View commit details
Commits on Sep 29, 2020
-
Refs: #35320 (comment) PR-URL: #35328 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dd53036 - Browse repository at this point
Copy the full SHA dd53036View commit details -
doc: put landing specifics in details tag
Showing all the steps isn't usually useful and makes it seem like the collaborator is meant to follow the manual steps. I've seen this happen during at least one onboarding. The section is also a bit long to comfortably scroll over quickly to find the next section. Let's put those steps in a details block to make it more obvious that it is there for unusual situations only. Co-authored-by: Shelley Vohr <[email protected]> PR-URL: #35296 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a8d3a7f - Browse repository at this point
Copy the full SHA a8d3a7fView commit details -
doc: update napi_make_callback documentation
Calling napi_make_callback() with no async_context is not resulting in using the current async context instead an empty context (id 0) is used. Using NULL is like using node::Makecallback without async_context which is deprecated since Node.js 10 (DEP0099). PR-URL: #35321 Fixes: #35188 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0a847ca - Browse repository at this point
Copy the full SHA 0a847caView commit details -
doc: avoid referring to C array size
The size of arrays is measured in bytes in C, not in the number of elements. The napi_get_cb_info function takes the length of the array, that is, the number of elements it can contain, and not its size. PR-URL: #35300 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6dc6dad - Browse repository at this point
Copy the full SHA 6dc6dadView commit details -
doc: improve N-API string-to-native doc
Mention null termination handling in the string size accounting and string truncation. PR-URL: #35322 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 482ce6c - Browse repository at this point
Copy the full SHA 482ce6cView commit details -
doc: refine require/import conditions constraints
PR-URL: #35311 Reviewed-By: Jan Krems <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5da5d41 - Browse repository at this point
Copy the full SHA 5da5d41View commit details -
deps: upgrade to c-ares v1.16.1
PR-URL: #35324 Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_1 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 353a567 - Browse repository at this point
Copy the full SHA 353a567View commit details -
src: allow N-API addon in
AddLinkedBinding()
`AddLinkedBinding()` can be used to load old-style Node.js addons, but currently not N-API addons. There’s no good reason not to support N-API addons as well, so add that. PR-URL: #35301 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Zeyu Yang <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0d8eaa3 - Browse repository at this point
Copy the full SHA 0d8eaa3View commit details -
src: fix incorrect SIGSEGV handling in NODE_USE_V8_WASM_TRAP_HANDLER
Pass SA_SIGINFO to sa_flags so the TrapWebAssemblyOrContinue is treated as sa_sigaction, not sa_handler, otherwise siginfo_t* info contains some garbage PR-URL: #35282 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1e1cb94 - Browse repository at this point
Copy the full SHA 1e1cb94View commit details -
test,child_process: add tests for signalCode value
Prior to this change, none of the child_process tests checked the signalCode property for a value other than null. Add a check to an existing test. PR-URL: #35327 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d7c28c9 - Browse repository at this point
Copy the full SHA d7c28c9View commit details -
doc: added version 7 to N-API version matrix
Node.js version 14.12.0 released the N-API version 7, but it's not present on the N-API version matrix. This change should fix the problem in the documentation. PR-URL: #35319 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1758ac8 - Browse repository at this point
Copy the full SHA 1758ac8View commit details -
doc: add gpg key export directions to releases doc
Adds an extra step with instructions for exporting a gpg key to be uploaded to the key server. PR-URL: #35298 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 87dfed0 - Browse repository at this point
Copy the full SHA 87dfed0View commit details -
Notable changes: - The UV_UDP_MMSG_FREE flag has been added. - UV__EPROTO has been remapped from 4046 to -4046 for consistency with other error codes. - On Windows, UTF-16 surrogate pairs are no longer replaced with the Unicode replacement character. - uv_timer_get_due_in() has been added. PR-URL: #35333 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 19b95a7 - Browse repository at this point
Copy the full SHA 19b95a7View commit details -
test: replace annonymous functions with arrow
PR-URL: #34921 Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f2635b3 - Browse repository at this point
Copy the full SHA f2635b3View commit details -
doc: set encoding to hex before piping hash
I found out that piping a hash to the stdout output would print a non-hex set of characters, however, the examples are intended to print out a hex-encoded output so, my proposal here is simple, we set the encoding to `hex` before piping the response of the hash algo by calling `hash.setEncoding('hex');`. With this the example is fixed PR-URL: #35338 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 857e321 - Browse repository at this point
Copy the full SHA 857e321View commit details -
doc: add history entry for breaking destroy() change
Refs: #29197 (comment) PR-URL: #35326 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 86ac749 - Browse repository at this point
Copy the full SHA 86ac749View commit details -
repl: standardize Control key indications
Throughout our messages and docs, we refer to the Control key in a surprisingly varied number of ways: * Control * Ctrl * Cntl * varied capitalization on the above (e.g., ctrl vs. Ctrl) Then, in key combinations: * One of the items from the previous list followed by `-` * ... or followed by `+` * ... surrounded or not by `<` and `>` * ... and inside backticks or not * ... or just `^` This is the start of standardization on the formulation recommended by the Microsoft Style Guide (e.g., **Ctrl+C**). PR-URL: #35270 Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0f4ecaa - Browse repository at this point
Copy the full SHA 0f4ecaaView commit details -
doc: edit n-api.md for minor improvements
Not a comprehensive edit. Just a few things I noticed. * Favor present tense where there's a choice * Added a comma for clarity * Added a missing word ("in") PR-URL: #35361 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 010173a - Browse repository at this point
Copy the full SHA 010173aView commit details -
module: named exports for CJS via static analysis
PR-URL: #35249 Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f551f52 - Browse repository at this point
Copy the full SHA f551f52View commit details -
tools: update ESLint to 7.10.0
Update ESLint to 7.10.0 PR-URL: #35366 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 80eb221 - Browse repository at this point
Copy the full SHA 80eb221View commit details -
doc: outline when origin is set to unhandledRejection
PR-URL: #35294 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 70ad69b - Browse repository at this point
Copy the full SHA 70ad69bView commit details -
fs: fix fs.promises.writeFile with typed arrays
Before this change, only the first part of typed arrays which have more than 1 byte per element (e.g. Uint16Array) would be written. This also removes the use of the `slice` method to avoid unnecessary copying the data. Fixes: #35343 PR-URL: #35376 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 99a79e3 - Browse repository at this point
Copy the full SHA 99a79e3View commit details -
PR-URL: #35370 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 46a4154 - Browse repository at this point
Copy the full SHA 46a4154View commit details -
Backport-PR-URL: #35318 PR-URL: #35219 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 02db136 - Browse repository at this point
Copy the full SHA 02db136View commit details -
doc: remove http2 non-link anchor tags
Headers have ids automatically assigned. Removed ad hoc ids using anchor tags that aren't links. Backport-PR-URL: #35334 PR-URL: #35161 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2e10616 - Browse repository at this point
Copy the full SHA 2e10616View commit details -
2020-09-29, Version 14.13.0 (Current)
Notable changes: deps: * (SEMVER-MINOR) upgrade to libuv 1.40.0 (Colin Ihrig) #35333 module: * (SEMVER-MINOR) named exports for CJS via static analysis (Guy Bedford) #35249 * (SEMVER-MINOR) exports pattern support (Guy Bedford) #34718 src: * (SEMVER-MINOR) allow N-API addon in `AddLinkedBinding()` (Anna Henningsen) #35301 PR-URL: #35419
1Configuration menu - View commit details
-
Copy full SHA for c048607 - Browse repository at this point
Copy the full SHA c048607View commit details