tools,doc: Enforce alphabetical order in Markdown files #35244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
aduh95
force-pushed
the
enforce-alphabetical-order
branch
from
4a16875
to
a9937ef
Compare
aduh95
changed the title
codebytere
approved these changes
Sep 21, 2020
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
PR-URL: nodejs#35244 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
PR-URL: nodejs#35244 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
Trott
force-pushed
the
enforce-alphabetical-order
branch
from
a9937ef
to
7794d36
Compare
|
Landed in 219e9fe...7794d36 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 24, 2020
PR-URL: #35244 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 24, 2020
PR-URL: #35244 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
Merged
Trott
pushed a commit
to aduh95/node
that referenced
this pull request
Oct 1, 2020
Refs: nodejs#35244 PR-URL: nodejs#35191 Fixes: nodejs#35189 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Oct 6, 2020
Refs: #35244 PR-URL: #35191 Fixes: #35189 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35244 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35244 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #35244 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #35244 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35244 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35244 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Refs: nodejs#35244 PR-URL: nodejs#35191 Fixes: nodejs#35189 Reviewed-By: Derek Lewis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test to check if references at the bottom of MD files in the code base are ordered.
This also includes a commit to upgrade the dependencies in
/tools/doc, necessary to perform the test.Refs: #35230 (comment)
/cc @Trott
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes