Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-fs-stream-construct #34203

Merged
merged 25 commits into from
Jul 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b1750a4
quic: continued refactoring for quic_stream/quic_session
jasnell Jul 1, 2020
b5bf5bb
quic: refactor native object flags for better readability
jasnell Jul 1, 2020
f7510ca
quic: additional cleanups on the c++ side
jasnell Jul 1, 2020
f9c2245
quic: refactor QuicSession close/destroy flow
jasnell Jul 1, 2020
3acdd6a
quic: refactor QuicSession shared state to use AliasedStruct
jasnell Jul 1, 2020
e4d369e
quic: remove onSessionDestroy callback
jasnell Jul 2, 2020
7b062ca
quic: refactor qlog handling
jasnell Jul 2, 2020
3837d9c
quic: fixup lint issues
jasnell Jul 2, 2020
5a87e9b
quic: cleanup timers if they haven't been already
jasnell Jul 3, 2020
1b1e985
quic: add missing memory tracker fields
jasnell Jul 3, 2020
e7dadd3
doc: specify how fs.WriteStream/ReadStreams are created
jasnell Jul 3, 2020
d4f6900
src: add TimerWrap utility
jasnell Jul 3, 2020
e19a251
src: replace InspectorTimer with TimerWrap utility
jasnell Jul 3, 2020
0f97d60
quic: use TimerWrap for idle and retransmit timers
jasnell Jul 3, 2020
8a57788
doc: move gibfahn to emeritus
Trott Jul 4, 2020
7eb500b
doc: move digitalinfinity to emeritus
Trott Jul 4, 2020
654df09
doc: move ERR_FEATURE_UNAVAILABLE_ON_PLATFORM to current errors
Trott Jul 4, 2020
82c435d
src: fix unused namespace member
branisha Jul 5, 2020
67ba825
src: fix minor comment typo in KeyObjectData
danbev Jul 2, 2020
ddfaafa
repl: fix verb conjugation in deprecation message
Trott Jul 4, 2020
9f0671e
test: replace deprecated function call from test-repl-history-navigation
Trott Jul 4, 2020
bf77289
doc: remove errors that were never released
Trott Jul 4, 2020
3975799
doc: replace http to https of link urls
sapics Jun 29, 2020
ee3416b
lib: replace http to https of comment link urls
sapics Jun 29, 2020
772fdb0
test: fix flaky test-fs-stream-construct
Trott Jul 4, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,6 @@ For information about the governance of the Node.js project, see
**David Carlier** <[email protected]>
* [devsnek](https://github.com/devsnek) -
**Gus Caplan** <[email protected]> (he/him)
* [digitalinfinity](https://github.com/digitalinfinity) -
**Hitesh Kanwathirtha** <[email protected]> (he/him)
* [edsadr](https://github.com/edsadr) -
**Adrian Estrada** <[email protected]> (he/him)
* [eugeneo](https://github.com/eugeneo) -
Expand All @@ -307,8 +305,6 @@ For information about the governance of the Node.js project, see
**Jiawen Geng** <[email protected]>
* [GeoffreyBooth](https://github.com/geoffreybooth) -
**Geoffrey Booth** <[email protected]> (he/him)
* [gibfahn](https://github.com/gibfahn) -
**Gibson Fahnestock** <[email protected]> (he/him)
* [gireeshpunathil](https://github.com/gireeshpunathil) -
**Gireesh Punathil** <[email protected]> (he/him)
* [guybedford](https://github.com/guybedford) -
Expand Down Expand Up @@ -454,12 +450,16 @@ For information about the governance of the Node.js project, see
**Claudio Rodriguez** <[email protected]>
* [DavidCai1993](https://github.com/DavidCai1993) -
**David Cai** <[email protected]> (he/him)
* [digitalinfinity](https://github.com/digitalinfinity) -
**Hitesh Kanwathirtha** <[email protected]> (he/him)
* [eljefedelrodeodeljefe](https://github.com/eljefedelrodeodeljefe) -
**Robert Jefe Lindstaedt** <[email protected]>
* [estliberitas](https://github.com/estliberitas) -
**Alexander Makarenko** <[email protected]>
* [firedfox](https://github.com/firedfox) -
**Daniel Wang** <[email protected]>
* [gibfahn](https://github.com/gibfahn) -
**Gibson Fahnestock** <[email protected]> (he/him)
* [glentiki](https://github.com/glentiki) -
**Glen Keane** <[email protected]> (he/him)
* [iarna](https://github.com/iarna) -
Expand Down
2 changes: 1 addition & 1 deletion doc/api/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -1579,5 +1579,5 @@ $ node --max-old-space-size=1536 index.js
[emit_warning]: process.html#process_process_emitwarning_warning_type_code_ctor
[experimental ECMAScript Module loader]: esm.html#esm_experimental_loaders
[jitless]: https://v8.dev/blog/jitless
[libuv threadpool documentation]: http://docs.libuv.org/en/latest/threadpool.html
[libuv threadpool documentation]: https://docs.libuv.org/en/latest/threadpool.html
[remote code execution]: https://www.owasp.org/index.php/Code_Injection
4 changes: 2 additions & 2 deletions doc/api/dns.md
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ The [`dns.setServers()`][] method affects only [`dns.resolve()`][],
[`dns.lookup()`][]).

This method works much like
[resolve.conf](http://man7.org/linux/man-pages/man5/resolv.conf.5.html).
[resolve.conf](https://man7.org/linux/man-pages/man5/resolv.conf.5.html).
That is, if attempting to resolve with the first server provided results in a
`NOTFOUND` error, the `resolve()` method will *not* attempt to resolve with
subsequent servers provided. Fallback DNS servers will only be used if the
Expand Down Expand Up @@ -1082,7 +1082,7 @@ The `dnsPromises.setServers()` method must not be called while a DNS query is in
progress.

This method works much like
[resolve.conf](http://man7.org/linux/man-pages/man5/resolv.conf.5.html).
[resolve.conf](https://man7.org/linux/man-pages/man5/resolv.conf.5.html).
That is, if attempting to resolve with the first server provided results in a
`NOTFOUND` error, the `resolve()` method will *not* attempt to resolve with
subsequent servers provided. Fallback DNS servers will only be used if the
Expand Down
93 changes: 12 additions & 81 deletions doc/api/errors.md
Original file line number Diff line number Diff line change
Expand Up @@ -919,6 +919,15 @@ for the JS engine are not set up properly.
A `Promise` that was callbackified via `util.callbackify()` was rejected with a
falsy value.

<a id="ERR_FEATURE_UNAVAILABLE_ON_PLATFORM"></a>
#### `ERR_FEATURE_UNAVAILABLE_ON_PLATFORM`
<!-- YAML
added: v14.0.0
-->

Used when a feature that is not available
to the current platform which is running Node.js is used.

<a id="ERR_FS_FILE_TOO_LARGE"></a>
### `ERR_FS_FILE_TOO_LARGE`

Expand Down Expand Up @@ -2622,84 +2631,6 @@ removed: v10.0.0
Used when an attempt is made to use a `zlib` object after it has already been
closed.

### Other error codes

These errors have never been released, but had been present on master between
releases.

<a id="ERR_ENTRY_TYPE_MISMATCH"></a>
#### `ERR_ENTRY_TYPE_MISMATCH`

The `--entry-type=commonjs` flag was used to attempt to execute an `.mjs` file
or a `.js` file where the nearest parent `package.json` contains
`"type": "module"`; or
the `--entry-type=module` flag was used to attempt to execute a `.cjs` file or
a `.js` file where the nearest parent `package.json` either lacks a `"type"`
field or contains `"type": "commonjs"`.

<a id="ERR_FS_WATCHER_ALREADY_STARTED"></a>
#### `ERR_FS_WATCHER_ALREADY_STARTED`

An attempt was made to start a watcher returned by `fs.watch()` that has
already been started.

<a id="ERR_FS_WATCHER_NOT_STARTED"></a>
#### `ERR_FS_WATCHER_NOT_STARTED`

An attempt was made to initiate operations on a watcher returned by
`fs.watch()` that has not yet been started.

<a id="ERR_HTTP2_ALREADY_SHUTDOWN"></a>
#### `ERR_HTTP2_ALREADY_SHUTDOWN`

Occurs with multiple attempts to shutdown an HTTP/2 session.

<a id="ERR_HTTP2_ERROR"></a>
#### `ERR_HTTP2_ERROR`

A non-specific HTTP/2 error has occurred.

<a id="ERR_INVALID_REPL_HISTORY"></a>
#### `ERR_INVALID_REPL_HISTORY`

Used in the `repl` in case the old history file is used and an error occurred
while trying to read and parse it.

<a id="ERR_INVALID_REPL_TYPE"></a>
#### `ERR_INVALID_REPL_TYPE`

The `--entry-type=...` flag is not compatible with the Node.js REPL.

<a id="ERR_FEATURE_UNAVAILABLE_ON_PLATFORM"></a>
#### `ERR_FEATURE_UNAVAILABLE_ON_PLATFORM`

Used when a feature that is not available
to the current platform which is running Node.js is used.

<a id="ERR_STREAM_HAS_STRINGDECODER"></a>
#### `ERR_STREAM_HAS_STRINGDECODER`

Used to prevent an abort if a string decoder was set on the Socket.

```js
const Socket = require('net').Socket;
const instance = new Socket();

instance.setEncoding('utf8');
```

<a id="ERR_STRING_TOO_LARGE"></a>
#### `ERR_STRING_TOO_LARGE`

An attempt has been made to create a string larger than the maximum allowed
size.

<a id="ERR_TTY_WRITABLE_NOT_READABLE"></a>
#### `ERR_TTY_WRITABLE_NOT_READABLE`

This `Error` is thrown when a read is attempted on a TTY `WriteStream`,
such as `process.stdout.on('data')`.

[`'uncaughtException'`]: process.html#process_event_uncaughtexception
[`--disable-proto=throw`]: cli.html#cli_disable_proto_mode
[`--force-fips`]: cli.html#cli_force_fips
Expand All @@ -2723,7 +2654,7 @@ such as `process.stdout.on('data')`.
[`dgram.createSocket()`]: dgram.html#dgram_dgram_createsocket_options_callback
[`dgram.disconnect()`]: dgram.html#dgram_socket_disconnect
[`dgram.remoteAddress()`]: dgram.html#dgram_socket_remoteaddress
[`errno`(3) man page]: http://man7.org/linux/man-pages/man3/errno.3.html
[`errno`(3) man page]: https://man7.org/linux/man-pages/man3/errno.3.html
[`fs.Dir`]: fs.html#fs_class_fs_dir
[`fs.readFileSync`]: fs.html#fs_fs_readfilesync_path_options
[`fs.readdir`]: fs.html#fs_fs_readdir_path_options_callback
Expand All @@ -2735,7 +2666,7 @@ such as `process.stdout.on('data')`.
[`hash.update()`]: crypto.html#crypto_hash_update_data_inputencoding
[`http`]: http.html
[`https`]: https.html
[`libuv Error handling`]: http://docs.libuv.org/en/v1.x/errors.html
[`libuv Error handling`]: https://docs.libuv.org/en/v1.x/errors.html
[`net`]: net.html
[`new URL(input)`]: url.html#url_new_url_input_base
[`new URLSearchParams(iterable)`]: url.html#url_new_urlsearchparams_iterable
Expand Down Expand Up @@ -2771,7 +2702,7 @@ such as `process.stdout.on('data')`.
[policy]: policy.html
[RFC 7230 Section 3]: https://tools.ietf.org/html/rfc7230#section-3
[stream-based]: stream.html
[syscall]: http://man7.org/linux/man-pages/man2/syscalls.2.html
[syscall]: https://man7.org/linux/man-pages/man2/syscalls.2.html
[Subresource Integrity specification]: https://www.w3.org/TR/SRI/#the-integrity-attribute
[try-catch]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/try...catch
[vm]: vm.html
Expand Down
8 changes: 4 additions & 4 deletions doc/api/esm.md
Original file line number Diff line number Diff line change
Expand Up @@ -1817,11 +1817,11 @@ success!
[`module.createRequire()`]: modules.html#modules_module_createrequire_filename
[`module.syncBuiltinESMExports()`]: modules.html#modules_module_syncbuiltinesmexports
[`transformSource` hook]: #esm_code_transformsource_code_hook
[ArrayBuffer]: http://www.ecma-international.org/ecma-262/6.0/#sec-arraybuffer-constructor
[ArrayBuffer]: https://www.ecma-international.org/ecma-262/6.0/#sec-arraybuffer-constructor
[SharedArrayBuffer]: https://tc39.es/ecma262/#sec-sharedarraybuffer-constructor
[string]: http://www.ecma-international.org/ecma-262/6.0/#sec-string-constructor
[TypedArray]: http://www.ecma-international.org/ecma-262/6.0/#sec-typedarray-objects
[Uint8Array]: http://www.ecma-international.org/ecma-262/6.0/#sec-uint8array
[string]: https://www.ecma-international.org/ecma-262/6.0/#sec-string-constructor
[TypedArray]: https://www.ecma-international.org/ecma-262/6.0/#sec-typedarray-objects
[Uint8Array]: https://www.ecma-international.org/ecma-262/6.0/#sec-uint8array
[`util.TextDecoder`]: util.html#util_class_util_textdecoder
[import an ES or CommonJS module for its side effects only]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import#Import_a_module_for_its_side_effects_only
[special scheme]: https://url.spec.whatwg.org/#special-scheme
Expand Down
10 changes: 7 additions & 3 deletions doc/api/fs.md
Original file line number Diff line number Diff line change
Expand Up @@ -654,8 +654,8 @@ added: v0.1.93

* Extends: {stream.Readable}

A successful call to `fs.createReadStream()` will return a new `fs.ReadStream`
object.
Instances of `fs.ReadStream` are created and returned using the
[`fs.createReadStream()`][] function.

### Event: `'close'`
<!-- YAML
Expand Down Expand Up @@ -1079,6 +1079,9 @@ added: v0.1.93

* Extends {stream.Writable}

Instances of `fs.WriteStream` are created and returned using the
[`fs.createWriteStream()`][] function.

### Event: `'close'`
<!-- YAML
added: v0.1.93
Expand Down Expand Up @@ -5898,6 +5901,7 @@ the file contents.
[`fs.chmod()`]: #fs_fs_chmod_path_mode_callback
[`fs.chown()`]: #fs_fs_chown_path_uid_gid_callback
[`fs.copyFile()`]: #fs_fs_copyfile_src_dest_mode_callback
[`fs.createReadStream()`]: #fs_fs_createreadstream_path_options
[`fs.createWriteStream()`]: #fs_fs_createwritestream_path_options
[`fs.exists()`]: fs.html#fs_fs_exists_path_callback
[`fs.fstat()`]: #fs_fs_fstat_fd_options_callback
Expand Down Expand Up @@ -5929,7 +5933,7 @@ the file contents.
[`fsPromises.open()`]: #fs_fspromises_open_path_flags_mode
[`fsPromises.opendir()`]: #fs_fspromises_opendir_path_options
[`fsPromises.utimes()`]: #fs_fspromises_utimes_path_atime_mtime
[`inotify(7)`]: http://man7.org/linux/man-pages/man7/inotify.7.html
[`inotify(7)`]: https://man7.org/linux/man-pages/man7/inotify.7.html
[`kqueue(2)`]: https://www.freebsd.org/cgi/man.cgi?query=kqueue&sektion=2
[`net.Socket`]: net.html#net_class_net_socket
[`stat()`]: fs.html#fs_fs_stat_path_options_callback
Expand Down
4 changes: 2 additions & 2 deletions doc/api/n-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -5537,8 +5537,8 @@ This API may only be called from the main thread.
[`napi_wrap`]: #n_api_napi_wrap
[`node_api.h`]: https://github.com/nodejs/node/blob/master/src/node_api.h
[`process.release`]: process.html#process_process_release
[`uv_ref`]: http://docs.libuv.org/en/v1.x/handle.html#c.uv_ref
[`uv_unref`]: http://docs.libuv.org/en/v1.x/handle.html#c.uv_unref
[`uv_ref`]: https://docs.libuv.org/en/v1.x/handle.html#c.uv_ref
[`uv_unref`]: https://docs.libuv.org/en/v1.x/handle.html#c.uv_unref
[async_hooks `type`]: async_hooks.html#async_hooks_type
[context-aware addons]: addons.html#addons_context_aware_addons
[docs]: https://github.com/nodejs/node-addon-api#api-documentation
Expand Down
2 changes: 1 addition & 1 deletion doc/api/net.md
Original file line number Diff line number Diff line change
Expand Up @@ -1259,7 +1259,7 @@ Returns `true` if input is a version 6 IP address, otherwise returns `false`.
[`server.listen(handle)`]: #net_server_listen_handle_backlog_callback
[`server.listen(options)`]: #net_server_listen_options_callback
[`server.listen(path)`]: #net_server_listen_path_backlog_callback
[`socket(7)`]: http://man7.org/linux/man-pages/man7/socket.7.html
[`socket(7)`]: https://man7.org/linux/man-pages/man7/socket.7.html
[`socket.connect()`]: #net_socket_connect
[`socket.connect(options)`]: #net_socket_connect_options_connectlistener
[`socket.connect(path)`]: #net_socket_connect_path_connectlistener
Expand Down
2 changes: 1 addition & 1 deletion doc/api/process.md
Original file line number Diff line number Diff line change
Expand Up @@ -2644,6 +2644,6 @@ cases:
[process_warning]: #process_event_warning
[report documentation]: report.html
[terminal raw mode]: tty.html#tty_readstream_setrawmode_mode
[uv_rusage_t]: http://docs.libuv.org/en/v1.x/misc.html#c.uv_rusage_t
[uv_rusage_t]: https://docs.libuv.org/en/v1.x/misc.html#c.uv_rusage_t
[wikipedia_minor_fault]: https://en.wikipedia.org/wiki/Page_fault#Minor
[wikipedia_major_fault]: https://en.wikipedia.org/wiki/Page_fault#Major
45 changes: 28 additions & 17 deletions doc/api/quic.md
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ added: REPLACEME
* `maxStatelessResetsPerHost` {number} The maximum number of stateless
resets that the `QuicSocket` is permitted to send per remote host.
Default: `10`.
* `qlog` {boolean} Whether to emit ['qlog'][] events for incoming sessions.
* `qlog` {boolean} Whether to enable ['qlog'][] for incoming sessions.
(For outgoing client sessions, set `client.qlog`.) Default: `false`.
* `retryTokenTimeout` {number} The maximum number of *seconds* for retry token
validation. Default: `10` seconds.
Expand Down Expand Up @@ -633,20 +633,6 @@ The callback will be invoked with three arguments:

The `'pathValidation'` event will be emitted multiple times.

#### Event: `'qlog'`
<!-- YAML
added: REPLACEME
-->

* `jsonChunk` {string} A JSON fragment.

Emitted if the `qlog: true` option was passed to `quicsocket.connect()` or
`net.createQuicSocket()` functions.

The argument is a JSON fragment according to the [qlog standard][].

The `'qlog'` event will be emitted multiple times.

#### Event: `'secure'`
<!-- YAML
added: REPLACEME
Expand Down Expand Up @@ -1044,6 +1030,19 @@ added: REPLACEME
A `BigInt` representing the total number of `QuicStreams` initiated by the
connected peer.

#### quicsession.qlog
<!-- YAML
added: REPLACEME
-->

* Type: {stream.Readable}

If `qlog` support is enabled for `QuicSession`, the `quicsession.qlog` property
provides a [`stream.Readable`][] that may be used to access the `qlog` event
data according to the [qlog standard][]. For client `QuicSessions`, the
`quicsession.qlog` property will be `undefined` untilt the `'qlog'` event
is emitted.

#### quicsession.remoteAddress
<!-- YAML
added: REPLACEME
Expand Down Expand Up @@ -1183,6 +1182,17 @@ The `sessionTicket` and `remoteTransportParams` are useful when creating a new

The `'sessionTicket'` event may be emitted multiple times.

#### Event: `'qlog'`
<!-- YAML
added: REPLACEME
-->

The `'qlog'` event is emitted when the `QuicClientSession` is ready to begin
providing `qlog` event data. The callback is invoked with a single argument:

* `qlog` {stream.Readable} A [`stream.Readable`][] that is also available using
the `quicsession.qlog` property.

#### Event: `'usePreferredAddress'`
<!-- YAML
added: REPLACEME
Expand Down Expand Up @@ -1573,7 +1583,7 @@ added: REPLACEME
transport parameters from a previously established session. These would
have been provided as part of the `'sessionTicket'` event on a previous
`QuicClientSession` object.
* `qlog` {boolean} Whether to emit ['qlog'][] events for this session.
* `qlog` {boolean} Whether to enable ['qlog'][] for this session.
Default: `false`.
* `requestOCSP` {boolean} If `true`, specifies that the OCSP status request
extension will be added to the client hello and an `'OCSPResponse'` event
Expand Down Expand Up @@ -2278,6 +2288,7 @@ added: REPLACEME
Set to `true` if the `QuicStream` is unidirectional.

[`crypto.getCurves()`]: crypto.html#crypto_crypto_getcurves
[`stream.Readable`]: #stream_class_stream_readable
[`tls.DEFAULT_ECDH_CURVE`]: #tls_tls_default_ecdh_curve
[`tls.getCiphers()`]: tls.html#tls_tls_getciphers
[ALPN]: https://tools.ietf.org/html/rfc7301
Expand All @@ -2286,5 +2297,5 @@ Set to `true` if the `QuicStream` is unidirectional.
[modifying the default cipher suite]: tls.html#tls_modifying_the_default_tls_cipher_suite
[OpenSSL Options]: crypto.html#crypto_openssl_options
[Perfect Forward Secrecy]: #tls_perfect_forward_secrecy
['qlog']: #quic_event_qlog
['qlog']: #quic_quicsession_qlog
[qlog standard]: https://tools.ietf.org/id/draft-marx-qlog-event-definitions-quic-h3-00.html
6 changes: 3 additions & 3 deletions doc/changelogs/CHANGELOG_ARCHIVE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3130,8 +3130,8 @@ https://github.com/nodejs/node/commit/bb0d1e65e1671aaeb21fac186b066701da0bc33b

* Major API Changes
* Promises removed. See
http://groups.google.com/group/nodejs/msg/426f3071f3eec16b
http://groups.google.com/group/nodejs/msg/df199d233ff17efa
https://groups.google.com/group/nodejs/msg/426f3071f3eec16b
https://groups.google.com/group/nodejs/msg/df199d233ff17efa
The API for fs was
fs.readdir("/usr").addCallback(function (files) {
puts("/usr files: " + files);
Expand Down Expand Up @@ -3718,7 +3718,7 @@ https://github.com/nodejs/node/commit/77d407df2826b20e9177c26c0d2bb4481e497937
* Move EventEmitter.prototype.emit() completely into C++.

* Bugfix: Fix memory leak in event emitters.
http://groups.google.com/group/nodejs/browse_thread/thread/a8d1dfc2fd57a6d1
https://groups.google.com/group/nodejs/browse_thread/thread/a8d1dfc2fd57a6d1

* Bugfix: Had problems reading scripts with non-ascii characters.
* Bugfix: Fix Detach() in node::Server
Expand Down
2 changes: 1 addition & 1 deletion doc/changelogs/CHANGELOG_IOJS.md
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ See https://github.com/nodejs/io.js/labels/confirmed-bug for complete and curren
* **dgram**: If an error occurs within `socket.send()` and a callback has been provided, the error is only passed as the first argument to the callback and not emitted on the `socket` object; previous behavior was to do both (Matteo Collina & Chris Dickinson) [#1796](https://github.com/nodejs/node/pull/1796)
* **freelist**: Deprecate the undocumented `freelist` core module (Sakthipriyan Vairamani) [#2176](https://github.com/nodejs/node/pull/2176).
* **http**:
* Status codes now all use the official [IANA names](http://www.iana.org/assignments/http-status-codes) as per [RFC7231](https://tools.ietf.org/html/rfc7231), e.g. `http.STATUS_CODES[414]` now returns `'URI Too Long'` rather than `'Request-URI Too Large'` (jomo) [#1470](https://github.com/nodejs/node/pull/1470).
* Status codes now all use the official [IANA names](https://www.iana.org/assignments/http-status-codes) as per [RFC7231](https://tools.ietf.org/html/rfc7231), e.g. `http.STATUS_CODES[414]` now returns `'URI Too Long'` rather than `'Request-URI Too Large'` (jomo) [#1470](https://github.com/nodejs/node/pull/1470).
* Calling .getName() on an HTTP agent no longer returns a trailing colon, HTTPS agents will no longer return an extra colon near the middle of the string (Brendan Ashworth) [#1617](https://github.com/nodejs/node/pull/1617).
* **node**:
* `NODE_MODULE_VERSION` has been bumped to `45` to reflect the break in ABI (Rod Vagg) [#2096](https://github.com/nodejs/node/pull/2096).
Expand Down
Loading