PR-URL: nodejs#34160
Reviewed-By: Anna Henningsen <[email protected]>

Use is_* and set_* pattern for native object flags to improve
readability in the code.

PR-URL: nodejs#34160
Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: nodejs#34160
Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: nodejs#34160
Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: nodejs#34160
Reviewed-By: Anna Henningsen <[email protected]>

The QuicSession can be destroyed during garbage collection and
the onSessionDestroy callback was happening in the destructor.

PR-URL: nodejs#34160
Reviewed-By: Anna Henningsen <[email protected]>

Because of the timing of qlog events emitted by ngtcp2, it
becomes difficult to handle those as events on the QuicSession
object because the final qlog entry is not emitted until the
ngtcp2_conn is freed, which can occur when the object is being
garbage collected (meaning, we a: can't call out to javascript
and b: don't have an object we can use to emit the event).

This refactors it into a QLogStream object that allows the
qlog data to be piped out using a separate Readable stream.

PR-URL: nodejs#34160
Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: nodejs#34160
Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: nodejs#34160
Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: nodejs#34160
Reviewed-By: Anna Henningsen <[email protected]>

Alternative to nodejs#33841

Co-authored-by: zombieleet <[email protected]>

PR-URL: nodejs#34188
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

Consolidate uv_timer_t boilerplate code into a shared utility.
There are several places throughout the code where we use uv_timer_t
internally (inspector, perf, quic), with some code duplication.
This eliminates the duplicated code, ensures that cleanup occurs
correctly, and simplifies use of the timers.

Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#34186
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>

Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#34186
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>

Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#34186
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>

Asked Gibson in email if he should be moved to emeritus and he indicated
it was a good idea.

PR-URL: nodejs#34190
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>

Had an email exchange with Hitesh where he indicated that it was a fine
time to move him to emeritus.

PR-URL: nodejs#34191
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>

ERR_FEATURE_UNAVAILABLE_ON_PLATFORM is incorrectly included in the list
of errors that have never been released. It was added in
67e067e and included in every release
in the 14.x line.

PR-URL: nodejs#34196
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>

C++ linter fails because of unused ArrayBuffer namespace member

PR-URL: nodejs#34212
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: nodejs#34167
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: David Carlier <[email protected]>

PR-URL: nodejs#34198
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>

test-repl-history-navigation fails with NODE_PENDING_DEPRECATION=1.
Replace deprecated repl.inputStream with repl.input.

PR-URL: nodejs#34199
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Refs: nodejs#33764 (comment)

PR-URL: nodejs#34197
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>

PR-URL: nodejs#34158
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>

PR-URL: nodejs#34158
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>

The test is marked flaky on ARM because it times out on Raspberry Pi
devices in CI. Split the single test file into four separate test files
to ease debugging. Add fs.close() to avoid timing out.

Fixes: nodejs#33796

PR-URL: nodejs#34203
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>