timers: reuse timer in `setTimeout().unref()` #3407

indutny · 2015-10-16T19:35:55Z

Instead of creating new timer - reuse the timer from the freelist. This
won't make the freelist timer active for the duration of uv_close(),
and will let the event-loop exit properly.

Fix: #1264

R=@trevnorris @Fishrock123

Instead of creating new timer - reuse the timer from the freelist. This won't make the freelist timer active for the duration of `uv_close()`, and will let the event-loop exit properly. Fix: nodejs#1264

trevnorris · 2015-10-16T19:39:14Z

LGTM

May want @bnoordhuis to take a quick look?

indutny · 2015-10-16T19:40:32Z

Sure.

indutny · 2015-10-16T19:41:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/526/

indutny · 2015-10-16T19:54:57Z

Looks like CI is green.

Fishrock123 · 2015-10-16T20:18:57Z

I'd like to take a look at this later before it lands. ✈️ Right now.

MylesBorins · 2015-10-16T20:45:44Z

Is this something that could be merged into LTS?

Seems like it might be but perhaps I'm missing some subtlety
@jasnell

indutny · 2015-10-16T22:09:22Z

I think we may want to have it in LTS, indeed.

Fishrock123 · 2015-10-19T13:43:42Z

Will take a look today.

Fishrock123 · 2015-10-19T14:29:50Z

Hmmm, I think this underlines a problem with how beforeExit works, not timers. I think this is just circumventing the issue.

indutny · 2015-10-19T15:56:54Z

@Fishrock123 I would say a problem with how beforeExit is documented, as is supposed to work. We should definitely look into fixing some stuff at libuv level, once @saghul will be back.

This is fix should be enough for now to handle the edge case between windows/unix.

Fishrock123 · 2015-10-20T17:55:14Z

@indutny if I am understanding this properly, the problem is that the original list handle registers as active during the event loop where it is first closed. Is that correct?

If so, is there any disadvantage to unrefing the original handle instead of this in that case?

trevnorris · 2015-10-20T18:08:10Z

@Fishrock123 Then you'd have to check if the handle has any ref'd timers remaining. Accomplishing most of what this patch does. Difference is this one saves an allocation.

indutny · 2015-10-20T18:15:33Z

@Fishrock123 it won't help to unref it after closing, because libuv checks for CLOSING flag before decrementing the active handle count.

Fishrock123 · 2015-10-20T18:17:17Z

LGTM I suppose, but I don't understand how this actually makes a difference.

indutny · 2015-10-20T18:19:41Z

@Fishrock123 uv_close makes timer active on windows, this adds extra beforeExit. With this commit, we won't close the handle, and will instead reuse it.

indutny · 2015-10-20T18:28:07Z

Landed in 3eecdf9, thank you!

Instead of creating new timer - reuse the timer from the freelist. This won't make the freelist timer active for the duration of `uv_close()`, and will let the event-loop exit properly. Fix: #1264 PR-URL: #3407 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>

jasnell · 2015-10-28T15:28:06Z

Landed in v4.x-staging in 40bb802

Notable changes: * buffer: (Breaking) Removed both 'raw' and 'raws' encoding types from Buffer, these have been deprecated for a long time (Sakthipriyan Vairamani) nodejs#2859. * console: (Breaking) Values reported by console.time() now have 3 decimals of accuracy added (Michaël Zasso) nodejs#3166. * fs: - fs.readFile*(), fs.writeFile*(), and fs.appendFile*() now also accept a file descriptor as their first argument (Johannes Wüller) nodejs#3163. - (Breaking) In fs.readFile(), if an encoding is specified and the internal toString() fails the error is no longer thrown but is passed to the callback (Evan Lucas) nodejs#3485. - (Breaking) In fs.read() (using the fs.read(fd, length, position, encoding, callback) form), if the internal toString() fails the error is no longer thrown but is passed to the callback (Evan Lucas) nodejs#3503. * http: - Fixed a bug where pipelined http requests would stall (Fedor Indutny) nodejs#3342. - (Breaking) When parsing HTTP, don't add duplicates of the following headers: Retry-After, ETag, Last-Modified, Server, Age, Expires. This is in addition to the following headers which already block duplicates: Content-Type, Content-Length, User-Agent, Referer, Host, Authorization, Proxy-Authorization, If-Modified-Since, If-Unmodified-Since, From, Location, Max-Forwards (James M Snell) nodejs#3090. - (Breaking) The callback argument to OutgoingMessage#setTimeout() must be a function or a TypeError is thrown (James M Snell) nodejs#3090. - (Breaking) HTTP methods and header names must now conform to the RFC 2616 "token" rule, a list of allowed characters that excludes control characters and a number of separator characters. Specifically, methods and header names must now match /^[a-zA-Z0-9_!#$%&'*+.^`|~-]+$/ or a TypeError will be thrown (James M Snell) nodejs#2526. * node: - (Breaking) Deprecated the _linklist module (Rich Trott) nodejs#3078. - (Breaking) Removed require.paths and require.registerExtension(), both had been previously set to throw Error when accessed (Sakthipriyan Vairamani) nodejs#2922. * npm: Upgraded to version 3.3.6 from 2.14.7, see https://github.com/npm/npm/releases/tag/v3.3.6 for more details. This is a major version bump for npm and it has seen a significant amount of change. Please see the original npm v3.0.0 release notes for a list of major changes (Rebecca Turner) nodejs#3310. * src: (Breaking) Bumped NODE_MODULE_VERSION to 47 from 46, this is necessary due to the V8 upgrade. Native add-ons will need to be recompiled (Rod Vagg) nodejs#3400. * timers: Attempt to reuse the timer handle for setTimeout().unref(). This fixes a long-standing known issue where unrefed timers would perviously hold beforeExit open (Fedor Indutny) nodejs#3407. * tls: - Added ALPN Support (Shigeki Ohtsu) nodejs#2564. - TLS options can now be passed in an object to createSecurePair() (Коренберг Марк) nodejs#2441. - (Breaking) The default minimum DH key size for tls.connect() is now 1024 bits and a warning is shown when DH key size is less than 2048 bits. This a security consideration to prevent "logjam" attacks. A new minDHSize TLS option can be used to override the default. (Shigeki Ohtsu) nodejs#1831. * util: - (Breaking) util.p() was deprecated for years, and has now been removed (Wyatt Preul) nodejs#3432. - (Breaking) util.inherits() can now work with ES6 classes. This is considered a breaking change because of potential subtle side-effects caused by a change from directly reassigning the prototype of the constructor using `ctor.prototype = Object.create(superCtor.prototype, { constructor: { ... } })` to using `Object.setPrototypeOf(ctor.prototype, superCtor.prototype)` (Michaël Zasso) nodejs#3455. * v8: (Breaking) Upgraded to 4.6.85.25 from 4.5.103.35 (Ali Ijaz Sheikh) nodejs#3351. - Implements the spread operator, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operator for further information. - Implements new.target, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target for further information. * zlib: Decompression now throws on truncated input (e.g. unexpected end of file) (Yuval Brik) nodejs#2595. PR-URL: nodejs#3466

Instead of creating new timer - reuse the timer from the freelist. This won't make the freelist timer active for the duration of `uv_close()`, and will let the event-loop exit properly. Fix: #1264 PR-URL: #3407 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>

Notable changes: * buffer: (Breaking) Removed both 'raw' and 'raws' encoding types from Buffer, these have been deprecated for a long time (Sakthipriyan Vairamani) #2859. * console: (Breaking) Values reported by console.time() now have 3 decimals of accuracy added (Michaël Zasso) #3166. * fs: - fs.readFile*(), fs.writeFile*(), and fs.appendFile*() now also accept a file descriptor as their first argument (Johannes Wüller) #3163. - (Breaking) In fs.readFile(), if an encoding is specified and the internal toString() fails the error is no longer thrown but is passed to the callback (Evan Lucas) #3485. - (Breaking) In fs.read() (using the fs.read(fd, length, position, encoding, callback) form), if the internal toString() fails the error is no longer thrown but is passed to the callback (Evan Lucas) #3503. * http: - Fixed a bug where pipelined http requests would stall (Fedor Indutny) #3342. - (Breaking) When parsing HTTP, don't add duplicates of the following headers: Retry-After, ETag, Last-Modified, Server, Age, Expires. This is in addition to the following headers which already block duplicates: Content-Type, Content-Length, User-Agent, Referer, Host, Authorization, Proxy-Authorization, If-Modified-Since, If-Unmodified-Since, From, Location, Max-Forwards (James M Snell) #3090. - (Breaking) The callback argument to OutgoingMessage#setTimeout() must be a function or a TypeError is thrown (James M Snell) #3090. - (Breaking) HTTP methods and header names must now conform to the RFC 2616 "token" rule, a list of allowed characters that excludes control characters and a number of separator characters. Specifically, methods and header names must now match /^[a-zA-Z0-9_!#$%&'*+.^`|~-]+$/ or a TypeError will be thrown (James M Snell) #2526. * node: - (Breaking) Deprecated the _linklist module (Rich Trott) #3078. - (Breaking) Removed require.paths and require.registerExtension(), both had been previously set to throw Error when accessed (Sakthipriyan Vairamani) #2922. * npm: Upgraded to version 3.3.6 from 2.14.7, see https://github.com/npm/npm/releases/tag/v3.3.6 for more details. This is a major version bump for npm and it has seen a significant amount of change. Please see the original npm v3.0.0 release notes for a list of major changes (Rebecca Turner) #3310. * src: (Breaking) Bumped NODE_MODULE_VERSION to 47 from 46, this is necessary due to the V8 upgrade. Native add-ons will need to be recompiled (Rod Vagg) #3400. * timers: Attempt to reuse the timer handle for setTimeout().unref(). This fixes a long-standing known issue where unrefed timers would perviously hold beforeExit open (Fedor Indutny) #3407. * tls: - Added ALPN Support (Shigeki Ohtsu) #2564. - TLS options can now be passed in an object to createSecurePair() (Коренберг Марк) #2441. - (Breaking) The default minimum DH key size for tls.connect() is now 1024 bits and a warning is shown when DH key size is less than 2048 bits. This a security consideration to prevent "logjam" attacks. A new minDHSize TLS option can be used to override the default. (Shigeki Ohtsu) #1831. * util: - (Breaking) util.p() was deprecated for years, and has now been removed (Wyatt Preul) #3432. - (Breaking) util.inherits() can now work with ES6 classes. This is considered a breaking change because of potential subtle side-effects caused by a change from directly reassigning the prototype of the constructor using `ctor.prototype = Object.create(superCtor.prototype, { constructor: { ... } })` to using `Object.setPrototypeOf(ctor.prototype, superCtor.prototype)` (Michaël Zasso) #3455. * v8: (Breaking) Upgraded to 4.6.85.25 from 4.5.103.35 (Ali Ijaz Sheikh) #3351. - Implements the spread operator, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operator for further information. - Implements new.target, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target for further information. * zlib: Decompression now throws on truncated input (e.g. unexpected end of file) (Yuval Brik) #2595. PR-URL: #3466

saghul · 2015-11-04T20:27:42Z

@Fishrock123 I would say a problem with how beforeExit is documented, as is supposed to work. We should definitely look into fixing some stuff at libuv level, once @saghul will be back.

This is fix should be enough for now to handle the edge case between windows/unix.

@indutny I'm back! Can you open an issue at libuv/libuv please? Bonus points for a test which passes on Unix and fails on Windows :-)

The timer handle is reused when it is unrefed in order to avoid new callback in beforeExit(nodejs#3407). If it is unrefed within a setInterval callback, the reused timer handle is closed so that setInterval no longer keep working. This fix does not close the handle in case of setInterval.

The timer handle is reused when it is unrefed in order to avoid new callback in beforeExit(#3407). If it is unrefed within a setInterval callback, the reused timer handle is closed so that setInterval no longer keep working. This fix does not close the handle in case of setInterval. PR-URL: #11646 Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>

timers: reuse timer in setTimeout().unref()

fb932ba

Instead of creating new timer - reuse the timer from the freelist. This won't make the freelist timer active for the duration of `uv_close()`, and will let the event-loop exit properly. Fix: nodejs#1264

trevnorris added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Oct 16, 2015

jasnell added the lts-watch-v4.x label Oct 16, 2015

indutny closed this Oct 20, 2015

indutny deleted the fix/gh-1264 branch October 20, 2015 18:28

rvagg mentioned this pull request Oct 21, 2015

Release proposal: v5.0.0 #3466

Merged

Fishrock123 added land-on-v4.x and removed lts-watch-v4.x labels Oct 21, 2015

rvagg mentioned this pull request Oct 28, 2015

Preparing v4.2.2 LTS Maintenance nodejs/Release#50

Closed

jasnell added the lts-watch-v4.x label Oct 28, 2015

jasnell removed the lts-watch-v4.x label Oct 28, 2015

jasnell mentioned this pull request Oct 29, 2015

Release Proposal: v4.2.2 "Argon" (LTS) #3588

Closed

jasnell removed the land-on-v4.x label Nov 3, 2015

Fishrock123 mentioned this pull request Nov 4, 2015

Revisit unrefed handles and beforeExit internals #3665

Closed

zhangzifa mentioned this pull request Dec 21, 2015

timer: make sure timer is cleared #4303

Closed

shigeki mentioned this pull request Mar 2, 2017

timers: fix not to close reused timer handle #11646

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

timers: reuse timer in `setTimeout().unref()` #3407

timers: reuse timer in `setTimeout().unref()` #3407

indutny commented Oct 16, 2015

trevnorris commented Oct 16, 2015

indutny commented Oct 16, 2015

indutny commented Oct 16, 2015

indutny commented Oct 16, 2015

Fishrock123 commented Oct 16, 2015

MylesBorins commented Oct 16, 2015

indutny commented Oct 16, 2015

Fishrock123 commented Oct 19, 2015

Fishrock123 commented Oct 19, 2015

indutny commented Oct 19, 2015

Fishrock123 commented Oct 20, 2015

trevnorris commented Oct 20, 2015

indutny commented Oct 20, 2015

Fishrock123 commented Oct 20, 2015

indutny commented Oct 20, 2015

indutny commented Oct 20, 2015

jasnell commented Oct 28, 2015

saghul commented Nov 4, 2015

timers: reuse timer in setTimeout().unref() #3407

timers: reuse timer in setTimeout().unref() #3407

Conversation

indutny commented Oct 16, 2015

trevnorris commented Oct 16, 2015

indutny commented Oct 16, 2015

indutny commented Oct 16, 2015

indutny commented Oct 16, 2015

Fishrock123 commented Oct 16, 2015

MylesBorins commented Oct 16, 2015

indutny commented Oct 16, 2015

Fishrock123 commented Oct 19, 2015

Fishrock123 commented Oct 19, 2015

indutny commented Oct 19, 2015

Fishrock123 commented Oct 20, 2015

trevnorris commented Oct 20, 2015

indutny commented Oct 20, 2015

Fishrock123 commented Oct 20, 2015

indutny commented Oct 20, 2015

indutny commented Oct 20, 2015

jasnell commented Oct 28, 2015

saghul commented Nov 4, 2015

timers: reuse timer in `setTimeout().unref()` #3407

timers: reuse timer in `setTimeout().unref()` #3407