http: fix stalled pipeline bug #3342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test may be failing on windows, because it is a bit CPU intensive. |
|
Going to sleep now, will reply to all comments tomorrow. |
| @@ -663,6 +663,9 @@ OutgoingMessage.prototype._flush = function() { | |||
| this.output = []; | |||
| this.outputEncodings = []; | |||
| this.outputCallbacks = []; | |||
| if (this._onPendingData !== null) | |||
There was a problem hiding this comment.
Wouldn't a better check be if (typeof this._onPendingData === 'function')?
There was a problem hiding this comment.
I'll move the checks together and replaced it with typeof, thanks
|
Pushed one fix, any other comments? |
|
LGTM assuming CI is green |
jasnell
added a commit
that referenced
this pull request
Oct 13, 2015
jasnell
added a commit
that referenced
this pull request
Oct 13, 2015
jasnell
added a commit
that referenced
this pull request
Oct 13, 2015
The "too" at the end makes me feel like there's more to the sentence. |
| @@ -135,7 +135,7 @@ OutgoingMessage.prototype._send = function(data, encoding, callback) { | |||
| this.outputEncodings.unshift('binary'); | |||
| this.outputCallbacks.unshift(null); | |||
| this.outputSize += this._header.length; | |||
| if (this._onPendingData !== null) | |||
| if (typeof this._onPendingData === 'function') | |||
There was a problem hiding this comment.
Is checking for typeof function part of a fix, or different cleanup?
|
LGTM |
|
Thanks @trevnorris . I'm working on fixing the test on Windows. For some reason it fails with EALREADY |
|
CI Issues:
|
| this.outputCallbacks = []; | ||
| if (typeof this._onPendingData === 'function') | ||
| this._onPendingData(-this.outputSize); | ||
| this.outputSize = 0; |
There was a problem hiding this comment.
This part is in OutgoingMessage#_writeRaw() but not in OutgoingMessage#_finish(). Is this already addressed in the git commit message? Don't see any direct reference to why this is necessary for the fix.
There was a problem hiding this comment.
I think it is used there too.
|
Overall LGTM but have a few questions. |
| @@ -644,26 +629,11 @@ OutgoingMessage.prototype._finish = function() { | |||
| // to attempt to flush any pending messages out to the socket. | |||
| OutgoingMessage.prototype._flush = function() { | |||
rvagg
added a commit
that referenced
this pull request
Oct 29, 2015
Notable changes: * buffer: (Breaking) Removed both 'raw' and 'raws' encoding types from Buffer, these have been deprecated for a long time (Sakthipriyan Vairamani) #2859. * console: (Breaking) Values reported by console.time() now have 3 decimals of accuracy added (Michaël Zasso) #3166. * fs: - fs.readFile*(), fs.writeFile*(), and fs.appendFile*() now also accept a file descriptor as their first argument (Johannes Wüller) #3163. - (Breaking) In fs.readFile(), if an encoding is specified and the internal toString() fails the error is no longer thrown but is passed to the callback (Evan Lucas) #3485. - (Breaking) In fs.read() (using the fs.read(fd, length, position, encoding, callback) form), if the internal toString() fails the error is no longer thrown but is passed to the callback (Evan Lucas) #3503. * http: - Fixed a bug where pipelined http requests would stall (Fedor Indutny) #3342. - (Breaking) When parsing HTTP, don't add duplicates of the following headers: Retry-After, ETag, Last-Modified, Server, Age, Expires. This is in addition to the following headers which already block duplicates: Content-Type, Content-Length, User-Agent, Referer, Host, Authorization, Proxy-Authorization, If-Modified-Since, If-Unmodified-Since, From, Location, Max-Forwards (James M Snell) #3090. - (Breaking) The callback argument to OutgoingMessage#setTimeout() must be a function or a TypeError is thrown (James M Snell) #3090. - (Breaking) HTTP methods and header names must now conform to the RFC 2616 "token" rule, a list of allowed characters that excludes control characters and a number of separator characters. Specifically, methods and header names must now match /^[a-zA-Z0-9_!#$%&'*+.^`|~-]+$/ or a TypeError will be thrown (James M Snell) #2526. * node: - (Breaking) Deprecated the _linklist module (Rich Trott) #3078. - (Breaking) Removed require.paths and require.registerExtension(), both had been previously set to throw Error when accessed (Sakthipriyan Vairamani) #2922. * npm: Upgraded to version 3.3.6 from 2.14.7, see https://github.com/npm/npm/releases/tag/v3.3.6 for more details. This is a major version bump for npm and it has seen a significant amount of change. Please see the original npm v3.0.0 release notes for a list of major changes (Rebecca Turner) #3310. * src: (Breaking) Bumped NODE_MODULE_VERSION to 47 from 46, this is necessary due to the V8 upgrade. Native add-ons will need to be recompiled (Rod Vagg) #3400. * timers: Attempt to reuse the timer handle for setTimeout().unref(). This fixes a long-standing known issue where unrefed timers would perviously hold beforeExit open (Fedor Indutny) #3407. * tls: - Added ALPN Support (Shigeki Ohtsu) #2564. - TLS options can now be passed in an object to createSecurePair() (Коренберг Марк) #2441. - (Breaking) The default minimum DH key size for tls.connect() is now 1024 bits and a warning is shown when DH key size is less than 2048 bits. This a security consideration to prevent "logjam" attacks. A new minDHSize TLS option can be used to override the default. (Shigeki Ohtsu) #1831. * util: - (Breaking) util.p() was deprecated for years, and has now been removed (Wyatt Preul) #3432. - (Breaking) util.inherits() can now work with ES6 classes. This is considered a breaking change because of potential subtle side-effects caused by a change from directly reassigning the prototype of the constructor using `ctor.prototype = Object.create(superCtor.prototype, { constructor: { ... } })` to using `Object.setPrototypeOf(ctor.prototype, superCtor.prototype)` (Michaël Zasso) #3455. * v8: (Breaking) Upgraded to 4.6.85.25 from 4.5.103.35 (Ali Ijaz Sheikh) #3351. - Implements the spread operator, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operator for further information. - Implements new.target, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target for further information. * zlib: Decompression now throws on truncated input (e.g. unexpected end of file) (Yuval Brik) #2595. PR-URL: #3466
This was referenced Feb 20, 2022
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a two-part fix:
OutgoingMessageto notify serverabout flushed data too
unconsumesocket from http parser on pause, to prevent parser fromreporting
PAUSEDerror. Previously, nodataevents were emittedafter
socket.pause()call. Now with all things happening in C++,socket.pause()has no effect on internal socket while it isconsumed. Switching to old mode is enough for now, we should revisit
it somewhere later.
Fix: #3332
R=@bnoordhuis @jasnell @trevnorris
cc @nodejs/collaborators