Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x backport] Openssl 1.1.1e #32443

Closed
wants to merge 4 commits into from
Closed

[v10.x backport] Openssl 1.1.1e #32443

wants to merge 4 commits into from

Commits on Mar 23, 2020

  1. deps: upgrade openssl sources to 1.1.1e 

    This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1e.tar.gz
    $ mv openssl-1.1.1e openssl
    $ git add --all openssl
    $ git commit openssl

PR-URL: nodejs#32328
Fixes: nodejs#32210
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @hassaanp @sam-github
    hassaanp authored and sam-github committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    57c612c View commit details
    Browse the repository at this point in the history

  2. deps: adjust openssl configuration for 1.1.1e 

    The scripts used by make were modified to correctly reference the source
files that were originially in crypto/include/internal, but got moved to
include/crypto.  The base path has been left unaltered since that would
require too many changes

PR-URL: nodejs#32328
Fixes: nodejs#32210
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @hassaanp @sam-github
    hassaanp authored and sam-github committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    ef124fb View commit details
    Browse the repository at this point in the history

  3. deps: update archs files for OpenSSL-1.1.1e 

    After an OpenSSL source update, all the config files need to be
regenerated and comitted by:
    $ cd deps/openssl/config
    $ make
    $ git add deps/openssl/config/archs
    $ git add deps/openssl/include

PR-URL: nodejs#32328
Fixes: nodejs#32210
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @hassaanp @sam-github
    hassaanp authored and sam-github committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    ee5ac40 View commit details
    Browse the repository at this point in the history

  4. test: end tls connection with some data 

    In openssl-1.1.1e the client doesn't seem to like having the TLS
connection shut down with no data sent, so send an empty string. A
number of related issues showed up in the TLS1.3 port, so this is
not entirely surprising.

PR-URL: nodejs#32328
Fixes: nodejs#32210
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @sam-github
    sam-github committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    647cdb9 View commit details
    Browse the repository at this point in the history