deps: update openssl to 1.1.1e

[hassaanp]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Fixes: #32210

[sam-github]

Thanks! This needs a few things:

1. Can you rebase this against master? It seems to be branched from a week ago.
2. Can you please follow the directions in doc/guides/maintaining-openssl.md, specifically with respect to the commit messages?
3. When you do the above, you'll see that the commits with contents that are large but essentially machine generated have clear commit messages describing how they were made, and don't mix hand-written and auto-generated content. This makes it possible to review and approve them without reading the contents, because its clear how the content was created. Please split your updates to the configure scripts into a standalone commit, it should be after the sources update, and before the output of the configure process.

EDIT: And just a note, this branch should be force-pushed after being updated (sometimes people close PRs and open new ones if they are not so familiar with github or git, but we prefer that not be done).

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29900/

[hassaanp]

1. Can you rebase this against master? It seems to be branched from a week ago.

Rebased, and pushed.

2. Can you please follow the directions in doc/guides/maintaining-openssl.md, specifically with respect to the commit messages?

Done. The original second commit where I was modifying the scripts has been split and commit messages have been appropriately rewritten according to the guide.

3. When you do the above, you'll see that the commits with contents that are large but essentially machine generated have clear commit messages describing how they were made, and don't mix hand-written and auto-generated content. This makes it possible to review and approve them without reading the contents, because its clear how the content was created. Please split your updates to the configure scripts into a standalone commit, it should be after the sources update, and before the output of the configure process.

I have split my configuration updates to a separate commit: deps: revised paths in scripts to reflect openssl version 1.1.1e

[sam-github]

You didn't rebase, you merged master into your local branch. Next time, do git rebase upstream/master && git push --force-with-lease (assuming you are using recommended setup of calling the nodejs/node remote upstream).

I would clean this up for you and force push, but it looks like you deselected that permission for me.

If you look at the top of this PR, you'll see it has 47 commits in it! That's not right. Because of the multiple merging from master into your branch, you'd best do an interactive rebase:

git fetch --all --prune
git rebase -i upstream/master

In the interactive, delete all the lines that are commits that you did not write. There should be only three. Also, reorder them. After, the commits will look like:

core/tls (deps/update-openssl-to-1.1.1e u+5-47) % git log upstream/master..HEAD
commit ea0429b510d1028584b6cf2da0b8e4a4067e7ac1 (HEAD -> deps/update-openssl-to-1.1.1e, pr/32328)
Author: Hassaan Pasha <[email protected]>
Date:   Wed Mar 18 10:09:37 2020 +0500

    deps: update archs files for OpenSSL-1.1.1e
    
    After an OpenSSL source update, all the config files need to be regenerated and
     comitted by:
        $ cd deps/openssl/config
        $ make
        $ git add deps/openssl/config/archs
        $ git add deps/openssl/include

commit 9c4ff6bc9179b7d938c8441b18c901710cfdb490
Author: Hassaan Pasha <[email protected]>
Date:   Wed Mar 18 10:17:22 2020 +0500

    deps: revised paths in scripts to reflect openssl version 1.1.1e
    
    the scripts used by make were modified to correctly reference
    the source files that were originially in crypto/include/internal
    these files are not residing in include/crypto. The base path has
    been left unaltered since that would require too many changes
    
    comitted by:
        $ git add deps/config/Makefile*
        $ git add deps/config/generate_gypi.pl
        $ git add deps/openssl/openssl/Makefile
        $ git add deps/openssl/openssl/configdata.pm
        $ git commit

commit 4e0ad52ddec2bda9b2144fcb89ec4d6e0a9732ab
Author: Hassaan Pasha <[email protected]>
Date:   Tue Mar 17 22:14:56 2020 +0500

    deps: upgrade openssl sources to 1.1.1e

Note that last commit doesn't match the format in the guide: https://github.com/nodejs/node/blob/master/doc/guides/maintaining-openssl.md#1-obtain-and-extract-new-openssl-sources

We aren't normally this nitpicky, but the openssl maintenance should match the guide, feel free to kick this back to me and/or give me write permissions on your branch if you'd like me to do the rebasing.

[ExE-Boss]

You didn't rebase, you merged master into your local branch.

If that was what was done, then there would only be a merge commit.

What instead happened was that master was rebased on top of this PR.

[hassaanp]

@sam-github acknowledged.
I will follow your suggestions.
I am also going to give you write access incase I am unable to sort this.
Thank you for your patience.

[sam-github]

Cleaned up and repushed.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29913/

[sam-github]

OK, needs one more commit to (at least) fix test.sequential/test-tls-psk-client?

https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_zlib_x64/18781/

[hassaanp]

@sam-github thanks for the help
Looking at the test now.

[hassaanp]

@sam-github, I have fixed the test but the behavior displayed is a little awkward.
The socket end event is not fired until the data event is consumed. I hope I am explaining this correctly. Pushing the code, hopefully that would make more sense.

[hassaanp]

I have pushed the code. Kindly review.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29925/

[kapouer]

Building 10.19.0 against shared openssl 1.1.1d i got an odd situation because tests ran against openssl 1.1.1e, and only one js test is failing: parallel/test-tls-session-cache (ppc64el but i'm not sure it's a problem with the arch in itself):
https://buildd.debian.org/status/fetch.php?pkg=nodejs&arch=ppc64el&ver=10.19.0~dfsg-2&stamp=1584648000&raw=0

[MylesBorins]

Still seeing lots of failures in CI on this. Would be very good for us to include this in the various releases that we have targeting next tuesday. Do folks need help with moving this forward so we can meet that timeline? We likely need backport PRs to test each release line

[sam-github]

Pushed a fix for test/parallel/test-tls-session-cache.js