build: add GitHub actions to run linters #31323

richardlau · 2020-01-12T01:12:03Z

Add jobs to our GitHub Actions workflow to run our various lint Makefile
targets. The setup-node action used to run the JavaScript linter contains
problem matchers for eslint that will annotate the files in a pull request if
there are failures.

The Python linting has been left out as I believe it's being included as part of
#29474.

See https://github.com/richardlau/node-1/pull/3/files for an example of the
annotations for lint-js failures.

We may be able to create problem matchers for the cpplint.py and markdown
linters in the future based on
https://github.com/actions/toolkit/blob/master/docs/problem-matchers.md.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Add jobs to our GitHub Actions workflow to run our various lint Makefile targets. The `setup-node` action used to run the JavaScript linter contains problem matchers for eslint that will annotate the files in a pull request if there are failures.

BridgeAR

Nice!

.github/workflows/CI.yml

The CI workflow doesn't use the matrix strategy so there is no `${{ matrix.node-version }}` variable to use in the `Use Node.js` step names.

targos · 2020-01-12T07:37:04Z

.github/workflows/CI.yml

+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v1
+      with:
+        node-version: 10.x


I suggest to use 12.x. It should be faster and will be supported for a longer time.

I deliberately went for the earliest in support version of Node.js on the basis that it would alert us if any of our tooling involved in the linting would break on it and thus help apply dont-land-on labels (with an assumption that its very unlikely that something would break on 12 but not 10).

As for speed the lint checks are completing in less than 2 minutes which is a fraction of the time taken to run the build jobs.

If we want to have such guarantees, we could even let it run on both versions?

Ideally in the long term when actions/setup-node#26 is addressed we can put an alias in here like lts if the concern is that the version here will eventually need to be updated.

Trott · 2020-01-14T04:54:44Z

Since this file is not exercised or even linted in Jenkins CI, green GitHub actions and Travis should be sufficient to land.

Trott · 2020-01-14T04:59:26Z

Landed in f4a4a1a...b772b9a

Add jobs to our GitHub Actions workflow to run our various lint Makefile targets. The `setup-node` action used to run the JavaScript linter contains problem matchers for eslint that will annotate the files in a pull request if there are failures. PR-URL: #31323 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

The CI workflow doesn't use the matrix strategy so there is no `${{ matrix.node-version }}` variable to use in the `Use Node.js` step names. PR-URL: #31323 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Add jobs to our GitHub Actions workflow to run our various lint Makefile targets. The `setup-node` action used to run the JavaScript linter contains problem matchers for eslint that will annotate the files in a pull request if there are failures. PR-URL: #31323 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

The CI workflow doesn't use the matrix strategy so there is no `${{ matrix.node-version }}` variable to use in the `Use Node.js` step names. PR-URL: #31323 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Add jobs to our GitHub Actions workflow to run our various lint Makefile targets. The `setup-node` action used to run the JavaScript linter contains problem matchers for eslint that will annotate the files in a pull request if there are failures. PR-URL: #31323 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

The CI workflow doesn't use the matrix strategy so there is no `${{ matrix.node-version }}` variable to use in the `Use Node.js` step names. PR-URL: #31323 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Add jobs to our GitHub Actions workflow to run our various lint Makefile targets. The `setup-node` action used to run the JavaScript linter contains problem matchers for eslint that will annotate the files in a pull request if there are failures. PR-URL: nodejs#31323 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

The CI workflow doesn't use the matrix strategy so there is no `${{ matrix.node-version }}` variable to use in the `Use Node.js` step names. PR-URL: nodejs#31323 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Add jobs to our GitHub Actions workflow to run our various lint Makefile targets. The `setup-node` action used to run the JavaScript linter contains problem matchers for eslint that will annotate the files in a pull request if there are failures. Backport-PR-URL: #32608 PR-URL: #31323 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

The CI workflow doesn't use the matrix strategy so there is no `${{ matrix.node-version }}` variable to use in the `Use Node.js` step names. Backport-PR-URL: #32608 PR-URL: #31323 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 12, 2020

richardlau added the build Issues and PRs related to build files or the CI. label Jan 12, 2020

BridgeAR approved these changes Jan 12, 2020

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 12, 2020

targos reviewed Jan 12, 2020

View reviewed changes

.github/workflows/CI.yml Outdated Show resolved Hide resolved

build: fix step name in GitHub Actions workflow

0033add

The CI workflow doesn't use the matrix strategy so there is no `${{ matrix.node-version }}` variable to use in the `Use Node.js` step names.

targos reviewed Jan 12, 2020

View reviewed changes

addaleax approved these changes Jan 12, 2020

View reviewed changes

gengjiawen approved these changes Jan 13, 2020

View reviewed changes

Trott approved these changes Jan 13, 2020

View reviewed changes

cjihrig approved these changes Jan 14, 2020

View reviewed changes

Trott closed this Jan 14, 2020

richardlau deleted the lintactions branch January 14, 2020 05:55

codebytere mentioned this pull request Jan 16, 2020

v13.7.0 proposal #31382

Merged

codebytere mentioned this pull request Apr 3, 2020

v12.16.2 proposal #32313

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: add GitHub actions to run linters #31323

build: add GitHub actions to run linters #31323

richardlau commented Jan 12, 2020

BridgeAR left a comment

targos Jan 12, 2020

richardlau Jan 12, 2020

BridgeAR Jan 12, 2020

richardlau Jan 13, 2020

Trott commented Jan 14, 2020

Trott commented Jan 14, 2020

build: add GitHub actions to run linters #31323

build: add GitHub actions to run linters #31323

Conversation

richardlau commented Jan 12, 2020

Checklist

BridgeAR left a comment

Choose a reason for hiding this comment

targos Jan 12, 2020

Choose a reason for hiding this comment

richardlau Jan 12, 2020

Choose a reason for hiding this comment

BridgeAR Jan 12, 2020

Choose a reason for hiding this comment

richardlau Jan 13, 2020

Choose a reason for hiding this comment

Trott commented Jan 14, 2020

Trott commented Jan 14, 2020