Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: test Python 3 using GitHub Actions-based CI #29474

Closed
wants to merge 7 commits into from
Closed

build: test Python 3 using GitHub Actions-based CI #29474

wants to merge 7 commits into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 6, 2019

WIP: Try to replicate the Travis CI testing on GitHub Actions-based CI
so that we can continue to test legacy Python on Travis CI and
run Python 3 tests on GitHub Actions-based CI.

@targos You seem to have some magic that you do
to get these GitHub Actions test to run. I would be
fascinated if you can document them. Thanks!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@cclauss cclauss added wip Issues and PRs that are still a work in progress. python PRs and issues that require attention from people who are familiar with Python. labels Sep 6, 2019
@cclauss cclauss requested a review from targos September 6, 2019 14:53
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 6, 2019
@cclauss cclauss mentioned this pull request Sep 9, 2019
Merged
targos
targos approved these changes Sep 9, 2019
View reviewed changes
.github/workflows/pythonpackage.yml Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25718/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25728/

@cclauss cclauss closed this Oct 3, 2019
@cclauss cclauss deleted the test-python3-via-github-actions branch October 3, 2019 17:39
@cclauss cclauss restored the test-python3-via-github-actions branch December 19, 2019 14:09
@cclauss cclauss reopened this Dec 19, 2019
@cclauss cclauss mentioned this pull request Jan 2, 2020
Closed
@gengjiawen gengjiawen requested a review from richardlau January 2, 2020 12:48
@gengjiawen gengjiawen mentioned this pull request Jan 2, 2020
Closed
4 tasks
@cclauss cclauss added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed wip Issues and PRs that are still a work in progress. labels Jan 9, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28346/

@richardlau richardlau mentioned this pull request Jan 12, 2020
Closed
2 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28383/

@Trott
Copy link
Member

Trott commented Jan 12, 2020

Landed in 57351b6

@Trott Trott closed this Jan 12, 2020
Trott pushed a commit that referenced this pull request Jan 12, 2020
@cclauss @Trott
build: test Python 3 using GitHub Actions-based CI
57351b6 
PR-URL: #29474
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@cclauss cclauss deleted the test-python3-via-github-actions branch January 12, 2020 02:55
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@cclauss @MylesBorins
build: test Python 3 using GitHub Actions-based CI
7a5d4fa 
PR-URL: #29474
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@cclauss @codebytere
build: test Python 3 using GitHub Actions-based CI
2f370f5 
PR-URL: #29474
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@cclauss @codebytere
build: test Python 3 using GitHub Actions-based CI
f6a6638 
PR-URL: #29474
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

@richardlau richardlau Awaiting requested review from richardlau

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cclauss @nodejs-github-bot @Trott @targos @gengjiawen @richardlau @BridgeAR