Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update status of Python 3 support #30722

Closed
wants to merge 4 commits into from

Conversation

mhdawson
Copy link
Member

Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 29, 2019
@mhdawson
Copy link
Member Author

@sam-github, @cclauss this reflect my understanding, can you validate?

BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions to simplify, but generally LGTM

@mhdawson
Copy link
Member Author

mhdawson commented Dec 3, 2019

@cclauss
Copy link
Contributor

cclauss commented Dec 3, 2019

Given that Python 2 end of life is in 29 days, I would recommend the following simplification:

The Node.js project can use either Python 2 or Python 3 in its build process. If both are installed, then Python 3 will be used. If only Python 2 is available, then it will be used instead. Whenever possible, we recommend that you build and test with Python 3.

@mhdawson
Copy link
Member Author

mhdawson commented Dec 3, 2019

CI good, just waiting for Travis to complete.

@mhdawson
Copy link
Member Author

mhdawson commented Dec 3, 2019

Travis is good landing.

mhdawson added a commit that referenced this pull request Dec 3, 2019
Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.

PR-URL: #30722
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@mhdawson
Copy link
Member Author

mhdawson commented Dec 3, 2019

Landed as 7bee77f

@mhdawson mhdawson closed this Dec 3, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.

PR-URL: #30722
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
@mhdawson mhdawson deleted the python3-doc branch September 14, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants