Remove Python3 strategic initiative #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbev
approved these changes
Nov 28, 2019
richardlau
reviewed
Nov 28, 2019
gireeshpunathil
approved these changes
Nov 28, 2019
After discussion with @cclauss, we conclude that the Python3 push is complete, and follow on issues as they come up can be handled via the normal Issue/PR process. Regular attention by the TSC is no longer required.
sam-github
changed the title
|
I had a videochat with @cclauss this morning, and we conclude this is no longer necessary to be a strategic initiative, so I removed it. New commit message: |
|
Given how different the PR is :-) I re-requested review. |
tniessen
approved these changes
Nov 28, 2019
gireeshpunathil
approved these changes
Nov 29, 2019
|
Thanks all for your guidance on this effort. We are at the stage where any Python 3 incompatibilities that we find should be treated as bugs to be fixed. This community does impressive work that helps so many people around the globe. |
cclauss
approved these changes
Nov 29, 2019
nschonni
reviewed
Nov 29, 2019
| @@ -53,8 +52,10 @@ and have the support needed. | |||
| [node#18106]: https://github.com/nodejs/node/issues/18106 | |||
| [fishrock123]: https://github.com/fishrock123 | |||
| [addaleax]: https://github.com/addaleax | |||
| [cclauss]: https://github.com/cclauss | |||
There was a problem hiding this comment.
Isn't needed now that initiative is removed
There was a problem hiding this comment.
good catch, thanks.
nschonni
reviewed
Nov 29, 2019
| [mhdawson]: https://github.com/mhdawson | ||
| [rvagg]: https://github.com/rvagg | ||
| [sam-github]: https://github.com/sam-github |
There was a problem hiding this comment.
Isn't needed now that initiative is removed
mhdawson
added a commit
to mhdawson/io.js
that referenced
this pull request
Nov 29, 2019
Refs: nodejs/TSC#781 (comment) Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support.
3 tasks
mhdawson
added a commit
to nodejs/node
that referenced
this pull request
Dec 3, 2019
Refs: nodejs/TSC#781 (comment) Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support. PR-URL: #30722 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 9, 2019
Refs: nodejs/TSC#781 (comment) Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support. PR-URL: #30722 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, reindented file, some of the tables were wonky.