-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Python3 strategic initiative #781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
After discussion with @cclauss, we conclude that the Python3 push is complete, and follow on issues as they come up can be handled via the normal Issue/PR process. Regular attention by the TSC is no longer required.
I had a videochat with @cclauss this morning, and we conclude this is no longer necessary to be a strategic initiative, so I removed it. New commit message:
|
Given how different the PR is :-) I re-requested review. |
Thanks all for your guidance on this effort. We are at the stage where any Python 3 incompatibilities that we find should be treated as bugs to be fixed. This community does impressive work that helps so many people around the globe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -53,8 +52,10 @@ and have the support needed. | |||
[node#18106]: https://github.com/nodejs/node/issues/18106 | |||
[fishrock123]: https://github.com/fishrock123 | |||
[addaleax]: https://github.com/addaleax | |||
[cclauss]: https://github.com/cclauss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't needed now that initiative is removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks.
[mhdawson]: https://github.com/mhdawson | ||
[rvagg]: https://github.com/rvagg | ||
[sam-github]: https://github.com/sam-github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't needed now that initiative is removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once @nschonni's comments are address
Refs: nodejs/TSC#781 (comment) Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support.
Refs: nodejs/TSC#781 (comment) Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support. PR-URL: #30722 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Refs: nodejs/TSC#781 (comment) Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support. PR-URL: #30722 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Also, reindented file, some of the tables were wonky.