Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x] build: build benchmark addons like test addons #30072

Closed
wants to merge 1 commit into from
Closed

[v12.x] build: build benchmark addons like test addons #30072

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Build the addons for benchmarks in the same way that the addons for
tests are built.

PR-URL: #29995
Fixes: nodejs/build#1961
Refs: 53ca0b9#commitcomment-35494896
Reviewed-By: @addaleax
Reviewed-By: @Trott
Reviewed-By: @BethGriggs
Reviewed-By: @gengjiawen

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

We need this PR along with #30070 because 53ca0b9#commitcomment-35494896

build: build benchmark addons like test addons
4d29011 
Build the addons for benchmarks in the same way that the addons for
tests are built.

PR-URL: nodejs#29995
Fixes: nodejs/build#1961
Refs: nodejs@53ca0b9#commitcomment-35494896
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v12.x labels Oct 22, 2019
@gabrielschulhof
Copy link
Contributor Author

This is identical to the version in master, except it does not add benchmark/napi/ref/.gitignore.

@gabrielschulhof gabrielschulhof mentioned this pull request Oct 22, 2019
Closed
3 tasks
@targos
Copy link
Member

targos commented Nov 8, 2019

The original commit landed on v12.x-staging.

@targos targos closed this Nov 8, 2019
@gabrielschulhof gabrielschulhof deleted the backport-29995-to-v12.x branch March 13, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gabrielschulhof @targos @gengjiawen @richardlau @BethGriggs @nodejs-github-bot