doc: clarify napi_finalize related APIs #29797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
legendecas
changed the title
gabrielschulhof
approved these changes
Oct 1, 2019
All these APIs have napi_finalize parameter but they don't behave exactly the same. Fixes: nodejs#29750
legendecas
force-pushed
the
issue-29750
branch
from
ab41da1
to
7543a4a
Compare
This comment has been minimized.
This comment has been minimized.
trivikr
added
the
author ready
Trott
approved these changes
Oct 3, 2019
|
Landed in a71fb97 |
Trott
pushed a commit
that referenced
this pull request
Oct 3, 2019
All these APIs have napi_finalize parameter but they don't behave exactly the same. Fixes: #29750 PR-URL: #29797 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2019
All these APIs have napi_finalize parameter but they don't behave exactly the same. Fixes: #29750 PR-URL: #29797 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these APIs have napi_finalize parameter but they don't behave
exactly the same.
Fixes: #29750
Checklist