Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api,doc: statements on conflicts on adding finalizers #29750

Closed
legendecas opened this issue Sep 28, 2019 · 0 comments
Closed

n-api,doc: statements on conflicts on adding finalizers #29750

legendecas opened this issue Sep 28, 2019 · 0 comments

Comments

@legendecas
Copy link
Member

  • Version: latest
  • Platform: -
  • Subsystem: doc, n-api

napi_create_external_arraybuffer and napi_create_external_buffer has a parameter napi_finalize, which may imply it would result in a finalizer creation.

Since napi_add_finalizer could be mixed with napi_wrap, there are no statements on if it is feasible that napi_wrap could be mixed with napi_create_external_arraybuffer and napi_create_external_buffer.
@legendecas legendecas mentioned this issue Oct 1, 2019
Closed
2 tasks
legendecas added a commit to legendecas/node that referenced this issue Oct 2, 2019
@legendecas
n-api,doc: clarify napi_finalize related APIs
7543a4a 
All these APIs have napi_finalize parameter but they don't behave
exactly the same.

Fixes: nodejs#29750
@Trott Trott closed this as completed in a71fb97 Oct 3, 2019
BridgeAR pushed a commit that referenced this issue Oct 9, 2019
@legendecas @BridgeAR
n-api,doc: clarify napi_finalize related APIs
20896f7 
All these APIs have napi_finalize parameter but they don't behave
exactly the same.

Fixes: #29750

PR-URL: #29797
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: clarify napi_finalize related APIs legendecas/node
1 participant
@legendecas