Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move armv6 snapshot test to configure_arm() #296

Closed
wants to merge 1 commit into from
+4 −4
Closed

build: move armv6 snapshot test to configure_arm() #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,10 @@ def configure_arm(o):
o['variables']['arm_thumb'] = 0 # -marm
o['variables']['arm_float_abi'] = arm_float_abi

# Print warning when snapshot is enabled and building on armv6
if is_arch_armv6() and not options.without_snapshot:
print '\033[1;33mWarning!! When building on ARMv6 use --without-snapshot\033[1;m'


def configure_node(o):
if options.dest_os == 'android':
Expand Down Expand Up @@ -944,8 +948,4 @@ else:

gyp_args += args

#print warning when snapshot is enabled and building on armv6
if (is_arch_armv6()) and (not options.without_snapshot):
print '\033[1;33mWarning!! When building on ARMv6 use --without-snapshot\033[1;m'

sys.exit(subprocess.call(gyp_args))