build: move armv6 snapshot test to configure_arm() #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fails on windows because is_arch_armv6() calls CC to get properties, so moved to a scope where we know we're at least on ARM
|
LGTM. |
rvagg
added a commit
that referenced
this pull request
Jan 12, 2015
fails on windows because is_arch_armv6() calls CC to get properties, so moved to a scope where we know we're at least on ARM PR-URL: #296 Reviewed-By: Chris Dickinson <[email protected]>
|
landed in 70c2501, thanks @chrisdickinson, @Cydox I haven't tested it on my pi yet, would you mind having a play with this to confirm? |
|
it actually compiles this way but it did throw an error when running 'illegeal instruction'. Edit: the other command line arguments didn´t work. #283 |
|
@Cydox I'd like to get an armv6l build into nightlies and releases but am having trouble getting a complete compile. I don't have time to investigate but would love if you could let me know when I should try and reenable this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fails on windows because is_arch_armv6() calls CC to get properties, so moved to a scope where we know we're at least on ARM
please review @chrisdickinson
/cc @Cydox