Release v12.6.0 proposal #28508
Merged
Release v12.6.0 proposal #28508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the common `.then(common.mustCall())` check to verify that. Also, we should not use `process.abort()` in `test/parallel`; if the test fails, that leaves core dumps lying around on POSIX systems. PR-URL: #28155 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
This makes sure that the `add` function is not visible by default when inspecting `process.allowedNodeEnvironmentFlags`. PR-URL: #28206 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Have clearer ownership relations between the `Http2Ping`, `Http2Settings` and `Http2Session` objects. Ping and Settings objects are now owned by the `Http2Session` instance, and deleted along with it, so neither type of object refers to the session after it is gone. In the case of `Http2Ping`s, that deletion is slightly delayed, so we explicitly reset its `session_` property. Fixes: #28088 PR-URL: #28150 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This reverts commit 9334e45. PR-URL: #27992 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
V8 now resume supporting for mipsel/mips64el. This commit add linux64-mips64 platform dependent files in 'deps/openssl/config/archs/linux64-mips64', and update the corresponding gypi files and header files. Refs: https://groups.google.com/forum/#!topic/v8-dev/oXkv5OVCXyc PR-URL: #27992 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Remove instructions (in the Collaborator Guide) to post CI links. The bot does that now. PR-URL: #28248 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
When piping data into an SHA3 hash, EVP_DigestFinal_ex is called in hash._flush, bypassing safeguards in the JavaScript layer. Calling hash.digest causes EVP_DigestFinal_ex to be called again, resulting in a segmentation fault in the SHA3 implementation of OpenSSL. A relatively easy solution is to cache the result of calling EVP_DigestFinal_ex until the Hash object is garbage collected. PR-URL: #28251 Fixes: #28245 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
The assert module has some truncation logic in a custom inspect function. This was not covered in tests. Add tests to cover it. PR-URL: #28234 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Several minor improvements to text. Remove some repetition. PR-URL: #28255 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #28252 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
When the current working directory is deleted, fall back to exec_path as the default profile directory. PR-URL: #28252 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
A few dependencies have been updated or added without running license_builder.sh. This updates based on current master branch. PR-URL: #28260 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
PR-URL: #28276 Refs: #21425 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Emit the deprecation warning in the `kDefaultUnhandledRejections` case to reduce the number of branches on unhandled rejection mode - there is now only one switch case on it. Also rename `emitWarning()` to `emitUnhandledRejectionWarning()` to avoid ambiguity with `process.emitWarning()` PR-URL: #28258 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
The C++ land `node::FatalException()` is not in fact fatal anymore. It gives the user a chance to handle the uncaught exception globally by listening to the `uncaughtException` event. This patch renames it to `TriggerUncaughtException` in C++ to avoid the confusion. In addition rename the JS land handler to `onGlobalUncaughtException` to reflect its purpose - we have to keep the alias `process._fatalException` and use that for now since it has been monkey-patchable in the user land. This patch also - Adds more comments to the global uncaught exception handling routine - Puts a few other C++ error handling functions into the `errors` namespace - Moves error-handling-related bindings to the `errors` binding. Refs: 2b252ac PR-URL: #28257 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
PR-URL: #28259 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
PR-URL: #28262 Refs: #28172 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Refs: #21425 (comment) PR-URL: #28270 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #28266 Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Address a race condition in the test; the Worker’s exit events may have been not recorded because the Worker exited before the listeners were attached. Fix the by attaching the event listeners before telling the Worker to exit. PR-URL: #28307 Fixes: #28299 Fixes: #28106 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
PR-URL: #28322 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
When the 'nobody' user is missing use .code to detect this, its more robust than than the .message string. Refs: #19594 PR-URL: #28219 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
We set the `kStartedReading` flag from `_read()` for Worker stdio,
and then `ref()` the port.
However, the `.on('end')` handler is also attached when `._read()`
is not called, e.g. when `process.stdin` inside a Worker is prematurely
ended because stdin was not enabled by the parent thread.
In that case, we should not call `.unref()` for stdin if we did not
also call `.ref()` for it before.
Fixes: #28144
PR-URL: #28153
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
This change sets the process' directory to __dirname in order to normalize where the test is ran. This addresses the situation that occurs when node is located in the root, and moving up a directory results in the same directory. In that case, an error was thrown because the test interpreted this as a failed directory change. Fixes: #28193 PR-URL: #28271 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Currently the buffer benchmarks take significantly too long to complete. This drastically reduces the overall runtime by removing obsolete checked variations and reducing the iteration count. It also improves the benchmarks by removing the deprecated `new Buffer(size)` usage and some other small improvements. PR-URL: #26418 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Peter Marshall <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This commit adds a version to the diagnostic report feature. PR-URL: #28121 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Revise the text describing `strict` mode. PR-URL: #28285 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #28280 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #28221 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes #28231 PR-URL: #28232 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Withdrawing my LGTM for now. The libuv 1.30.0 upgrade has build issues on Cygwin and Android (when built with cmake). Both of those are platforms that aren't tested in the CI, but we already have fixes for them. I'm planning to make a patch release that fixes both of those issues. It might be worth waiting on that. I'd be open to fast tracking a libuv 1.30.1 today, as the release will be of trivial complexity. |
|
libuv 1.30.1 update PR: #28511 |
This upgrade is a small patch release, fixing compilation errors on Android, Cygwin, and uClibc - none of which are tested in the CI. PR-URL: #28511 Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Notable changes:
* build:
* Experimental support for building Node.js on MIPS architecture
is back. #27992
* child_process:
* The promisified versions of `child_process.exec` and
`child_process.execFile` now both return a `Promise` which has the
child instance attached to their `child` property.
#28325
* deps:
* Updated libuv to 1.30.1. #28449,
#28511
* Support for the Haiku platform has been added.
* The maximum `UV_THREADPOOL_SIZE` has been increased from 128 to
1024.
* `uv_fs_copyfile()` now works properly when the source and
destination files are the same.
* process:
* A new method, `process.resourceUsage()` was added. It returns
resource usage for the current process, such as CPU time.
#28018
* src:
* Fixed an issue related to stdio that could lead to a crash of the
process in some circumstances.
#28490
* stream:
* Added a `writableFinished` property to writable streams. It
indicates that all the data has been flushed to the underlying
system. #28007
* worker:
* Fixed an issue that prevented worker threads to listen for data on
stdin. #28153
* meta:
* Added Jiawen Geng (https://github.com/gengjiawen) to collaborators.
#28322
PR-URL: #28508
|
Added libuv 1.30.1 |
|
One LGTM or 2 for the changelog would be nice :) |
gengjiawen
approved these changes
Jul 3, 2019
BethGriggs
approved these changes
Jul 3, 2019
|
Thanks! Release build: https://ci-release.nodejs.org/job/iojs+release/4536/ |
cjihrig
approved these changes
Jul 3, 2019
BridgeAR
approved these changes
Jul 3, 2019
targos
added a commit
that referenced
this pull request
Jul 3, 2019
Notable changes:
* build:
* Experimental support for building Node.js on MIPS architecture
is back. #27992
* child_process:
* The promisified versions of `child_process.exec` and
`child_process.execFile` now both return a `Promise` which has the
child instance attached to their `child` property.
#28325
* deps:
* Updated libuv to 1.30.1. #28449,
#28511
* Support for the Haiku platform has been added.
* The maximum `UV_THREADPOOL_SIZE` has been increased from 128 to
1024.
* `uv_fs_copyfile()` now works properly when the source and
destination files are the same.
* process:
* A new method, `process.resourceUsage()` was added. It returns
resource usage for the current process, such as CPU time.
#28018
* src:
* Fixed an issue related to stdio that could lead to a crash of the
process in some circumstances.
#28490
* stream:
* Added a `writableFinished` property to writable streams. It
indicates that all the data has been flushed to the underlying
system. #28007
* worker:
* Fixed an issue that prevented worker threads to listen for data on
stdin. #28153
* meta:
* Added Jiawen Geng (https://github.com/gengjiawen) to collaborators.
#28322
PR-URL: #28508
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jul 3, 2019
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jul 3, 2019
targos
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2019-07-03, Version 12.6.0 (Current), @targos
Notable changes
child_process.execandchild_process.execFilenow both return a
Promisewhich has the child instance attached to theirchildproperty #28325.UV_THREADPOOL_SIZEhas been increased from 128 to 1024.uv_fs_copyfile()now works properly when the source and destination files are the same.process.resourceUsage()was added. It returns resource usagefor the current process, such as CPU time #28018.
some circumstances #28490.
writableFinishedproperty to writable streams. It indicates thatall the data has been flushed to the underlying system #28007.
Commits
db65594c33] - benchmark: refactor buffer benchmarks (Ruben Bridgewater) #26418e607055693] - bootstrap: --frozen-intrinsics override problem workaround (Guy Bedford) #28254cd71aad62b] - build: expose napi_build_version variable (NickNaso) #278354d12cef2a5] - build: link libatomic on mac and linux (Gus Caplan) #28232cfb5ca3887] - build: enable openssl support for mips64el (mutao) #279922cf37f54f0] - Revert "build: remove mips support" (mutao) #27992dd5e07f9b4] - child_process: attach child in promisification (cjihrig) #28325f21ddb2131] - crypto: move _impl call out of handleError funct (Daniel Bevenius) #28318558e9cfb6c] - crypto: move _pbkdf2 call out of handleError funct (Daniel Bevenius) #2831847b230a92b] - crypto: move _randomBytes call out of handleError funct (Daniel Bevenius) #28318def96ae278] - crypto: move _scrypt call out of handleError funct (Daniel Bevenius) #28318990feafcb6] - crypto: fix crash when calling digest after piping (Tobias Nießen) #2825143677325e1] - deps: upgrade to libuv 1.30.0 (cjihrig) #284493a493b804e] - deps: upgrade to libuv 1.30.1 (cjihrig) #28511eee66c5e56] - doc: merge bootstrap/README.md into BUILDING.md (Rod Vagg) #284650111c61ec0] - doc: fix swapedOut typo (cjihrig) #2849714f6cee694] - doc: reformat for-await-of (cjihrig) #284253fea2e43c0] - doc: update readline asyncIterator docs (cjihrig) #284250d2d116446] - doc: add links to 12.5.0 changelog notable changes (Gus Caplan) #2845096e8b988d4] - doc: clean up isDead() example (cjihrig) #284213c047b3919] - doc: clarify response.finished (Robert Nagy) #284115367d02ce1] - doc: replace version with REPLACEME (cjihrig) #28431e55d0efe36] - doc: remove N-API version for Experimental APIs (Michael Dawson) #28330e3dd4d5225] - doc: fix nits regarding stream utilities (Vse Mozhet Byt) #283853d693c5ead] - doc: cleanup pendingSettingsAck docs (cjihrig) #28388b6d0cbcf20] - doc: add example code for worker.isDead() to cluster.md (Jesse Cogollo) #283620e6196cc17] - doc: add missing word in frameError event docs (cjihrig) #28387d25d40e1e5] - doc: fix sentence about Http2Stream destruction (cjihrig) #283364762399aca] - doc: add example for Buffer.isEncoding() (Angie M. Delgado) #28360818f08416c] - doc: add example code for fs.existsSync() (nicolasrestrepo) #28354d759e0fa49] - doc: remove "note that" from assert.md (Rich Trott) #28329d384911746] - doc: remove "note that" from async_hooks.md (Rich Trott) #283299ca7c8603e] - doc: remove "note that" from buffer.md (Rich Trott) #28329658c7587ff] - doc: remove "note that" from cli.md (Rich Trott) #28329cb89b3b290] - doc: remove "note that" from cluster.md (Rich Trott) #28329af05ad123e] - doc: remove "note that" from console.md (Rich Trott) #28329898b69ccdf] - doc: remove "note that" from crypto.md (Rich Trott) #28329c41dbf5bc7] - doc: remove "note that" from dgram.md (Rich Trott) #2832933d9cf5a7c] - doc: remove "note that" from dns.md (Rich Trott) #28329f3b4449c07] - doc: remove "note that" from domain.md (Rich Trott) #2832975954865e6] - doc: remove "note that" from errors.md (Rich Trott) #28329520ef836c1] - doc: remove "note that" from events.md (Rich Trott) #28329d65c90b545] - doc: remove "note that" from fs.md (Rich Trott) #283293174bc14a2] - doc: remove "note that" from http.md (Rich Trott) #28329f0a857f4b8] - doc: remove "note that" from http2.md (Rich Trott) #28329f4c6f7a5db] - doc: remove "note that" from modules.md (Rich Trott) #28329f299c44860] - doc: remove "note that" from net.md (Rich Trott) #28329b0a6da7e3c] - doc: remove "note that" from process.md (Rich Trott) #28329eba2e3c0df] - doc: remove "note that" from stream.md (Rich Trott) #283297bd2cae197] - doc: remove "note that" from tls.md (Rich Trott) #28329204c9d8aa8] - doc: remove "note that" from tty.md (Rich Trott) #283295e979bff2f] - doc: remove "note that" from url.md (Rich Trott) #28329c3c86b6da6] - doc: remove "note that" from util.md (Rich Trott) #283296d94620bfc] - doc: remove "note that" from zlib.md (Rich Trott) #28329651ab3f58e] - doc: remove "note that" from pull-requests.md (Rich Trott) #283299ac3a553ea] - doc: remove "note that" from maintaining-V8.md (Rich Trott) #28329a67afc8b60] - doc: remove "note that" from maintaining-the-build-files.md (Rich Trott) #283299461ef8afb] - doc: remove "note that" from using-symbols.md (Rich Trott) #28329ffba80b107] - doc: remove "note that" from writing-and-running-benchmarks.md (Rich Trott) #283291591309735] - doc: remove "note that" from writing-tests.md (Rich Trott) #283293daced70cf] - doc: remove "make that" from onboarding.md (Rich Trott) #2832979f23b5aa6] - doc: remove "note that" from releases.md (Rich Trott) #2832971cf5586a9] - doc: remove "note that" from CPP_STYLE_GUIDE.md (Rich Trott) #283293d6ae65181] - doc: remote "note that" from BUILDING.md (Rich Trott) #2832964f8530adc] - doc: fix typo in process.disconnect() docs (cjihrig) #28328c9226f5eb3] - doc: drop 'Note that' in addons docs (cjihrig) #28327a213eb7635] - doc: remove obsolete external link (cjihrig) #28326632fc1faf5] - doc: make multipleResolves docs less opinionated (cjihrig) #283146063cebdd6] - doc: format ECMA-262 with a hyphen (cjihrig) #2830951742b834d] - doc: revise assert legacy mode text (Rich Trott) #2831557ac661bcb] - doc: document PerformanceNodeTiming.environment field (Yuriy Vasiyarov) #282801f2b8c8cab] - doc: revise strict mode text in assert (Rich Trott) #282850856a4d043] - doc: add gengjiawen to collaborators (gengjiawen) #28322359e20f048] - doc: clarify when http emits aborted event (Robert Nagy) #28262168c12758b] - doc: tidy AssertionError text (Rich Trott) #2825517efd9372b] - doc: remove instructions to post CI links (Rich Trott) #2824891d5a4df04] - doc,n-api: fix metadata for napi_create_threadsafe_function (Richard Lau) #28410c9a96aeeee] - esm: ensure cwd-relative imports for module --eval (Guy Bedford) #28389fd4d1e20f3] - http2: remove square brackets from parsed hostname (Luigi Pinca) #28406d8d4f9b569] - http2: propagate session destroy code to streams (cjihrig) #28435d8942f877d] - (SEMVER-MINOR) http2: use writableFinished instead of _writableState (zero1five) #28007d0de204c12] - http2: refactor ping + settings object lifetime management (Anna Henningsen) #281505f9ee9f69f] - lib: fix stack overflow check to not break on primitives (kball) #28338b6a70520d2] - lib: refactor unhandled rejection deprecation warning emission (Joyee Cheung) #28258d95d610e0e] - meta: update LICENSE (Rich Trott) #28260ed8cee6b1a] - n-api: add error message for date expected (Gabriel Schulhof) #2830353297e66cb] - (SEMVER-MINOR) n-api: make func argument of napi_create_threadsafe_function optional (legendecas) #277918ad880f3fc] - net: replace _writableState.finished with writableFinished (Rich Trott) #2797419f9281743] - (SEMVER-MINOR) process: expose uv_rusage on process.resourcesUsage() (vmarchaud) #280180fd6524680] - process: split routines used to enhance fatal exception stack traces (Joyee Cheung) #28308e517b03701] - process: hide NodeEnvironmentFlagsSet'saddfunction (Ruben Bridgewater) #28206c4a357dada] - report: add report versioning (cjihrig) #28121035b613f80] - src: don't abort on EIO when restoring tty (Ben Noordhuis) #28490624fd17064] - src: fix small memory leak (David Carlier) #284520044fd2642] - src: add error codes to errors thrown in node_i18n.cc (Yaniv Friedensohn) #282215b92eb4686] - src: refactor uncaught exception handling (Joyee Cheung) #28257c491e4dfe6] - src: fall back to env->exec_path() for default profile directory (Joyee Cheung) #28252040b9db07b] - src: save exec path when initializing Environment (Joyee Cheung) #282521650bcf491] - (SEMVER-MINOR) stream: add writableFinished (zero1five) #280078a64b70efe] - test: fix flaky test-vm-timeout-escape-nexttick (Rich Trott) #284613f6f968dee] - test: skip tests related to CI failures on AIX (Sam Roberts) #28469937afcc365] - test: add test to doesNotThrow; validate if actual with regex (estrada9166) #28355004d26d5a5] - test: add tests to assert.ok and improve coverage (estrada9166) #2835582b80e0a61] - test: reset validity dates of expired certs (Sam Roberts) #28473dce4947335] - test: do not use fixed port in async-hooks/test-httparser-reuse (Anna Henningsen) #2831279b1bf5a09] - test: use assert() in N-API async test (Anna Henningsen) #28423cd78c5ef7e] - test: fixing broken test (melinamejia95) #28345d88c697f7f] - test: refactoring test, reordering arguments (David Sánchez) #28343e63990e383] - test: eliminate duplicate statements (khriztianmoreno) #28342b822545f84] - test: switch the param order in the assertion (raveneyex) #283413bc62b9374] - test: switch assertion order (Yomar) #28339ecf4494dd2] - test: tls switch arguments order for the assertion (Laura Ciro) #283404bca4a5091] - test: change order of arguments (MistyBlunch) #283594973f217b8] - test: fix order of assertion arguments in test-event-emitter-num-args (Luis Gallon) #2836869f17f1ab0] - test: make test-dh-regr more efficient where possible (Rich Trott) #283909f508e3a0a] - test: split pummel crypto dh test into two separate tests (Rich Trott) #28390e161744610] - test: move non-pummel crypto DH tests to parallel (Rich Trott) #2839016926a8183] - test: duplicated buffer in test-stream2-writable.js (Duvan Monsalve) #28380758a003f9d] - test: fix assertion argument order in test-buffer-failed-alloc-type (Alex Ramirez) #283495047006980] - test: use regex for OpenSSL function name (Daniel Bevenius) #28289b448db3e01] - test: remove test-ttywrap.writestream.js (Rich Trott) #283168346596552] - test: permit test-graph.signal to work without test runner (Rich Trott) #28305337aef0c2f] - test: normalize location test-worker-process-cwd.js runs tests (Samantha Sample) #28271c14e4d5bd5] - test: use .code for error in setgid (=) #28219c44db7fea5] - test: fix flaky test-worker-debug (Anna Henningsen) #28307424d91aacb] - test: add logging to statwatcher test (Rich Trott) #2827072f52a330b] - test: add Worker + uncaughtException + process.exit() test (Anna Henningsen) #282593a2e67b916] - test: do not spawn rmdir in test-statwatcher (João Reis) #28276d949eadc38] - test: check custom inspection truncation in assert (Rich Trott) #28234993c0dbf14] - test: make sure test function resolves in test-worker-debug (Anna Henningsen) #281551b4a7fb9cb] - tools: update unified-args to 7.0.0 for md-lint CLI (Rich Trott) #2843440ae2a6025] - tools: move python code out of jenkins shell (Sam Roberts) #28458d38b98529c] - tools: fix v8 testing with devtoolset on ppcle (Sam Roberts) #28458b8084840d8] - tools: change editorconfig's 'ignore' to 'unset' (silverwind) #2844021d2bdd3ce] - tools: remove unused using declarations (Daniel Bevenius) #284223d014e1bf9] - tools: remove out-of-date code-cache-path comment (Daniel Bevenius) #2841960cf9111cb] - tools: fix typo in js2c.py (Daniel Bevenius) #28417b744bd9dcb] - tools: update eslint (Ruben Bridgewater) #2817303e3ccdbe5] - tools: update remark-preset-lint-node to 1.7.0 (Rich Trott) #28393619eb93942] - tools: fix typo in cache_builder.cc (Daniel Bevenius) #28418dd53e6aa7f] - tools: update babel-eslint to 10.0.2 (ZYSzys) #28266e6c7ebe90c] - vm: increase code coverage of source_text_module.js (kball) #283632053dd0c9c] - worker: only unref port for stdin if we ref’ed it before (Anna Henningsen) #28153