doc: clarify when http emits aborted event #28262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Trott
reviewed
Jun 17, 2019
Trott
approved these changes
Jun 17, 2019
There was a problem hiding this comment.
Subsystem for the commit message should be doc:. Maybe something like doc: clarify when http emits aborted event? This is something that can be handled by whoever lands the PR but if you want to save someone a few keystrokes, by all means, amend the commit message and force push.
Trott
reviewed
Jun 18, 2019
Co-Authored-By: Rich Trott <[email protected]>
|
@nodejs/http (just in case this is a bug that needs to be fixed rather than a peculiarity that needs to be documented or something like that) |
trivikr
changed the title
|
This is relevant #28172 and argues a change in behaviour. However, if or until then I suggest we should clarify the existing behaviour. |
Trott
added
the
author ready
trivikr
approved these changes
Jun 18, 2019
fhinkel
approved these changes
Jun 19, 2019
fhinkel
approved these changes
Jun 19, 2019
BridgeAR
approved these changes
Jun 19, 2019
|
Landed in 1a4f27a |
addaleax
pushed a commit
that referenced
this pull request
Jun 19, 2019
PR-URL: #28262 Refs: #28172 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
PR-URL: #28262 Refs: #28172 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify premature close and
responseobject behaviour.Ref: #28172
Checklist