Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fix zlib -Wimplicit-function-declaration #273

Closed
wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

Build the bundled zlib with -DZ_HAVE_UNISTD_H to make the definition of
close(), read() and other unistd.h functions available to gzread.c and
gzwrite.c. It's kind of silly that we have to jump through hoops here
because we never call any of the functions that do I/O directly, but
at least it squelches the -Wimplicit-function-declaration warnings.

R=@piscisaureus or @shigeki

Build the bundled zlib with -DZ_HAVE_UNISTD_H to make the definition of
close(), read() and other unistd.h functions available to gzread.c and
gzwrite.c.  It's kind of silly that we have to jump through hoops here
because we never call any of the functions that do I/O directly, but
at least it squelches the -Wimplicit-function-declaration warnings.
@piscisaureus
Copy link
Contributor

lgtm, although I'm thinking that we might just not build minizip?

@piscisaureus
Copy link
Contributor

@bnoordhuis Please see #276

bnoordhuis added a commit that referenced this pull request Jan 10, 2015
Build the bundled zlib with -DZ_HAVE_UNISTD_H to make the definition of
close(), read() and other unistd.h functions available to gzread.c and
gzwrite.c. It's kind of silly that we have to jump through hoops here
because we never call any of the functions that do I/O directly, but at
least it squelches the -Wimplicit-function-declaration warnings.

PR-URL: #273
Reviewed-by: Bert Belder <[email protected]>
@piscisaureus
Copy link
Contributor

Thanks, landed in 59ad4b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants