Skip to content

Commit

Permalink
deps: fix zlib -Wimplicit-function-declaration
Browse files Browse the repository at this point in the history
Build the bundled zlib with -DZ_HAVE_UNISTD_H to make the definition of
close(), read() and other unistd.h functions available to gzread.c and
gzwrite.c. It's kind of silly that we have to jump through hoops here
because we never call any of the functions that do I/O directly, but at
least it squelches the -Wimplicit-function-declaration warnings.

PR-URL: #273
Reviewed-by: Bert Belder <[email protected]>
  • Loading branch information
bnoordhuis authored and piscisaureus committed Jan 10, 2015
1 parent 12912c6 commit 59ad4b0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions deps/zlib/zlib.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
['OS!="win"', {
'product_name': 'chrome_zlib',
'cflags!': [ '-ansi' ],
'defines': [ 'Z_HAVE_UNISTD_H' ],
'sources!': [
'contrib/minizip/iowin32.c'
],
Expand Down

0 comments on commit 59ad4b0

Please sign in to comment.