Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: refactor deprecated UVException in node_file.cc #27280

Closed
wants to merge 1 commit into from
Closed

src: refactor deprecated UVException in node_file.cc #27280

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Apr 17, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22540/

@gengjiawen gengjiawen mentioned this pull request Apr 20, 2019
Closed
2 tasks
@gengjiawen
Copy link
Member Author

@danbev @ZYSzys Can you retry failed job, also for #27279 and #27264 ? thanks.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22674/

@gengjiawen
Copy link
Member Author

Looks like this one and #27264 still failed.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22686/

@gengjiawen
Copy link
Member Author

@danbev @ZYSzys Can you merge this one ? thanks.

@ZYSzys
Copy link
Member

ZYSzys commented Apr 27, 2019

Landed in f4c77f9 🎉

@ZYSzys ZYSzys closed this Apr 27, 2019
ZYSzys pushed a commit that referenced this pull request Apr 27, 2019
@gengjiawen @ZYSzys
src: refactor deprecated UVException in node_file.cc
f4c77f9 
PR-URL: #27280
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@gengjiawen gengjiawen deleted the refactor_deprecated_UVException branch April 27, 2019 07:29
targos pushed a commit that referenced this pull request Apr 27, 2019
@gengjiawen @targos
src: refactor deprecated UVException in node_file.cc
3614a00 
PR-URL: #27280
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Apr 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gengjiawen @nodejs-github-bot @ZYSzys @addaleax @cjihrig @richardlau