Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: apply clang-tidy modernize-deprecated-headers found by Jenkins CI #27279

Closed
wants to merge 1 commit into from
Closed

src: apply clang-tidy modernize-deprecated-headers found by Jenkins CI #27279

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Apr 17, 2019 •
edited
Loading

Found by https://ci.nodejs.org/job/node-clang-tidy/7/console.

cc @refack

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 17, 2019
@gengjiawen gengjiawen force-pushed the deprecated_headers branch 2 times, most recently from 742af1b to 9884287 Compare April 17, 2019 15:53
@gengjiawen gengjiawen changed the title src: apply clang-tidy modernize-deprecated-headers found by Jenkins CI. src: apply clang-tidy modernize-deprecated-headers found by Jenkins CI Apr 17, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22541/

@gengjiawen
Copy link
Member Author

@addaleax @refack Can you review this ? Thanks.

This was referenced Apr 20, 2019
Closed
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22675/

@gengjiawen
Copy link
Member Author

@danbev Can you merge this ? Thanks.

@danbev
Copy link
Contributor

danbev commented Apr 26, 2019

Landed in 5fe4d59.

@danbev danbev closed this Apr 26, 2019
danbev pushed a commit that referenced this pull request Apr 26, 2019
@gengjiawen @danbev
src: apply clang-tidy modernize-deprecated-headers found by Jenkins CI
5fe4d59 
PR-URL: #27279
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 27, 2019
@gengjiawen @targos
src: apply clang-tidy modernize-deprecated-headers found by Jenkins CI
8089d29 
PR-URL: #27279
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gengjiawen @nodejs-github-bot @danbev @addaleax