-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: replace GYP with GYP3 #26620
tools: replace GYP with GYP3 #26620
Conversation
This comment has been minimized.
This comment has been minimized.
(If possible to change now that it's opened, maybe make this a draft pull request?) |
I was looking for how to do that... Only found it after reading the docs. Anyway, this should be working now, and it's ready for Rubber Stamp reviews. |
e918e3f
to
2b6fd3f
Compare
Whatever happened to the plan to transfer into this org? nodejs/admin#247 |
That has been shelved for various $REASONS. |
There are unrelated changes in the LICENSE file |
That's what I got from re-generating 🤷♂️ BTW: for easy review, first commit is pure GYP vendoring. Second (ATM 2b6fd3f) is just changes in node file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major +1.
I can't reproduce. If I run |
2b6fd3f
to
49a1c5f
Compare
Issue resolved. LICENSE regenerated. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@refack Need rebase. |
Anyone want to help me figure out what I broke WRT cross-compilation? refack/GYP3@bd11dd1...d1f1343 |
73fd43c
to
a669e35
Compare
This comment has been minimized.
This comment has been minimized.
AIX builds seem to have the following error in their logs (e.g. https://ci.nodejs.org/job/node-test-commit-aix/22631/nodes=aix61-ppc64/console) |
ARMv7 builds seem to fail with this error:
|
a669e35
to
aec2150
Compare
See nodejs/node#26620 and bincrafters/community#851 for further reasoning
What is the status of this? |
FWIW, sam-github@c70af5c is another vendoring attempt I made that duplicates this, except its done against current master. |
While I was a huge fan of this PR back in the day, I now believe that we can close it. Is there anything that we need to carry forward? |
Closing because it isn't active, but not because it isn't worthwhile if anyone wants to take it up again. |
Replace the abandoned GYP with GYP3, which has the following benefits:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesFixes: #28555