Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job request: CI testing for GYP3 #1789

Closed
refack opened this issue Apr 24, 2019 · 5 comments
Closed

job request: CI testing for GYP3 #1789

refack opened this issue Apr 24, 2019 · 5 comments

Comments

@refack
Copy link
Contributor

refack commented Apr 24, 2019

I would like to have a job that does CI testing for GYP3 on the Node.js cluster.

Currently testing in done only on Windows, Ubuntu, and macOS (all on Intel X64). This is only a subset of the platforms supported by node-core. As a result bugs and regressions can only be discovered at the earliest at integration time (e.g. nodejs/node#26620), which significantly slows down the development cycle.

Although GYP/GYP3 are not OpenJSF projects, they are is still very important for the development on node-core, and are paramount for the Node.js ecosystem via node-gyp.

@refack refack self-assigned this Apr 24, 2019
@rvagg
Copy link
Member

rvagg commented Apr 24, 2019

You have my ⚔️ for this. It's been discussed on and off for years but nobody has done it. I'd love to see a node-gyp job in ci and I encourage you to have a go at building it! Just be conscious of security and the risks of running arbitrary code on machines that aren't isolated between runs.

@richardlau
Copy link
Member

You have my ⚔️ for this. It's been discussed on and off for years but nobody has done it. I'd love to see a node-gyp job in ci and I encourage you to have a go at building it! Just be conscious of security and the risks of running arbitrary code on machines that aren't isolated between runs.

Gyp != node-gyp. We already have node-gyp testing in https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/ (which IMO we should extend to cover more platforms).

+1 for adding gyp3 testing in the CI.

@rvagg
Copy link
Member

rvagg commented Apr 24, 2019

Oh well, it just shows how tuned in I am I guess! Well you have my +1 anyway.

@cclauss
Copy link
Contributor

cclauss commented Apr 25, 2019

What help is needed?

@github-actions
Copy link

github-actions bot commented Mar 5, 2020

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale label Mar 5, 2020
@github-actions github-actions bot closed this as completed Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants