http2: make compat writeHead not crash if the stream is destroyed #24723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v6.x
http2
|
cc @StephenLynx |
richardlau
approved these changes
Nov 29, 2018
Co-Authored-By: mcollina <[email protected]>
jasnell
approved these changes
Nov 29, 2018
lpinca
approved these changes
Nov 29, 2018
Trott
added
the
author ready
|
Landed in 32fed93 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 3, 2018
Fixes: nodejs#24470 PR-URL: nodejs#24723 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 5, 2018
Fixes: #24470 PR-URL: #24723 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Fixes: nodejs#24470 PR-URL: nodejs#24723 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
Fixes: #24470 PR-URL: #24723 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Fixes: #24470 PR-URL: #24723 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #24470
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes